From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#65481: Replace defadvice with advice-add in Tramp manual Date: Thu, 07 Sep 2023 15:07:02 +0200 Message-ID: <878r9iyvwp.fsf@gmx.de> References: <87msygdgsh.fsf@gmx.de> <87zg1zmfvc.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65481-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 15:10:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeElo-00083t-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 15:10:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeEk4-0006sr-9h; Thu, 07 Sep 2023 09:08:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeEjr-0006k9-DJ for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:08:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeEjr-0001Y2-0d for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeEjq-0003pw-2Y for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:08:02 -0400 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65481 X-GNU-PR-Package: emacs Mail-Followup-To: 65481@debbugs.gnu.org, michael.albinus@gmx.de, stefankangas@gmail.com Original-Received: via spool by 65481-done@debbugs.gnu.org id=D65481.169409203614691 (code D ref 65481); Thu, 07 Sep 2023 13:08:01 +0000 Original-Received: (at 65481-done) by debbugs.gnu.org; 7 Sep 2023 13:07:16 +0000 Original-Received: from localhost ([127.0.0.1]:38835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeEj6-0003os-7R for submit@debbugs.gnu.org; Thu, 07 Sep 2023 09:07:16 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:34705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeEj1-0003oS-Mi for 65481-done@debbugs.gnu.org; Thu, 07 Sep 2023 09:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1694092023; x=1694696823; i=michael.albinus@gmx.de; bh=jQo+t8sG6iLHMw9ecX8jSNSsDgFa8HmYJ02P6BApEeM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Y0hdL6WybifePtKblxcawA8lDCl1vxkeyFihQ04phDhn321Hg5CPMwYOomDEFE+xALabQCe og/ZtlCK7/h47cubGzdPjSJqcJt+eylwdMaatx6eTzRrOapqs0jeLnD+L/X410PJkfzvW+0Cv rc6WrdXbCkHyiySuGuaY3C/d+6FFTUlpgVxOGi/Kr7/7QgdiGZXX2UVHtJgk9NJxqO+OO/i8o dT4I/Hcx6tbFIq0LNGie0WAJNW+GqSL7+Ydh9EhFPWvN+8C7tOwWK6lFGxcWXvvrtCq52S2LL 3bOOTPI+gupBzrkdOal6A58oGDQI2KcE8gAvTRc8oldmHtwa/INA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MzQkE-1piqm720vI-00vRkH; Thu, 07 Sep 2023 15:07:03 +0200 In-Reply-To: <87zg1zmfvc.fsf@gmx.de> (Michael Albinus's message of "Wed, 06 Sep 2023 18:21:59 +0200") X-Provags-ID: V03:K1:2IA/TFxQj3kElr2rnTjKiZMZNbrMeBxkaOqrGz+ceFy1iHj3qoB 8JonWbTf1JhIvhP//qXbnloTVSiB1gsdT99NjgxKZfz+RFKJTxRA7iuRn2MATtsY5505Xw2 usNAd+SCf+UB6TCdOwS9L/oOHxTK38QKe1bZI1IaZb/xmRm/rE6jQd6unu2sRmL81EfxC4P Odn/g3l/jNrTyg26W4jZA== UI-OutboundReport: notjunk:1;M01:P0:IT5AfEArGXw=;HkwViGamJRke93MX529iXjG6/GQ XbKpxwsS5av2bxqDpjcQScuh67pzD8iSH7EgUUiVoulvqF8nv8/M4A0P/IcRSNesz5G4mfYDA YIDSN09COAWtA+12EIlfrXsWhOU7J64gmgX+4/F0e49Su9KEOvXw0CmGi5CZzgF+HUyUuU+YW 7abdDqaq+d0rsXLC6mE9ra9JIBGlT56y/D6OaPiiuYL5UEivfccguEKok+Y3rmtvDoT6S1lLW ahNL/SgOedq8yuhJtykLEoLpr5kmbiJl9xqiADR/1GPK9AhXzGc1rvOf7TmwZxvTyDZovLRkV M35ZLiJTe5vmdv6ogjPPDKZ/TmgqKBhhILimQsy6MDshOlnwYKxwQcpSWXfu32SnsIMMhqxa4 7nKjdUTOTU060RhGPyHr3Ly0tlFqRFucETCTWb4R3fs5UYc+McSAGomAr1J5jToU1JmN3QpRw 3dCz/3uRQDIJpsyfwrMSOkIuUssWAcEHHVO0DhP4D13LlcbiZVIXqZ1HLIYAIT7c1rJINTa2S 4AD7gQcAEGE343dA9riUjsdhJwWAijXrZ2Ekgj5o/r+csFTPI+smflWeihYV/oL3hocdpO0HY ahiNl0lNNxKuRpyE8fCXmAkr2MJQkGEE0NX1LLBba+Bk8yWTm5XiD9git69yk8VOHsu+RbtBC qHD8nAHCWhd6vR4G7A6VzfNY7Y4E7qoTfgUo4g0+NwLndNMRYPJ9dT9sa0FyNnvVCwllMOyCD 5szpcBvgSM6KaMk/BBN19U3keqMXGBTrb3svA/LzkvcGSYbnk+WgsAKB81C4kBP5ZtgNKP3/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269649 Archived-At: Version: 29.2 Hi Stefan, >>>> The Tramp manual recommends `defadvice', but it is now obsolete >>>> (commit 27ed565ec6). How about changing the below examples to use >>>> `advice-add' instead? >>>> >>>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region >>>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file >>>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents >>>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete >>> >>> Yes, pls do. >> >> I was hoping someone more familiar with Tramp could do it, wink wink. > > I'm short in time last week and this one. Will do when time permits, > likely over the weekend. Surprisingly, it's a calm day. So I've adapted the Tramp manual, pushed to the emacs-29 branch. Closing the bug. Best regards, Michael.