From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Mon, 11 Sep 2023 14:51:18 +0200 Message-ID: <878r9c27qx.fsf@ledu-giraud.fr> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> <878r9losil.fsf@ledu-giraud.fr> <83tts2scvp.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36531"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 14:52:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfgOf-000472-6y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 14:52:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfgOW-0000mr-0P; Mon, 11 Sep 2023 08:52:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfgOU-0000ma-LC for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 08:51:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfgOU-00072W-Cq for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 08:51:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfgOY-0003sK-3a for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 08:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169443668714851 (code B ref 64440); Mon, 11 Sep 2023 12:52:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 11 Sep 2023 12:51:27 +0000 Original-Received: from localhost ([127.0.0.1]:52331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfgNz-0003rT-G8 for submit@debbugs.gnu.org; Mon, 11 Sep 2023 08:51:27 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:26698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfgNw-0003rJ-S9 for 64440@debbugs.gnu.org; Mon, 11 Sep 2023 08:51:26 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=Az/4P0v/ BSxHt4VxsiVBg0L4BEX0A8LTub04/DQglEg=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=rejyfAhJqXXB8jOlAS175foklVNnga KGt8wtLI2N8JhmgRC5Glm7taKP+YMKeeY+epkDk9SRu68GbhxZ27U5Dg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Az/4P0v/BSxHt4Vx siVBg0L4BEX0A8LTub04/DQglEg=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=YjStBMr5QBlvfeqqqop1MsH1TUkgoUY319usHQ PGH7yQAyz/hgab7zIxhPtxT+f5IQ0oddXRPGXt9sFS8C7juVtAoUA9TAUjyppkLDzUuRKj E1EbLQ4dqduScBmQ1bmf9hhaRX07AfHMO6m+nfcACceDxvofNmr5czEzoe3/0jo2zPd7kp 3VnR/dD6jMEJYtufPhQ2p5scI0fjZQvW5G8s7D9ZVpO/STbz1Io6ZOXmiIsAIWOYpnZV6V TDGES0eToeaOXSCQMrWzIt2wjTkcTf1/cO7yPXZtl2H+207FICtKNciq0KjjZcLM34NOyh wM7YJ5TN7evqeEpoxdXqtZ3g== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 5254bfd1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 11 Sep 2023 14:51:19 +0200 (CEST) In-Reply-To: <83tts2scvp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Sep 2023 10:31:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270087 Eli Zaretskii writes: [...] >> --- a/src/xdisp.c >> +++ b/src/xdisp.c >> @@ -33878,6 +33878,9 @@ show_mouse_face (Mouse_HLInfo *hlinfo, enum draw_glyphs_face draw) >> if (FRAME_WINDOW_P (f) && NILP (track_mouse)) >> { >> if (draw == DRAW_NORMAL_TEXT >> +#ifndef HAVE_EXT_MENU_BAR >> + && !EQ (hlinfo->mouse_face_window, f->menu_bar_window) >> +#endif > > Won't this cpp conditional be true in a build --without-x? Should it? No, I was wrong. This one is ok because, we already are into an "#ifdef HAVE_WINDOW_SYSTEM" here. -- Manuel Giraud