From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/hyperdrive b5294b4354 4/4: Tidy: Use zerop instead of = 0 Date: Fri, 13 Oct 2023 16:26:17 -0700 Message-ID: <878r8614sr.fsf@ushin.org> References: <169722725606.27637.3820182151024041420@vcs2.savannah.gnu.org> <20231013200057.2C7FCC09BC9@vcs2.savannah.gnu.org> <87mswmqiif.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 14 08:06:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrXnZ-0002FK-BL for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Oct 2023 08:06:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrXmo-0000hW-7X; Sat, 14 Oct 2023 02:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrRZa-00081v-JW for emacs-devel@gnu.org; Fri, 13 Oct 2023 19:28:02 -0400 Original-Received: from out-197.mta1.migadu.com ([95.215.58.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrRZY-0003nB-5G for emacs-devel@gnu.org; Fri, 13 Oct 2023 19:28:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ushin.org; s=key1; t=1697239673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xa9foO8J+3lhw3CFdecJQiBDYgTfq+GtrjW3YuW9acw=; b=FnVQJgTqK9c5BpcX0VCl3OZDOAQ1Iwd9n6hFaqa2PQTs+KRDXpeKQG9qEIWTLH9RlInKEl pU5uVpZOQX0qs6yzjyiW31toBPcgmzWoBBi2bzjjDfimI31r560+VjeAY/UsJ2tp4LARvH hZvrqFH5w2ocI29X9wFjgbdGn+XwOdjoJgTnNv1deT6lRqIavFlnmUdY5E7omsnFXmWSnn q8+iqYXf4UBkjx02pbxGGPowgHvtJjT2FzX5u/iuD7zPEaaLPmzxd4nOUXHEc62LwPLAE+ GxmNiw71dJ78rDj/7N/vJIbo9WLtuZS3j0cRzJqbRcq7SEi4MH036eAZM2OFNQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87mswmqiif.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.197; envelope-from=joseph@ushin.org; helo=out-197.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 14 Oct 2023 02:06:01 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311438 Archived-At: Philip Kaludercic writes: > FWIW this doesn't matter that much, you can check the disassembly to > see what is going on after byte compilation: > > (disassemble (byte-compile (lambda (a) (= a 0)))) > (disassemble (byte-compile (lambda (a) (zerop a)))) Thank you! I didn't know that :) > ELPA Syncer writes: > >> branch: elpa/hyperdrive >> commit b5294b43547379e87435c294670f4a23ac0739b7 >> Author: Joseph Turner >> Commit: Joseph Turner >> >> Tidy: Use zerop instead of = 0 >> --- >> hyperdrive-lib.el | 2 +- >> hyperdrive.el | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el >> index 1801fe0076..e2696160c9 100644 >> --- a/hyperdrive-lib.el >> +++ b/hyperdrive-lib.el >> @@ -1033,7 +1033,7 @@ With universal prefix argument \\[universal-argument], prompt for entry." >> With FORCE-PROMPT or when current hyperdrive does not match >> PREDICATE, return a hyperdrive selected with completion. In this >> case, when PREDICATE, only offer hyperdrives matching it." >> - (when (= 0 (hash-table-count hyperdrive-hyperdrives)) >> + (when (zerop (hash-table-count hyperdrive-hyperdrives)) >> (hyperdrive-user-error "No known hyperdrives. Use `hyperdrive-new' to create a new one")) >> (unless predicate >> ;; cl-defun default value doesn't work when nil predicate value is passed in. >> diff --git a/hyperdrive.el b/hyperdrive.el >> index 824d33ba24..fcd2715b55 100644 >> --- a/hyperdrive.el >> +++ b/hyperdrive.el >> @@ -827,7 +827,7 @@ The return value of this function is the retrieval buffer." >> :help "Create a new hyperdrive"] >> ("Drives" >> :active (< 0 (hash-table-count hyperdrive-hyperdrives)) >> - :label (if (= 0 (hash-table-count hyperdrive-hyperdrives)) >> + :label (if (zerop (hash-table-count hyperdrive-hyperdrives)) >> "Drives (empty)" >> "Drives") >> :filter (lambda (_)