Re: master 8fef7150d6b 3/3: Prefer HTTPS in `M-x webjump´

Re: master 8fef7150d6b 3/3: Prefer HTTPS in `M-x webjump´

[Michael Albinus]

Stefan Kangas <stefankangas@gmail.com> writes:

Hi Stefan,

>     * lisp/net/webjump.el (webjump-url-fix): Prefer HTTPS to HTTP.
>     (webjump-sites): Document the above change.
>     (webjump-sample-sites): Change some links to HTTP only.

This breaks webjump-tests:

--8<---------------cut here---------------start------------->8---
# make -C test webjump-tests
Running 7 tests (2023-10-25 20:22:14+0200, selector `(not (or (tag :unstable) (tag :nativecomp)))')
   passed  1/7  webjump-tests-builtin (0.000101 sec)
   passed  2/7  webjump-tests-builtin-check-args (0.000087 sec)
   passed  3/7  webjump-tests-mirror-default (0.000043 sec)
   passed  4/7  webjump-tests-null-or-blank-string-p (0.000060 sec)
   passed  5/7  webjump-tests-url-encode (0.000075 sec)
Test webjump-tests-url-fix backtrace:
  signal(ert-test-failed (((should (equal (webjump-url-fix "gnu.org")
  ert-fail(((should (equal (webjump-url-fix "gnu.org") "http://gnu.org
  (if (unwind-protect (setq value-79 (apply fn-77 args-78)) (setq form
  (let (form-description-81) (if (unwind-protect (setq value-79 (apply
  (let ((value-79 'ert-form-evaluation-aborted-80)) (let (form-descrip
  (let* ((fn-77 #'equal) (args-78 (condition-case err (let ((signal-ho
  (closure (t) nil (let* ((fn-67 #'equal) (args-68 (condition-case err
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name webjump-tests-url-fix :documentation
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/webjump-tests.el
  command-line()
  normal-top-level()
Test webjump-tests-url-fix condition:
    (ert-test-failed
     ((should (equal (webjump-url-fix "gnu.org") "http://gnu.org/")) :form
      (equal "https://gnu.org/" "http://gnu.org/") :value nil :explanation
      (arrays-of-different-length 16 15 "https://gnu.org/"
				  "http://gnu.org/" first-mismatch-at 4)))
   FAILED  6/7  webjump-tests-url-fix (0.000131 sec) at lisp/net/webjump-tests.el:58
   passed  7/7  webjump-tests-url-fix-trailing-slash (0.000174 sec)

Ran 7 tests, 6 results as expected, 1 unexpected (2023-10-25 20:22:14+0200, 0.499284 sec)

1 unexpected results:
   FAILED  webjump-tests-url-fix
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master 8fef7150d6b 3/3: Prefer HTTPS in `M-x webjump´

[Stefan Kangas]

Michael Albinus <michael.albinus@gmx.de> writes:

>>     * lisp/net/webjump.el (webjump-url-fix): Prefer HTTPS to HTTP.
>>     (webjump-sites): Document the above change.
>>     (webjump-sample-sites): Change some links to HTTP only.
>
> This breaks webjump-tests:

Thanks, should be fixed now (commit 01242dda779).