From: Philip Kaludercic <philipk@posteo.net>
To: Eshel Yaron <me@eshelyaron.com>
Cc: "Dmitry Gutov" <dmitry@gutov.dev>,
"João Távora" <joaotavora@gmail.com>,
66948@debbugs.gnu.org
Subject: bug#66948: [PATCH] Add Completion Preview mode
Date: Mon, 06 Nov 2023 07:36:08 +0000 [thread overview]
Message-ID: <878r7b72qf.fsf@posteo.net> (raw)
In-Reply-To: <m11qd4q957.fsf@dazzs-mbp.home> (Eshel Yaron's message of "Sun, 05 Nov 2023 20:42:44 +0100")
Eshel Yaron <me@eshelyaron.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Eshel Yaron <me@eshelyaron.com> writes:
>>
>>> Tags: patch
>>>
>>> Following the recent discussion on emacs-devel[0], I'm attaching a patch
>>> that adds a new Completion Preview minor mode.
>>
>> I didn't follow the discussion in detail, but is this related to the
>> capf-autosuggest package?
>
> `capf-autosuggest` didn't really come up so far. It is related to
> Completion Preview, but `capf-autosuggest` only deals with `comint`-like
> buffers, while Completion Preview works in all buffers. I don't know if
> and how `capf-autosuggest` could be extended to work in arbitrary buffers.
It should be possible, but from what I see the capf-autosuggest code has
a lot of additional integration into comint, that could probably be
separated, or perhaps even build on your completion-preview-mode.
>> FWIW From a brief test, my main annoyances have been that DEL drops any
>> completion
>
> Thanks for testing. To have DEL not dismiss the completion preview, add
> `delete-backward-char` to `completion-preview-commands`. Actually,
> would it make sense to have that behavior by default?
I think it would.
>> and that there is no option to cycle between inexact completions.
>
> That's interesting, can you elaborate about the use case that you have
> in mind? I thought about adding a command to do that, but I wasn't sure
> there'd be a good use case for it since you can always dismiss the
> preview (e.g. with `C-g`) and say `C-M-i` to pick another candidate.
Just to use M-n/M-p to cycle through what the different completion
options are, without having to request a window that might mess up my
frame layout.
>>> [0] https://lists.gnu.org/archive/html/emacs-devel/2023-10/msg00693.html
>>>
>>> + (pcase (bounds-of-thing-at-point 'symbol)
>>
>> [...]
>>
>> You can use `pcase-let' here.
>>
>
> Good idea, I'll try it out.
>
>
> Best,
>
> Eshel
next prev parent reply other threads:[~2023-11-06 7:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 10:26 bug#66948: [PATCH] Add Completion Preview mode Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-05 18:26 ` Philip Kaludercic
2023-11-05 19:42 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 7:22 ` Juri Linkov
2023-11-06 15:30 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 18:05 ` Juri Linkov
2023-11-06 19:47 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 7:08 ` Juri Linkov
2023-11-08 7:30 ` Juri Linkov
2023-11-08 9:14 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-08 15:44 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-09 7:25 ` Juri Linkov
2023-11-10 7:09 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 7:43 ` Eli Zaretskii
2023-11-10 7:58 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 7:59 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 13:05 ` Eli Zaretskii
2023-11-10 16:23 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-11 8:53 ` Eli Zaretskii
2023-11-11 12:01 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 13:27 ` Eli Zaretskii
2023-11-15 14:22 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 17:17 ` Eli Zaretskii
2023-11-15 19:02 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 8:00 ` Philip Kaludercic
2023-11-06 7:36 ` Philip Kaludercic [this message]
2023-11-06 15:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 10:28 ` Sean Whitton
2023-11-15 10:57 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r7b72qf.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=66948@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=joaotavora@gmail.com \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.