From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto <thievol@posteo.net> Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 25 Nov 2023 19:59:26 +0000 Message-ID: <878r6leh9d.fsf@posteo.net> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15991"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Eli Zaretskii <eliz@gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 21:00:21 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1r6ypB-0003ye-GP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 21:00:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1r6yop-000101-7U; Sat, 25 Nov 2023 14:59:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6yon-0000zt-V8 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 14:59:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6yon-0005IZ-Kb for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 14:59:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6yos-00020y-Q5 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto <thievol@posteo.net> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 20:00:02 +0000 Resent-Message-ID: <handler.66394.B66394.17009423897695@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.17009423897695 (code B ref 66394); Sat, 25 Nov 2023 20:00:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 25 Nov 2023 19:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:40343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1r6yoe-000203-JF for submit@debbugs.gnu.org; Sat, 25 Nov 2023 14:59:49 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:33477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thievol@posteo.net>) id 1r6yoc-0001zp-H8 for 66394@debbugs.gnu.org; Sat, 25 Nov 2023 14:59:47 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1BECF240028 for <66394@debbugs.gnu.org>; Sat, 25 Nov 2023 20:59:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1700942375; bh=PAX69Stun0Qk7J2MxN+jcjbA+QHsm4pXliFLGP2FyW4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=pGMPcVL03rs6nwOj7hHIu5mwezjLtMC3bsaULeQBfEVHPZyUB4a0NzfK35Rx2UMkz jGHQa62huyT5h5M0CnAblXHRJbYcXBGuBOegvmqo/J1ZgaXL7eXWIiOWxTpPaANQaq tkTUZMNm0htbZa5Ld1z6gz8XA41uc7i3MLDnnG5lkB1VhRwmbTnw4syzIIsCUH2mdr SbFQa0t3EI6C/urV8V+e9tDCir55PFxgczBCiMDlgxYF1Y/YfxFgPmWIcy7cMUI/Xd Zo6iIMukSmqIvdPvFPEaInMsWPiNHo43cA9Jvdy2uHi8wQ2Kxmv6qguL5nK7KBsfln jEoEE0WTlesxw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sd2kF0wLzz6txs; Sat, 25 Nov 2023 20:59:32 +0100 (CET) In-Reply-To: <83o7ficesp.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Nov 2023 12:23:18 +0200 (9 hours, 22 minutes, 8 seconds ago)") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275016 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/275016> --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Eli, Eli Zaretskii <eliz@gnu.org> writes: >> Cc: Michael Heerdegen <michael_heerdegen@web.de>, stefankangas@gmail.com, >> 66394@debbugs.gnu.org >> From: Thierry Volpiatto <thievol@posteo.net> >> Date: Mon, 20 Nov 2023 18:51:10 +0000 >>=20 >> Stefan Monnier <monnier@iro.umontreal.ca> writes: >>=20 >> >> Ccing also Stefan monnier because for some reasons the patch when >> >> applied doesn't compile (when compiling Emacs) unless we add on >> >> top: >> >> >> >> (cl--generic-prefill-dispatchers 0 (eql 'x) integer) >> >> >> >> following the advice of the compiler, >> > >> > Indeed, this is needed because `register.el` is preloaded and method >> > dispatcher are generated&compiled "on the fly" but we don't want to >> > preload the compiler, so we want to pre-compile the dispatchers used >> > by the preloaded code. >> > >> >> but I am not sure it is the way to do. >> > >> > `cl--generic-prefill-dispatchers` is not guaranteed to be defined when >> > we load `register.el` (it's only defined if we loaded the non-compiled >> > version of `cl-generic.el`) so the above call should be in >> > `cl-generic.el` rather than in `register.el`. >> > >> > I'd put it next to the following block: >> > >> > (cl--generic-prefill-dispatchers 0 (eql nil)) >> > (cl--generic-prefill-dispatchers window-system (eql nil)) >> > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--g= et-selection) >> > (eql nil)) >> > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--s= et-selection) >> > (eql nil)) >> > >> > which is already about dispatchers needed to support other files. >>=20 >> I will for now leave the call to `cl--generic-prefill-dispatchers` in >> the patch as a reminder that it should be added instead in cl-defgeneric >> once merging. > > I tried to install the patch, but it fails to compile: > > ELC ../lisp/register.elc > > In toplevel form: > register.el:33:37: Warning: `eql' called with 1 argument, but requires 2 > register.el:33:45: Warning: reference to free variable `integer' I have not these warnings. > This then fails the build, since 'register' is preloaded. Here it is building fine, this from the last Emacs master from tonight. > Thierry, can you please fix the code, so that I could install it? Or > what am I missing? Don't know, did you "make clean" first? NOTE: I leaved the patch like this but it needs the change suggested by Stefan before merging (or with an extra commit) see above. > P.S. Also, the log message is not according to our conventions. I don't remember now what are your conventions for commits, perhaps you can correct it if needed? Thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmViUh4THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk45ADACbC4OwxOe7cxEFqm8o6S0x0yeqbNKd 8DUqJHtYQx26JYQyfShmQK6CkIjT1acAaw2zDd1ijlwIA79tpG4nnMAiHX1Zr19K DnHNqZ/kUN5kcePiNXoNbgDNln1sMorXbXJsCC1ZOpUyQZZ5U8APwjVSsdx6mFGD HVgQTtNyJTI98Nfo8GPA1KnlTpp8JM3NNpo5uw2Qkybzm/p7qSVNfVk7m7od00on sVSrLcV2tuJFhST4L/cO7ugtC9w2djvCyvUj9DGo5pNa12JHFW5F1DfPXejgen3B Gp0Xg0cpam5SyatxcoD/EQnmJLmFXtpvnc2zpNX4FlLo8ozM6Nrmbj0IyOAx9dhT GMg7ddc4WPR4INx6nMJVpzUMPISFHnVwKiRbQIgExwEMCGYTRr9Xk+dY8dGfAczT zlxNzvWp0d60b8CEegRhFJH/sUhaZuoFVEwL7g3IlKM61GUskc9pmPP7jCVXunIm QbMUAWUFhHfo31wi2vqWLxFwkmHQ3eveL3s= =eRqX -----END PGP SIGNATURE----- --=-=-=--