man broken?

man broken?

[T.V Raman]

Invoking man M-x man on any program, eg ls returns error:

Invalid function: connection-local-value

appears to be due to tramp related logic in man-shell-file-name

-- 

-- 

Re: man broken?

[Michael Albinus]

"T.V Raman" <raman@google.com> writes:

Hi,

> Invoking man M-x man on any program, eg ls returns error:
>
> Invalid function: connection-local-value
>
> appears to be due to tramp related logic in man-shell-file-name

connection-local-value is a new macro. So you need to recompile
man.el. Since it is used somewhere else as well, 'make bootstrap' might
be the best option.

Best regards, Michael.

Re: man broken?

[Eli Zaretskii]

> Date: Wed, 27 Dec 2023 10:28:38 -0800
> From: "T.V Raman" <raman@google.com>
> 
> Invoking man M-x man on any program, eg ls returns error:
> 
> Invalid function: connection-local-value
> 
> appears to be due to tramp related logic in man-shell-file-name

I cannot reproduce this with the latest master branch, FWIW.  In any
case, please always report this using "M-x report-emacs-bug", so that
the report goes to the bug tracker and includes the necessary details
about the version of Emacs in which you see this and the system
configuration.

Re: man broken?

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> Invoking man M-x man on any program, eg ls returns error:
>>
>> Invalid function: connection-local-value
>>
>> appears to be due to tramp related logic in man-shell-file-name
>
> I cannot reproduce this with the latest master branch, FWIW.  In any
> case, please always report this using "M-x report-emacs-bug", so that
> the report goes to the bug tracker and includes the necessary details
> about the version of Emacs in which you see this and the system
> configuration.

In this case, it is the master branch, obviously. And I hope my
recommendation will work.

Best regards, Michael.

Re: man broken?

[Philip Kaludercic]

Michael Albinus <michael.albinus@gmx.de> writes:

> "T.V Raman" <raman@google.com> writes:
>
> Hi,
>
>> Invoking man M-x man on any program, eg ls returns error:
>>
>> Invalid function: connection-local-value
>>
>> appears to be due to tramp related logic in man-shell-file-name
>
> connection-local-value is a new macro. So you need to recompile
> man.el. Since it is used somewhere else as well, 'make bootstrap' might
> be the best option.

I've been having another issue, whatever man page I try to open I get a

   /system/bin/sh: No such file or directory

error message, because

  (connection-local-value shell-file-name) => "/system/bin/sh"

I haven't reported it as a bug yet, because I cannot reproduce it in
emacs -Q, and I haven't found any useful information to help debugging
the issue.

Perhaps you have some ideas that could help me prepare a bug report?

> Best regards, Michael.

Re: man broken?

[Emanuel Berg]

Philip Kaludercic wrote:

> I've been having another issue, whatever man page I try to
> open I get a
>
>    /system/bin/sh: No such file or directory

I have seen the same.

GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, cairo version
1.16.0) of 2023-12-17 [commit
4fc2fcb37d62748ef5fbaeddde91447de69bf2a6]

-- 
underground experts united
https://dataswamp.org/~incal

Re: man broken?

[T.V Raman]

same bug, same fix.



Philip Kaludercic writes:
 > Michael Albinus <michael.albinus@gmx.de> writes:
 > 
 > > "T.V Raman" <raman@google.com> writes:
 > >
 > > Hi,
 > >
 > >> Invoking man M-x man on any program, eg ls returns error:
 > >>
 > >> Invalid function: connection-local-value
 > >>
 > >> appears to be due to tramp related logic in man-shell-file-name
 > >
 > > connection-local-value is a new macro. So you need to recompile
 > > man.el. Since it is used somewhere else as well, 'make bootstrap' might
 > > be the best option.
 > 
 > I've been having another issue, whatever man page I try to open I get a
 > 
 >    /system/bin/sh: No such file or directory
 > 
 > error message, because
 > 
 >   (connection-local-value shell-file-name) => "/system/bin/sh"
 > 
 > I haven't reported it as a bug yet, because I cannot reproduce it in
 > emacs -Q, and I haven't found any useful information to help debugging
 > the issue.
 > 
 > Perhaps you have some ideas that could help me prepare a bug report?
 > 
 > > Best regards, Michael.

-- 

Re: man broken?

[Michael Albinus]

Philip Kaludercic <philipk@posteo.net> writes:

Hi Philip,

>>> Invoking man M-x man on any program, eg ls returns error:
>>>
>>> Invalid function: connection-local-value
>>>
>>> appears to be due to tramp related logic in man-shell-file-name
>>
>> connection-local-value is a new macro. So you need to recompile
>> man.el. Since it is used somewhere else as well, 'make bootstrap' might
>> be the best option.
>
> I've been having another issue, whatever man page I try to open I get a
>
>    /system/bin/sh: No such file or directory
>
> error message, because
>
>   (connection-local-value shell-file-name) => "/system/bin/sh"
>
> I haven't reported it as a bug yet, because I cannot reproduce it in
> emacs -Q, and I haven't found any useful information to help debugging
> the issue.
>
> Perhaps you have some ideas that could help me prepare a bug report?

Im don't get it. Have you tried 'make bootstrap' Could you pls tell what
hayou done, starting with "emacs -Q"?

Best regards, Michael.

Re: man broken?

[Philip Kaludercic]

Michael Albinus <michael.albinus@gmx.de> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
> Hi Philip,

Hi,

>>>> Invoking man M-x man on any program, eg ls returns error:
>>>>
>>>> Invalid function: connection-local-value
>>>>
>>>> appears to be due to tramp related logic in man-shell-file-name
>>>
>>> connection-local-value is a new macro. So you need to recompile
>>> man.el. Since it is used somewhere else as well, 'make bootstrap' might
>>> be the best option.
>>
>> I've been having another issue, whatever man page I try to open I get a
>>
>>    /system/bin/sh: No such file or directory
>>
>> error message, because
>>
>>   (connection-local-value shell-file-name) => "/system/bin/sh"
>>
>> I haven't reported it as a bug yet, because I cannot reproduce it in
>> emacs -Q, and I haven't found any useful information to help debugging
>> the issue.
>>
>> Perhaps you have some ideas that could help me prepare a bug report?
>
> Im don't get it. Have you tried 'make bootstrap' Could you pls tell what
> hayou done, starting with "emacs -Q"?

I did try make bootstrap, and it didn't work, but I cannot reproduce the
issue with emacs -Q either, so my configuration is apparently playing a
part in the issue.

> Best regards, Michael.

Re: man broken?

[Emanuel Berg]

Philip Kaludercic wrote:

>> Im don't get it. Have you tried 'make bootstrap' Could you
>> pls tell what hayou done, starting with "emacs -Q"?
>
> I did try make bootstrap, and it didn't work, but I cannot
> reproduce the issue with emacs -Q either, so my
> configuration is apparently playing a part in the issue.

This happened when I upgraded Emacs.

I also cannot reproduce. Now it works even with my
configuration. Both local and remote man pages.

I'm pretty sure this is a mystery.

-- 
underground experts united
https://dataswamp.org/~incal

Re: man broken?

[Visuwesh]

[வியாழன் டிசம்பர் 28, 2023] Michael Albinus wrote:

> Philip Kaludercic <philipk@posteo.net> writes:
>
> Hi Philip,
>
>>>> Invoking man M-x man on any program, eg ls returns error:
>>>>
>>>> Invalid function: connection-local-value
>>>>
>>>> appears to be due to tramp related logic in man-shell-file-name
>>>
>>> connection-local-value is a new macro. So you need to recompile
>>> man.el. Since it is used somewhere else as well, 'make bootstrap' might
>>> be the best option.
>>
>> I've been having another issue, whatever man page I try to open I get a
>>
>>    /system/bin/sh: No such file or directory
>>
>> error message, because
>>
>>   (connection-local-value shell-file-name) => "/system/bin/sh"
>>
>> I haven't reported it as a bug yet, because I cannot reproduce it in
>> emacs -Q, and I haven't found any useful information to help debugging
>> the issue.
>>
>> Perhaps you have some ideas that could help me prepare a bug report?
>
> Im don't get it. Have you tried 'make bootstrap' Could you pls tell what
> hayou done, starting with "emacs -Q"?
>
> Best regards, Michael.

1. emacs -Q
2. M-: (require 'tramp-adb) RET
3. M-x man RET ls RET

This seems to be because connection-local-profile-alist has the adb
configuration which sets shell-file-name to "/system/bin/sh".

Re: man broken?

[Michael Albinus]

Visuwesh <visuweshm@gmail.com> writes:

Hi,

> 1. emacs -Q
> 2. M-: (require 'tramp-adb) RET
> 3. M-x man RET ls RET
>
> This seems to be because connection-local-profile-alist has the adb
> configuration which sets shell-file-name to "/system/bin/sh".

Thanks for the recipe. I'll work on it when my health condition is going
better, hopefully next days.

Best regrds, Michael.

Re: man broken?

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Michael Albinus <michael.albinus@gmx.de> writes:

> Visuwesh <visuweshm@gmail.com> writes:
>
> Hi,
>
>> 1. emacs -Q
>> 2. M-: (require 'tramp-adb) RET
>> 3. M-x man RET ls RET
>>
>> This seems to be because connection-local-profile-alist has the adb
>> configuration which sets shell-file-name to "/system/bin/sh".
>
> Thanks for the recipe. I'll work on it when my health condition is going
> better, hopefully next days.

Could it be that this is the issue:


[-- Attachment #2: Type: text/plain, Size: 796 bytes --]

diff --git a/lisp/files-x.el b/lisp/files-x.el
index 41d9cd3bab8..1911afe43e0 100644
--- a/lisp/files-x.el
+++ b/lisp/files-x.el
@@ -1,6 +1,6 @@
 ;;; files-x.el --- extended file handling commands  -*- lexical-binding: t; -*-
 
-;; Copyright (C) 2009-2023 Free Software Foundation, Inc.
+;; Copyright (C) 2009-2024 Free Software Foundation, Inc.
 
 ;; Author: Juri Linkov <juri@jurta.org>
 ;; Maintainer: emacs-devel@gnu.org
@@ -704,7 +704,7 @@ connection-local-get-profiles
         profiles)
     (dolist (crit-alist connection-local-criteria-alist)
       (let ((crit criteria)
-            (match t))
+            (match nil))
         (while (and crit match)
           (when (plist-member (car crit-alist) (car crit))
             (setq match (equal (plist-get (car crit-alist) (car crit))

[-- Attachment #3: Type: text/plain, Size: 184 bytes --]


I am not quite sure what is going on in the function, but the invariant
is that match is always non-nil after the loop is done, which seems
suspicious to me.

> Best regrds, Michael.

Re: man broken?

[Philip Kaludercic]

Philip Kaludercic <philipk@posteo.net> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Visuwesh <visuweshm@gmail.com> writes:
>>
>> Hi,
>>
>>> 1. emacs -Q
>>> 2. M-: (require 'tramp-adb) RET
>>> 3. M-x man RET ls RET
>>>
>>> This seems to be because connection-local-profile-alist has the adb
>>> configuration which sets shell-file-name to "/system/bin/sh".
>>
>> Thanks for the recipe. I'll work on it when my health condition is going
>> better, hopefully next days.
>
> Could it be that this is the issue:
>
> diff --git a/lisp/files-x.el b/lisp/files-x.el
> index 41d9cd3bab8..1911afe43e0 100644
> --- a/lisp/files-x.el
> +++ b/lisp/files-x.el
> @@ -1,6 +1,6 @@
>  ;;; files-x.el --- extended file handling commands  -*- lexical-binding: t; -*-
>  
> -;; Copyright (C) 2009-2023 Free Software Foundation, Inc.
> +;; Copyright (C) 2009-2024 Free Software Foundation, Inc.
>  
>  ;; Author: Juri Linkov <juri@jurta.org>
>  ;; Maintainer: emacs-devel@gnu.org
> @@ -704,7 +704,7 @@ connection-local-get-profiles
>          profiles)
>      (dolist (crit-alist connection-local-criteria-alist)
>        (let ((crit criteria)
> -            (match t))
> +            (match nil))
>          (while (and crit match)
>            (when (plist-member (car crit-alist) (car crit))
>              (setq match (equal (plist-get (car crit-alist) (car crit))
>
>
> I am not quite sure what is going on in the function, but the invariant
> is that match is always non-nil after the loop is done, which seems
> suspicious to me.

Never mind the last sentence, match can be nil if `equal' returns nil at
some point, but that doesn't happen locally since `criteria' is nil.

>> Best regrds, Michael.

Re: man broken?

[Michael Albinus]

Philip Kaludercic <philipk@posteo.net> writes:

Hi,

>>>> 1. emacs -Q
>>>> 2. M-: (require 'tramp-adb) RET
>>>> 3. M-x man RET ls RET
>>
>> Could it be that this is the issue:
>>
>> diff --git a/lisp/files-x.el b/lisp/files-x.el
>> index 41d9cd3bab8..1911afe43e0 100644
>> --- a/lisp/files-x.el
>> +++ b/lisp/files-x.el
>> @@ -1,6 +1,6 @@
>>  ;;; files-x.el --- extended file handling commands  -*- lexical-binding: t; -*-
>>
>> -;; Copyright (C) 2009-2023 Free Software Foundation, Inc.
>> +;; Copyright (C) 2009-2024 Free Software Foundation, Inc.
>>
>>  ;; Author: Juri Linkov <juri@jurta.org>
>>  ;; Maintainer: emacs-devel@gnu.org
>> @@ -704,7 +704,7 @@ connection-local-get-profiles
>>          profiles)
>>      (dolist (crit-alist connection-local-criteria-alist)
>>        (let ((crit criteria)
>> -            (match t))
>> +            (match nil))
>>          (while (and crit match)
>>            (when (plist-member (car crit-alist) (car crit))
>>              (setq match (equal (plist-get (car crit-alist) (car crit))
>>
>>
>> I am not quite sure what is going on in the function, but the invariant
>> is that match is always non-nil after the loop is done, which seems
>> suspicious to me.
>
> Never mind the last sentence, match can be nil if `equal' returns nil at
> some point, but that doesn't happen locally since `criteria' is nil.

Finally, I found the culprit. connection-local-value didn't handle a
local default directory properly.

Fix pushed to master. Again, since this is a macro, you need to
recompile at least files-x.el and man.el (in this order). Or you run
'make bootstrap'.

Best regrds, Michael.

Re: man broken?

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> Finally, I found the culprit. connection-local-value didn't handle a
> local default directory properly.
>
> Fix pushed to master. Again, since this is a macro, you need to
> recompile at least files-x.el and man.el (in this order). Or you run
> 'make bootstrap'.
>
> Best regrds, Michael.

Should the body of this macro be extracted into a separate function, so
that future changes affecting it won't require a recompilation of all
files where it is invoked?  I've seen two breaking changes with this
macro involved in some capacity over the past 30 days, which is abnormal
for such a widely used macro.

Re: man broken?

[Michael Albinus]

Po Lu <luangruo@yahoo.com> writes:

Hi,

> Should the body of this macro be extracted into a separate function, so
> that future changes affecting it won't require a recompilation of all
> files where it is invoked?  I've seen two breaking changes with this
> macro involved in some capacity over the past 30 days, which is abnormal
> for such a widely used macro.

This macro isn't widely used, just 5 files outside files-x.el:.

--8<---------------cut here---------------start------------->8---
# grep '(connection-local-value' lisp/*.el lisp/**/*.el
lisp/dired.el:          (setq switches (connection-local-value dired-listing-switches)))
lisp/dired.el:              (or switches (connection-local-value dired-listing-switches)))
lisp/dired-x.el:   dirname (or switches (connection-local-value dired-listing-switches)))
lisp/files.el:	      (let ((switches (connection-local-value dired-listing-switches)))
lisp/files.el:	   (concat (connection-local-value dired-listing-switches) " -t")))
lisp/files-x.el:  (connection-local-value path-separator))
lisp/files-x.el:  (connection-local-value null-device))
lisp/man.el:      (connection-local-value shell-file-name)
lisp/net/ange-ftp.el:				    (connection-local-value
--8<---------------cut here---------------end--------------->8---

The macro is newly added to Emacs, so it isn't abnormal that the usage
shows potential problems. The breakage came due to a thinko of mine, I
don't expect further changes to the macro. (I know, famous last words ...)

Best regards, Michael.

Re: man broken?

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> This macro isn't widely used, just 5 files outside files-x.el:.
>
> # grep '(connection-local-value' lisp/*.el lisp/**/*.el
> lisp/dired.el:          (setq switches (connection-local-value dired-listing-switches)))
> lisp/dired.el:              (or switches (connection-local-value dired-listing-switches)))
> lisp/dired-x.el:   dirname (or switches (connection-local-value dired-listing-switches)))
> lisp/files.el:	      (let ((switches (connection-local-value dired-listing-switches)))
> lisp/files.el:	   (concat (connection-local-value dired-listing-switches) " -t")))
> lisp/files-x.el:  (connection-local-value path-separator))
> lisp/files-x.el:  (connection-local-value null-device))
> lisp/man.el:      (connection-local-value shell-file-name)
> lisp/net/ange-ftp.el:				    (connection-local-value
>
> The macro is newly added to Emacs, so it isn't abnormal that the usage
> shows potential problems. The breakage came due to a thinko of mine, I
> don't expect further changes to the macro. (I know, famous last words ...)
>
> Best regards, Michael.

I see, thanks for clarifying.

Re: man broken?

[Emanuel Berg]

Michael Albinus wrote:

> Finally, I found the culprit. connection-local-value didn't
> handle a local default directory properly.

Good work \o/

-- 
underground experts united
https://dataswamp.org/~incal