all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 4808c63d43f: Add Tramp method "apptainer"
Date: Tue, 07 May 2024 19:47:59 +0200	[thread overview]
Message-ID: <878r0l4ipc.fsf@gmx.de> (raw)
In-Reply-To: <87h6f94owd.fsf@gmx.de> (Michael Albinus's message of "Tue, 07 May 2024 17:34:10 +0200")

Michael Albinus <michael.albinus@gmx.de> writes:

Hi,

>> With this change, Tramp ceases to be autoloaded on Android, and when
>> manually required, signals an error as follows:
>
> Oops. Does this help?
>
> diff --git a/lisp/tramp-androidsu.el b/lisp/tramp-androidsu.el
> index 3dcee8e2..09dcd4d7 100644
> --- a/lisp/tramp-androidsu.el
> +++ b/lisp/tramp-androidsu.el
> @@ -94,8 +94,9 @@ may edit files belonging to any and all applications."
>                 `(,tramp-androidsu-method nil ,tramp-root-id-string)))
>
>  ;;;###tramp-autoload
> -(when (eq system-type 'android)
> -  (tramp-enable-androidsu-method))
> +(tramp--with-startup
> + (when (eq system-type 'android)
> +   (tramp-enable-androidsu-method)))
>
>  (defvar android-use-exec-loader) ; androidfns.c.

I could reproduce the problem locally. The proposed fix cures it, so I
have pushed it to master.

Best regards, Michael.



  reply	other threads:[~2024-05-07 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171506857890.22154.1102080900890818821@vcs2.savannah.gnu.org>
     [not found] ` <20240507075619.C1E19C2BC75@vcs2.savannah.gnu.org>
2024-05-07 14:59   ` master 4808c63d43f: Add Tramp method "apptainer" Po Lu
2024-05-07 15:34     ` Michael Albinus
2024-05-07 17:47       ` Michael Albinus [this message]
2024-05-07 23:49         ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r0l4ipc.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.