[BUG] org 9.7 drag image down't make directory on Windows system [9.7.3 (release_9.7.3 @ f:/App/emacs/share/emacs/30.0.50/lisp/org/)]

[BUG] org 9.7 drag image down't make directory on Windows system [9.7.3 (release_9.7.3 @ f:/App/emacs/share/emacs/30.0.50/lisp/org/)]

[ISouthRain]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Thanks you work!!

Example:
(setq org-yank-image-save-method "./myattach/")
(setq org-yank-dnd-method 'attach)
Filename: c:/users/abc/test.org
No have dir: c:/users/abc/myattach/ 
drag image down't work, no auto make directory c:/users/abc/myattach/
Message out: Copying file: Operation not permitted, .............. and more

I Have dir: c:/users/abc/myattach/
drag image is work

Because I saw the function: org--image-yank-media-handler
    (when (and (not (eq org-yank-image-save-method 'attach))
               (not (file-directory-p org-yank-image-save-method)))
      (make-directory org-yank-image-save-method t))

I don't understand why the path is not created automatically??

Emacs  : GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32)
Package: Org mode version 9.7.3 (release_9.7.3 @ f:/App/emacs/share/emacs/30.0.50/lisp/org/)

current state:
==============
(setq
 org-agenda-skip-scheduled-if-done t
 org-latex-pdf-process '("xelatex -interaction nonstopmode -output-directory %o %f"
                         "xelatex -interaction nonstopmode -output-directory %o %f"
                         "xelatex -interaction nonstopmode -output-directory %o %f")
 org-yank-image-file-name-function 'org-yank-image-autogen-filename
 org-export-headline-levels 6
 org-persist-before-write-hook '(org-element--cache-persist-before-write)
 org-html-format-headline-function 'org-html-format-headline-default-function
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-pretty-entities t
 org-src-fontify-natively 1
 org-log-into-drawer t
 org-directory "F:\\MyFile\\Org"
 org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
 org-babel-tangle-lang-exts '(("latex" . "tex") ("python" . "py") ("D" . "d") ("C++" . "cpp")
                              ("emacs-lisp" . "el") ("elisp" . "el"))
 org-roam-db-node-include-function #[nil ((not (member "ATTACH" (org-get-tags)))) nil]
 org-roam-log-setup-hook '(org-roam--register-completion-functions-h)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-persist-after-read-hook '(org-element--cache-persist-after-read)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-src-tab-acts-natively 1
 org-agenda-finalize-hook '(org-agenda-to-appt)
 org-roam-preview-function 'org-roam-preview-default-function
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-mode-hook '(#[0 "\301\211\207" [imenu-create-index-function org-imenu-get-tree] 2]
                 page-break-lines-mode flyspell-mode
                 #[nil ((if (display-graphic-p) (org-dynamic-bullets-mode))) nil]
                 #[nil
                   ((set (make-local-variable 'org-yank-image-save-method)
                     (format "./attach/%s" (file-name-nondirectory buffer-file-name)))
                    )
                   nil]
                 org-indent-mode
                 (lambda nil (add-hook 'before-save-hook #'my/org-yank-path-replace nil 'local))
                 whitespace-mode org-auto-tangle-mode
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-fold-show-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-hide-emphasis-markers t
 org-hide-leading-stars t
 org-capture-templates '(("z" "账单")
                         ("W" "Bookmarks" plain
                          (file+olp freedom-org-bookmarks-file "Bookmark" "Bookmarks") "- %a\n"
                          :prepend 1 :immediate-finish t :jump-to-captured t :kill-buffer t)
                         ("w" "网页收集" plain
                          (file+function freedom-org-webcollection-file org-capture-goto-link)
                          "%U\n%i\n" :empty-lines 1 :immediate-finish t :prepend 1 :kill-buffer t
                          :jump-to-captured t)
                         ("t" "Todo" plain (file+function freedom-org-agenda-file find-month-tree)
                          "*** TODO %^{想做什么？}\n%^{详细说明 }\n  :时间: %^T\n  %?\n%i\n"
                          :kill-buffer t :immediate-finish t)
                         ("T" "Work-Todo" plain
                          (file+function freedom-org-work-file find-month-tree)
                          "*** TODO %^{想做什么？}\n%^{详细说明 }\n  :时间: %T\n" :kill-buffer t
                          :immediate-finish t)
                         ("j" "Journal" entry (file+datetree freedom-org-journal-file)
                          "* %<%H:%M> %^{记些什么}%?\n  %i\n" :kill-buffer t :immediate-finish t
                          :prepend 1)
                         ("J" "工作日志" entry (file+datetree freedom-org-work-journal-file)
                          "* %<%H:%M> %^{记些什么}%?\n  %i" :kill-buffer t :immediate-finish t
                          :prepend 1)
                         ("a" "日程安排" plain
                          (file+function freedom-org-agenda-file find-month-tree)
                          "*** [#%^{优先级}] %^{安排}\n%^{详细说明 }\n SCHEDULED: %^T\n  :地点: %^{地点}\n" :kill-buffer t :immediate-finish t)
                         ("n" "笔记" entry (file+headline freedom-org-note-file "Note")
                          "* %^{你想要记录的笔记}\n :时间: %T\n %?")
                         ("zd" "账单" plain (file+function freedom-org-bill-file find-month-tree)
                          " | %<%Y-%m-%d %a %H:%M:%S> | %^{prompt|Breakfast|Lunch|Dinner|Shopping|Night Snack|Fruit|Transportation|Other} | %^{支付金额} | %^{收入金额} |" :kill-buffer t :immediate-finish t)
                         ("e" "英语单词" entry (file+datetree freedom-org-english-word-file)
                          "*  %^{英语单词} ----> %^{中文翻译}\n" :kill-buffer t :immediate-finish
                          t)
                         )
 org-confirm-shell-link-function 'yes-or-no-p
 org-dynamic-bullets-mode-hook '(org-visual-indent-mode)
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-occur-hook '(org-first-headline-recenter)
 org-ellipsis " ⭍"
 org-edit-src-content-indentation 0
 org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
 org-roam-node-annotation-function 'org-roam-node-read--annotation
 org-emphasis-alist '(("*" freedom-org-emphasis-bold) ("/" freedom-org-emphasis-italic)
                      ("_" freedom-org-emphasis-underline) ("=" org-verbatim verbatim)
                      ("~" org-code verbatim)
                      ("+" (freedom-org-emphasis-strike-through :strike-through t)))
 org-confirm-babel-evaluate nil
 org-ascii-format-drawer-function #[771 "\207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
 org-roam-directory "f:/MyFile/Org"
 org-link-from-user-regexp "\\<adminuirs@ADMINUIRS-PC\\>"
 org-roam-db-autosync-mode t
 org-roam-indirect-buffer-hook '(org-roam--register-completion-functions-h)
 org-priority-faces '((65 . error) (66 . warning) (67 . success))
 org-bibtex-headline-format-function 'org-bibtex-headline-format-default
 org-capture-prepare-finalize-hook '(org-roam-capture--install-finalize-h)
 org-link-parameters '(("helpful" :store helpful--org-link-store)
                       ("roam" :follow org-roam-link-follow-link)
                       ("attachment" :follow org-attach-follow :complete org-attach-complete-link)
                       ("id" :follow org-roam-id-open :store org-id-store-link-maybe)
                       ("eww" :follow org-eww-open :store org-eww-store-link)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link :export
                        org-irc-export)
                       ("info" :follow org-info-open :export org-info-export :store
                        org-info-store-link :insert-description org-info-description-as-command)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store
                        org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
                        org-bbdb-complete-link :store org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link)
                       ("doi" :follow org-link-doi-open :export org-link-doi-export)
                       ("elfeed" :follow elfeed-link-open :store elfeed-link-store-link)
                       ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
                       ("news" :follow
                        #[514 "\301\300\302Q\"\207" ["news" browse-url ":"] 6
                          "\n\n(fn URL ARG)"]
                        )
                       ("mailto" :follow
                        #[514 "\301\300\302Q\"\207" ["mailto" browse-url ":"] 6
                          "\n\n(fn URL ARG)"]
                        )
                       ("https" :follow
                        #[514 "\301\300\302Q\"\207" ["https" browse-url ":"] 6
                          "\n\n(fn URL ARG)"]
                        )
                       ("http" :follow
                        #[514 "\301\300\302Q\"\207" ["http" browse-url ":"] 6
                          "\n\n(fn URL ARG)"]
                        )
                       ("ftp" :follow
                        #[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"] 6
                          "\n\n(fn URL ARG)"]
                        )
                       ("help" :follow helpful--org-link-follow :store org-link--store-help)
                       ("file" :complete org-link-complete-file)
                       ("elisp" :follow org-link--open-elisp))
 org-todo-keyword-faces '(("TODO" :foreground "red" :weight bold)
                          ("DOING" :foreground "blue" :weight bold)
                          ("DONE" :foreground "forest green" :weight bold)
                          ("WAITING" :foreground "orange" :weight bold)
                          ("HANGUP" :foreground "magenta" :weight bold)
                          ("CANCEL" :foreground "forest green" :weight bold))
 org-log-buffer-setup-hook '(org-roam-log--setup)
 org-roam-completion-everywhere t
 org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-roam-node-display-template #("${type:15} ${title:*} ${tags:10}" 22 32 (face org-tag))
 org-imenu-depth 6
 org-capture-bookmark nil
 org-todo-keywords '((sequence "TODO(t)" "DOING(i)" "HANGUP(h)" "WAITING" "|" "DONE(d)"
                      "CANCEL(c)")
                     )
 org-yank-dnd-method 'attach
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-sort-function 'string-collate-lessp
 org--warnings nil
 org-startup-folded t
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-current-time-string "⏰ ┈┈┈┈┈┈┈┈┈┈┈ now"
 org-roam-capture-new-node-hook '(org-roam-capture--insert-captured-ref-h)
 org-agenda-prefix-format '((agenda . "%i %-12:c%?-12t%b% s") (todo . " %i %-12:c")
                            (tags . " %i %-12:c") (search . " %i %-12:c"))
 org-roam-db-gc-threshold 2305843009213693951
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-image-actual-width '(500)
 org-link-shell-confirm-function 'yes-or-no-p
 org-fold-core-isearch-open-function 'org-fold-core--isearch-reveal
 org-cycle-include-plain-lists 'integrate
 org-agenda-time-grid '((weekly today require-timed) (800 1000 1200 1400 1600 1800 2000) "---"
                        "┈┈┈┈┈┈┈┈┈┈┈┈┈")
 org-roam-capture-preface-hook '(org-roam-capture--try-capture-to-ref-h)
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-roam-find-file-hook '(org-roam-buffer--setup-redisplay-h
                           org-roam--register-completion-functions-h
                           org-roam--replace-roam-links-on-save-h
                           org-roam-db-autosync--setup-update-on-save-h)
 org-protocol-protocol-alist '(("capture-html" :protocol "capture-html" :function
                                org-protocol-capture-html--with-pandoc :kill-client t)
                               )
 org-babel-load-languages '((C \.t) (emacs-lisp \.t) (python . t) (latex . t))
 org-capture-after-finalize-hook '(org-agenda-to-appt)
 org-startup-with-inline-images t
 org-roam-ref-annotation-function 'org-roam-ref-read--annotation
 org-agenda-loop-over-headlines-in-active-region nil
 org-agenda-files '("F:\\MyFile\\Org\\Work.org")
 org-link-elisp-confirm-function 'yes-or-no-p
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
                  org-cycle-optimize-window-after-visibility-change
                  org-cycle-display-inline-images)
 org-persist-before-read-hook '(org-element--cache-persist-before-read)
 org-use-sub-superscripts nil
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-agenda-format-date #[(date) ((concat "\n" (make-string (window-width) 9472) (org-agenda-format-date-aligned date))) nil]
 )

Re: [BUG] org 9.7 drag image down't make directory on Windows system [9.7.3 (release_9.7.3 @ f:/App/emacs/share/emacs/30.0.50/lisp/org/)]

[Ihor Radchenko]

ISouthRain <isouthrain@qq.com> writes:

> Thanks you work!!
>
> Example:
> (setq org-yank-image-save-method "./myattach/")
> (setq org-yank-dnd-method 'attach)
> Filename: c:/users/abc/test.org
> No have dir: c:/users/abc/myattach/ 
> drag image down't work, no auto make directory c:/users/abc/myattach/
> Message out: Copying file: Operation not permitted, .............. and more
>
> I Have dir: c:/users/abc/myattach/
> drag image is work
>
> Because I saw the function: org--image-yank-media-handler
>     (when (and (not (eq org-yank-image-save-method 'attach))
>                (not (file-directory-p org-yank-image-save-method)))
>       (make-directory org-yank-image-save-method t))
>
> I don't understand why the path is not created automatically??

A simple omission.
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d7b5c19da

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>