From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package org-transclusion-http Date: Sat, 15 Jun 2024 19:15:08 +0000 Message-ID: <878qz6kog3.fsf@posteo.net> References: <87sezvt2rc.fsf@ushin.org> <87tti2u8jx.fsf@ushin.org> <87o782mje9.fsf@posteo.net> <87ikyaniwl.fsf@ushin.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List , me@nobiot.com To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 21:15:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIYsX-0008O6-8a for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 21:15:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIYrs-0001UP-21; Sat, 15 Jun 2024 15:15:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIYrq-0001U1-N4 for emacs-devel@gnu.org; Sat, 15 Jun 2024 15:15:15 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIYro-00023Q-Ha for emacs-devel@gnu.org; Sat, 15 Jun 2024 15:15:14 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5E4F4240027 for ; Sat, 15 Jun 2024 21:15:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718478910; bh=ZbnwJU8ycvTW0Xhad4kYZZy+lIiiAMhLhdkF5RuSF1o=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=WGhuoCwOtf0SU/dIgNZHLqNGRT8Cmrct5z+nRkhvgwJ7ofw3zXWi+B3kdHn2nTLwt Yn6QZM5bpxG2MaZICN/tCQI8QH9gmneQFWnZMXfOpxBbMc/4xf5vnC36UNi8b4SBFn rnC663pTt/Q+SYU5eCKhGOQjlY8S6ErbJhFxM7590R9jb39BA7JB7t/vSUO2aFyqm0 hNvq1kqQ+Z0DW00d8L0bdHnswJrWHGXzmDPIKXO6G38VJY2/5by4sGh/nFaqp25qz7 kmUIRJQPaAYg4npkNjTaMFgWEhBmKwJ7+6165kqlyJd+Ky+xQ//BXFXT2yDnZBV8KH btrW2msxHwlow== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W1m7J5THDz9rxD; Sat, 15 Jun 2024 21:15:08 +0200 (CEST) In-Reply-To: <87ikyaniwl.fsf@ushin.org> (Joseph Turner's message of "Sat, 15 Jun 2024 11:46:34 -0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320169 Archived-At: Joseph Turner writes: > Thank you for the review! > > Philip Kaludercic writes: > >> There is really not much I can comment on, since it is mainly API I am >> not familiar with. One note is that the package description doesn't >> make much sense to me, since I don't know what "transcluding" means. >> Also, not everyone knows that "plz" is a HTTP library (the name remains >> elusive), so a brief comment reminding the reader of that would be >> appropriate. > > I've updated the package description. This is the commit you are referring to? diff --git a/org-transclusion-http.el b/org-transclusion-http.el index 5f240ad31c..293e705615 100644 --- a/org-transclusion-http.el +++ b/org-transclusion-http.el @@ -25,8 +25,8 @@ ;;; Commentary: -;; This file contains functionality related to transcluding content over HTTP -;; using plz.el. Features include: +;; This file extends the `org-transclusion' package to allow for transcluding +;; content over HTTP. Features include: ;; ;; - Transclude plain text ;; + Transclude only Org headings matching search options I don't know if this is just me, but I am not familiar with what "transcluding" is supposed to mean. I get that it has something to do with networking, and if I had to guess you are fetching remote files and including them while exporting, but a package description shouldn't leave the reader with the impression that they have to guess what is going on. >> Another note is that if you already have a .dir-locals.el file, you >> could add a few more variables that might vary from system to system. >> In Compat, the .dir-locals.el lists: >> >> --8<---------------cut here---------------start------------->8--- >> ((nil >> (fill-column . 72) >> (sentence-end-double-space . t) >> (show-trailing-whitespace . t) >> (indent-tabs-mode . nil))) >> --8<---------------cut here---------------end--------------->8--- > > I've added all these variables except show-trailing-whitespace, as I > don't personally use it. ws-butler takes care of whitespace without > adding visuals. No problem, I like `show-trailing-whitespace' because I know that all contributors will see that there is a whitespacing issue, but I admit that my recommendations might be opinionated. >> Also, I think an .elpaigore file would be appropriate to have in the >> repo, at least to avoid bundling the build-time dependencies. > > I've added .elpaignore and pushed a new release v0.3. > > Thank you!!! > > Joseph > > -- Philip Kaludercic on peregrine