From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Date: Wed, 19 Jun 2024 19:18:46 +0800 Message-ID: <878qz141ux.fsf@yahoo.com> References: <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org> <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9924"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 13:20:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJtMA-0002Ir-Es for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 13:20:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtLM-0003UE-Lp; Wed, 19 Jun 2024 07:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtL9-0003RJ-Ug for emacs-devel@gnu.org; Wed, 19 Jun 2024 07:19:02 -0400 Original-Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJtL7-0008F0-Vk for emacs-devel@gnu.org; Wed, 19 Jun 2024 07:18:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718795935; bh=Gm50ZPx4n4K85571LLL2xe80uBYKVojtTKTwZ0Eqrjg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qlLyqhOeXmM2VD7/FwVrYNff6ICkC27UVx0F0TOjx6BCznQxDJA4qhkd23GGOnHq1Itfnxn5NjnHZzIma0Rvj2+bIRjLkahu4oJr9ZiNihtIYp8CIJMTNfMT8DHbuqc3hGX9C7hrfbJZfDxozEg7LYQvYMlD1YCRvs035bMIvH3d8sgJPxoW/UJ72sovLAXWi+igacaBZV66Gn+u/a7HM30ZghAHpYabiADgjkSA9+l144RPoCYMRTGxnHohYofeM7aiopBvJI+1AXO9KFdwayLlKf5H5nDrcw+vK1g6AYBJtf5WwPGOcyY//Py4SY2Q9e/Qwnm0evNH9nJm2fdH+g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718795935; bh=2h6hZE8oHiy6wcV/r9S4lGEZOZRve1XR4Uyn0U21FOV=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=boNH0UePvYibWjSkVNQ2mar48B8PK2pwra8PGEALzKRuVxeVdIYJaLcIGiTaWsmkurH5/wu7pZoIQRfpdCxzIp9zOIe3O08qb3ZheE4M9lT8QptTjF9ufI5WqUP07cRQGYSRc0Bi6sUctWqU4SOY4zZTaB1rdiZoQjVch5JVhcbQ6CcFOskpNY1W+ANJZxkiGb17Ts9xilJdj0HxzYh8IelhSOGj+wXY93lyuqDpiV6maiXf5Jed42sbA5RNnAfOW/+EJeQQsA+VhZZKNrKRpDWeiQIZ/j0YKk4JmNeWL2369AqL/un+tFvftLykroc5Bw3f1OOOMxQSTlNhuzggyw== X-YMail-OSG: c4mjgsAVM1m4D4bdmJ8zeZN1ELFFQh1KETvhaTDfJ79H3IJ7gclCE7idLqV7_bD HAo1yesIau8YbplzNUJkf3XK3f8aer1XmOHK7Am7_wy7BccqR1Mq.tsH.ekhbiQrJ_NJhXfOYa0a VQ4ppm5c0nZ16PtUBZT3PsrVAlqlLawWNd8vDcXz5M9ZlvOSRpDfnJ8QD3fjK6giXpk5LLqZsHW3 0UPOi9KgtmVETEM5KnWlXuYPUfQh6mAbfdC_jgtg__LNBLBHbbS8M9ZAoUE.MxGmd3VrRxSfpbkf zzFM3N1nHMHXB76kthKHdwSBNZyJEHTPA1bDAyHEuPIDYwOBfk79BXOCd0uXtI4ChTpCqaB6GXMa UMn6ItVh6qdyieG9c1JWHxACdDMcWagAdYG4Jr0H3DvE.t8D4cLjxxeEfl9Ys_3mpouZubjKsD5A 3aqiLWE8TNIJByx1pXdDdvnxEYGR.DnShQyC8d3vAlO5V7ebmRB7iFV4ooq4EXwJt636FzF.jqaT oVvkHQkipb46_vbMFjYs1aS1A.WLemeHLrWndD8eFxYLHkZIKQIIm.Ke1uk1jasI.hW5Vq6cXR_b kNxDIZSsanTbLzi6nrpn.PWRAcXIg_8.syaqxhBTH8oMRr7Sywm0NubPucWYGozznAYZsvRjBStc k98wuhx20q5HCTmuOCcPpC2nJTrA4owUJ8Oeam7cc0Ia_P.yVXzxZ322EsPBW6ELQK.NqOvSioYI Aex0eJuDmu3ulYQbdt1YnlhSg4VSIIbObjZQXTgvSQcCsKV1tw11hff5DHfA7zzpql47JKE7Ju0P 3X4li7lHth66QExAKHp143oziadqvCslvMU56syJbe X-Sonic-MF: X-Sonic-ID: d51afaf3-75d8-430f-9483-7b14a6817acc Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Wed, 19 Jun 2024 11:18:55 +0000 Original-Received: by hermes--production-sg3-7b469d9f6-2w46x (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 82d086a74fd2e021492b523eb1d6b7b0; Wed, 19 Jun 2024 11:18:51 +0000 (UTC) In-Reply-To: (Arash Esbati's message of "Wed, 19 Jun 2024 12:36:29 +0200") X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.148; envelope-from=luangruo@yahoo.com; helo=sonic316-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320284 Archived-At: Arash Esbati writes: > Po Lu via Mailing list for Emacs changes writes: > >> branch: master >> commit 6aa5068ac71cb1b8e46c299138f99fea44319146 >> Author: Po Lu >> Commit: Po Lu >> >> Improve treatment of touch screen input by rmc and its callers >>=20=20=20=20=20 >> * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers): >> Run touch screen event translation on touch screen events >> received, and respond to pinch, tap and scrolling gestures. >>=20=20=20=20=20 >> * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in >> the details window. >>=20=20=20=20=20 >> * lisp/touch-screen.el (touch-screen-translate-touch): Autoload. >> --- >> lisp/emacs-lisp/rmc.el | 106 +++++++++++++++++++++++++++++++++---------= ------- >> lisp/net/nsm.el | 11 ++++- >> lisp/touch-screen.el | 1 + >> 3 files changed, 81 insertions(+), 37 deletions(-) >> >> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el >> index 378687c0326..883f8bf187f 100644 >> --- a/lisp/emacs-lisp/rmc.el >> +++ b/lisp/emacs-lisp/rmc.el >>[...] >> + (cond >> + ((null command)) ; Read another event. >> + ((memq (car-safe command) '(mouse-1 mouse-2)) >> + ;; Display the on-screen keyboard if a tap should be >> + ;; registered. >> + (frame-toggle-on-screen-keyboard (selected-frame) >> + nil)) >> + ;; Respond to scroll and pinch events as if RMC were >> + ;; not in progress. >> + ((eq (car-safe command) 'touchscreen-scroll) >> + (funcall #'touch-screen-scroll command)) >> + ((eq (car-safe command) 'touchscreen-pinch) >> + (funcall #'touch-screen-pinch command)) > > I think this part now generates: > > In end of data: > rmc.el:245:32: Warning: the function =E2=80=98touch-screen-pinch=E2=80=99= is not known to be defined. > rmc.el:243:32: Warning: the function =E2=80=98touch-screen-scroll=E2=80= =99 is not known to be defined. > > This on macOS with Emacs from master (e6f4370c). OK, what if you replace in: >> + ;; Respond to scroll and pinch events as if RMC were >> + ;; not in progress. >> + ((eq (car-safe command) 'touchscreen-scroll) >> + (funcall #'touch-screen-scroll command)) >> + ((eq (car-safe command) 'touchscreen-pinch) >> + (funcall #'touch-screen-pinch command)) #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll and 'touch-screen-pinch?