From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 12:06:40 +0200 Message-ID: <878qyh79ov.fsf@gmx.net> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28848"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jpw@gnu.org, juri@linkov.net, Eshel Yaron , basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 12:08:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPJNu-0007Cd-HS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 12:08:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPJNh-0003GB-Ma; Thu, 04 Jul 2024 06:08:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPJNg-0003Fk-8D for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 06:08:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPJNf-0007Cy-Vy for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 06:08:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPJNi-0001Jj-4I for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 06:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 10:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.17200876224997 (code B ref 71927); Thu, 04 Jul 2024 10:08:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 10:07:02 +0000 Original-Received: from localhost ([127.0.0.1]:41542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPJMk-0001IV-5o for submit@debbugs.gnu.org; Thu, 04 Jul 2024 06:07:02 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:39349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPJMg-0001Hz-V0 for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 06:07:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1720087604; x=1720692404; i=stephen.berman@gmx.net; bh=PvR4dcdyjB7OXf6rMO8PLZzOhKhlekfXB740+A4T6no=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=p9X5k/WBrMxFDXteAgUjCXFUQJrk+o5dh3Ur2FGJmgKplqcEXlknCJNuHjyK+Oqn mHyn8eNba0g1PyNu1ncsfBtKDYQwiuKdEIwA1wT+jSf8JahhfuwL+a1bGNHsf3dsO h9Qu5kYOeN/tHHbNZl4F/iGbNkyLXIb9X38v6U7+aWrO0tX0kdu1AIROSvp9Ha5eQ 3DJjeMKNlyW72VacmT7ukjV8kVwvKyWGhFsx5yHQcWyjJtvEXLMpcdRy/gDyayi7g NzTW9WCUq9NnHkLNWadI+F/yALJqwHEvqG3v39efMYTMcrAsp21bcY+XNMNZIdZnU dm9DaW4IhhR8GrMChQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([88.130.48.103]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3siA-1sGXy81LdY-00y9gA; Thu, 04 Jul 2024 12:06:44 +0200 In-Reply-To: <86y16h8olf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 12:59:24 +0300") X-Provags-ID: V03:K1:bZTNhRs3n3HwnKDj879LUKfCgt/PQuSrU5tnvSYyOXs77hFS7tL kap6t0mTk0ilZqVChruVVbSYHHCgOZG+Rf6H7Ywu2AymRbIZtPxh7aDfrzK5yLzG2tFAzEU zCWExQ7bGqY3ahtgdoezOees2oJc+oPy1tcjCm9zwcHdxp24Em9Tq4qWh0fL/EZeF26PEZP Dyegxshc4gA+OP6Sw25PQ== UI-OutboundReport: notjunk:1;M01:P0:RGQ+pEeGww4=;XrbT78PSneST7RUR16Qi3waXYL6 bD67S94DGtEa2N+mA88l3pEUVJ9Vj8SD6b1WO/Vk80Aq14Cdaek3U01vffV7Kn1bD/aa+dg9Q XhNfib9U1t69yGyoC3gL03e6oradRXY0ATBkm8lRMjd0C8ced3qDdJ5rcnQkHG/VzyRQjp0Gx DGhZ1xOAQJvS0EO5uLeE+4sKvq4NCthprucHII5VnMfZ1Q08cWyJp9yntVFh2BAata3eryEc5 bWOXAu4whVXHcKfu0nk6nN0rfTOCycxwpOhz7Eb1g84iLkiB94QllwGFc2xEAMkP/SdQiE+vT cCtNhgGuxLTB8xAWeH6jvoL+8L2eTQxoEcYA2lZ2At6qM1gkLqT44IKP3pvBp5KuP7r4kJtus WuEfh9J4Stw9hjvhuN0BCpQjoLCpmGp6mZ3BnlMjgSTFedpjBK9RQ0dm8WWcRJWTtAnmWtmFl PJJCUnslxhg8V3+W9HolpgZtqMLln9XydfVy3kC5LThqppGf/W5f1b5DvgmWP+DVaRCfM00ni T0bpoNOYwMPET9kQIK0yiACXfoQlyn5Di57RVh76+n11+sRNOnzH6fjnGmmqS9nUQiQnKG4MZ 2jBJlOQ1B+CYm+LnrcpDW+uyAI8WpHauBP/VPbw4KUNeJ/59FUspphIEmw9vxnUivtQK6VUUJ CJQas+MydDo9eOHCgUeuVziVbkIuUZIbx/qawlO/oEHLCPfZRQ0GRZNeZzfXMdVErN0jWJ4v0 513b1yOl+g37k09Q3mcFaWS00rCqiH0GgF9K+88nl6ZNXUTYmlcvYDXXPQKYiRCuMl7XPTQy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288365 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 04 Jul 2024 12:59:24 +0300 Eli Zaretskii wrote: >> From: Eshel Yaron >> Cc: Juri Linkov , John Paul Wallington , >> Basil L. Contovounesios , kickingvegas@gmail.com= , >> 71927@debbugs.gnu.org >> Date: Thu, 04 Jul 2024 09:12:10 +0200 >> >> Eli Zaretskii writes: >> >> > I have a question: ibuffer-do-isearch just calls >> > multi-isearch-buffers. Does multi-isearch-buffers exit immediately, >> > or does it exit only when the multi-isearch is done? If the former, = I >> > guess this is why the problem happens. >> > >> >> So we need someone who knows ibuffer internals. >> > >> > I've added two people who might be able to help. >> >> FWIW, AFAICT everything is working correctly, it's just that the >> "Operation finished" message hides the prompt. ibuffer-do-isearch >> should tell define-ibuffer-op not to display that message, somehow. > > I don't see how this could be considered "correct": the "Operation > finished" message is supposed to be shown only after the Isearch is > finished in all the marked buffer, not before. It looks like we need > a function that will not return until all the buffers where searched, > because that's what define-ibuffer-op expects. Don't you agree? The attached patch appears to DTRT, but I only tested it briefly. Steve Berman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: ibuffer patch for bug#71927 diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index 95ff014aa5b..9ad033b5fdb 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -598,7 +598,7 @@ revert (define-ibuffer-op ibuffer-do-isearch () "Perform a `isearch-forward' in marked buffers." (:interactive () - :opstring "searched in" + :no-opstring t :complex t :modifier-p :maybe) (multi-isearch-buffers (ibuffer-get-marked-buffers))) @@ -607,7 +607,7 @@ ibuffer-do-isearch (define-ibuffer-op ibuffer-do-isearch-regexp () "Perform a `isearch-forward-regexp' in marked buffers." (:interactive () - :opstring "searched regexp in" + :no-opstring t :complex t :modifier-p :maybe) (multi-isearch-buffers-regexp (ibuffer-get-marked-buffers))) diff --git a/lisp/ibuf-macs.el b/lisp/ibuf-macs.el index 1fd94967836..ace1972054f 100644 --- a/lisp/ibuf-macs.el +++ b/lisp/ibuf-macs.el @@ -166,6 +166,7 @@ define-ibuffer-op mark modifier-p dangerous + no-opstring (opstring "operated on") (active-opstring "Operate on") before @@ -196,6 +197,8 @@ define-ibuffer-op OPSTRING is a string which will be displayed to the user after the operation is complete, in the form: \"Operation complete; OPSTRING x buffers\" +NO-OPSTRING is a boolean which should be set to suppress the message +after the operation is complete. ACTIVE-OPSTRING is a string which will be displayed to the user in a confirmation message, in the form: \"Really ACTIVE-OPSTRING x buffers?\" @@ -246,9 +249,10 @@ define-ibuffer-op ()) (and after `(,after)) ; post-operation form. `((ibuffer-redisplay t) - (message ,(concat "Operation finished; " opstring - " %s %s") - count (ngettext "buffer" "buffers" count))))) + (unless ,no-opstring + (message ,(concat "Operation finished; " opstring + " %s %s") + count (ngettext "buffer" "buffers" count)))))) (inner-body (if complex `(progn ,@body) `(progn --=-=-=--