* Setup process for etags-regen-mode (Emacs 30.0.91 feedback)
@ 2024-09-20 18:14 Morgan Willcock
0 siblings, 0 replies; only message in thread
From: Morgan Willcock @ 2024-09-20 18:14 UTC (permalink / raw)
To: emacs-devel; +Cc: Dmitry Gutov
When testing etags-regen-mode in the Emacs 30 pre-release I've found it
to be working well for my use-case, but one thing which appears to be
missing is an easy way for additional completion functions to opt-in to
the etags-regen-mode setup process.
Currently the completion functions which get advice added to them (to
call etags-regen--maybe-generate) are hard coded in the mode definition:
(if etags-regen-mode
(progn
(advice-add 'etags--xref-backend :before
#'etags-regen--maybe-generate )
(advice-add 'tags-completion-at-point-function :before
#'etags-regen--maybe-generate))
(advice-remove 'etags--xref-backend #'etags-regen--maybe-generate)
(advice-remove 'tags-completion-at-point-function #'etags-regen--maybe-generate)
(etags-regen--tags-cleanup))
I was looking for a stable entry point to opt-in to using it, rather
than having to do something like this:
(advice-add 'my-completion-function-which-does-things-with-tags :before
#'etags-regen--maybe-generate)
(Where the "--" in the function name is a sign that I probably shouldn't
be doing that.)
I wasn't sure whether it was intentional to hard-code the functions to
advise while etags-regen-mode was still so new, or whether opting in
other functions hadn't been considered.
Would it be possible to store the completion functions which will be
advised as a separate list, so that other packages can add completion
functions to that list and get the TAGS generation to trigger? Or is
this an intentional boundary?
Thanks,
Morgan
--
Morgan Willcock
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-20 18:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-20 18:14 Setup process for etags-regen-mode (Emacs 30.0.91 feedback) Morgan Willcock
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.