From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73320: [PATCH] project--vc-list-files: use Git's sparse-index Date: Fri, 04 Oct 2024 09:48:53 +0200 Message-ID: <878qv471ga.fsf@gmx.de> References: <73758f39-1e18-471a-9dfb-0ceade12dacf@gutov.dev> <8e00a62b-c531-4593-90c3-55e060c5434f@gutov.dev> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Sean Allred , 73320@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 04 09:50:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swd58-0009ba-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Oct 2024 09:50:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swd4h-0001Gz-E8; Fri, 04 Oct 2024 03:50:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swd4c-0001Gb-GW for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 03:50:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swd4a-0006JQ-Ab for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 03:50:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Kbxysy5bmgtn67Z5xQSyTP3a9lBFBqsrN+Gbma9YjIw=; b=s+UKB6uBW1Q1DbKiJsTuC02jf9xZin9XMLfW+hXxQr4Kv0STy2VRbq3LCXhCEH+fhU19ZGQZD4Aa3I04TDUQgR3qwz4K2eeRIkas/ljenVtbf+YjSu2Uko3JGwz4TnSZqDtbd8P6dUD61VK7FSjpmLGeYAjc+dNodQgoSWXnFQ+MAW625c0Zs3P7whLCO7FaKdnUM9cbmAXJK9j0B5yGZE/dRGLInKLr6g066Yrp75ITG3vMKQziwE+tWFYDlFdOXJIH7gplUonKMTZExmbYWp5bEoacjw1bkXiq0I+3ahxJQy6l3A+w+It+h5KWFh5Crkh/6y+lCyxI9l8ZXmhRfQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swd4c-0004PQ-H4 for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 03:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2024 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73320 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73320-submit@debbugs.gnu.org id=B73320.172802815516878 (code B ref 73320); Fri, 04 Oct 2024 07:50:02 +0000 Original-Received: (at 73320) by debbugs.gnu.org; 4 Oct 2024 07:49:15 +0000 Original-Received: from localhost ([127.0.0.1]:34331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swd3r-0004O9-8M for submit@debbugs.gnu.org; Fri, 04 Oct 2024 03:49:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swd3o-0004Ns-Qr for 73320@debbugs.gnu.org; Fri, 04 Oct 2024 03:49:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1728028138; x=1728632938; i=michael.albinus@gmx.de; bh=Kbxysy5bmgtn67Z5xQSyTP3a9lBFBqsrN+Gbma9YjIw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=QY5+Zp3qNoPEL6fsunH+AJFgkK26SyjPIR1rm6TO24PAqCDTmm43uJlvDyqMu4OZ +1CGiselToPePJG1yXH9FQmIP5PcDZz31PExywmL3pOaoK6jqJV++0FsxlkxsbLet Fn4g52a+kjonbXzFqh7Ta/rHwVQzvnJ9I56knkzsR6CqtUI35f9bVxwh7ifHmkQoY u8AGCdm/I5CP8cZV9+5bslGLjnQCxkPX1kWz8ZqlqEPX1V3gsD4KUNkHG+aVafBW9 4Osab1VG+wo1P7iWUgZx2fEdA9SacSuPZOr6Fm/fSMTDErTSS/jEntO1LjS8j7gh3 vca93Tzg0N1gelGNNw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Ml6qC-1sBDPS03q8-00pfk9; Fri, 04 Oct 2024 09:48:58 +0200 In-Reply-To: <8e00a62b-c531-4593-90c3-55e060c5434f@gutov.dev> (Dmitry Gutov's message of "Fri, 4 Oct 2024 02:57:22 +0300") X-Provags-ID: V03:K1:jMdq+3+4qZlaXgEUHICWPsVXBliWrv6/0Y83eZnjzJky9yG3T9k tWoItGenCDjBDC6TMenbj5D08OPnSRp4NqV+iiI6eYZY4a1aBbM5whEoxd0kEroP8l4RZmt m5kFZmposJZ1wPMBhoKvjvz9k8MVkpR41gYLa8wapjy8yc5CFoE6D3Iy++G8rYiE0rmXs30 mY3N5Wfe2EFaPmJT/SkXg== UI-OutboundReport: notjunk:1;M01:P0:2sI/jIMlLsU=;nfaIXJGeIMJaTXV+jAvv1qia3fi Pvd2gXmH5PCUJBfDyaV8pvHIX+Lpn/ApbY6NsPpcN0bUKPRHWdgs7kSHt95N/E/urWyOJiOyz A8eXVUVK4HDL2cMDL21AtRpJuhLD1mdtLjDwEodkchcCjy4cmI1PxVXv4OvZyCiUDbf/BkqDT 32s/Np9riyFSZSBg/opnIGx7hzAtts325fyc9v+Sb4aCkQfk5sVvLJLkEjUvqgbzG9g49xv+3 sic8IK1NhDdH2l5AUsmDI72JJyuy2af264qaa9AkVaDvfhSIIiudno23xMSWBSWoPmfDWxYqN rJvp1S0iZf/lh75WLpk88iJDHbAzwsi7/qFPoUWiIM9koHrgXD3o5sbIHSFkjVEmuWc3LnXHQ ecjY1bl5qmr6pqZFRjGrh7Gka4I9jHxLk8YGtqjMzSkMiTg75rR38zllqbUDrvXEcL2b56GS7 NXjEIp4qjJaeCBD5NqS7xukKaF9AKK/hf+wmt44xj3p11tG+sXK6oFZOUS2fFkf+OtNZSZ3B6 FuR4YZ+tZT3RLznp5DgZ32yczRvrmlixhny0hExTpDrQ7EK8dmTrru3q+dRxK12SB/ib1bDNr Oi9wwwdQ73DHuDplwt+Q50VAGDmJapfpwxZlVcIHZ09VlrZgeKk51DApycS6nWu/VSYQmtZ9R /T6sbSBEjOw5y4wbU8s0L2cXT8wmSFGEpMzmF6ltFnVogVelOOdACZeIIvA9/KQuOoOGdEsSN hnIfRER81HnzqKZ2toOCUCMMCCMhR7o+RZd8M1YmnxpmBOZDGVuQLke2h2S7XBQKi6yPdUn0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292950 Archived-At: Dmitry Gutov writes: Hi Dmitry, > It could use some review, though. There aren't many examples of doing > that in Emacs code. In Eshell, Jim Porter makes extensive use of connection-local variables. He has also added some functions which are useful (not applied in Tramp yet). > Michael, could you take a look? Does this look reasonable? Should > :application be 'tramp' or 'vc-git'? In general, it doesn't matter. But since your change is dedicated to vc-git, using the application `vc-git' makes sense. However, you use with-connection-local-variables, which uses the application `tramp' by default. Either use with-connection-local-application-variables instead, or let-bind connection-local-default-application to `vc-git'. I'm not sure how setq-connection-local behaves wrt to the application (this function was written by Jim, I've never used it). But binding connection-local-default-application should be good enough, I believe. > Is the 'connection-local-set-profiles' call needed here at all or can > be skipped? It is needed. connection-local-set-profile-variables declares only the variables, connection-local-set-profiles activates them. Best regards, Michael.