From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74090: 31.0.50; Problems with dabbrev-expand Date: Thu, 31 Oct 2024 11:01:04 +0100 Message-ID: <878qu4wpzz.fsf@gmx.net> References: <878qu6j0tx.fsf@gmx.net> <8634ke4vv5.fsf@mail.linkov.net> <874j4uivnx.fsf@gmx.net> <86y1262ghq.fsf@mail.linkov.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74090@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 31 11:02:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6S0N-00038b-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Oct 2024 11:02:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6S0D-0006s8-Op; Thu, 31 Oct 2024 06:02:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6S0A-0006ri-F0 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:02:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6S0A-0003C7-5q for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:02:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2Wucvvi1cPCrgXeA5N71/xwuB8FgP0YyA8IOI47uXDw=; b=BGRoNgizIYw0eNfZ8J3Zi0uuzR9MmLAugnXPV8ILqlIJnntc/49/bsu7mzI8oOmBphDeMfa8+B38TMMsMXHDQiEOfU+zD8bDIDsqR+jBc26DyvN4/NPBYDC6NfCClVJr2tpHT8qQhvXnJuFGqEthPjVe/w2H2qt6vqHN6rk9tp17kuCQUE2xRz5ygv6MG3kF3DR5MYa+SmcERZiqM+7yEGkp32WQ24W6gqq5A5lEFTkdeDn4rJ7g4YyKTp6fxRY8qHLX3DUWyb0YAS1K8sqX4Cd41RTmd2rsLUan7n1sGHkiKUxXzwROD9uqT9WcDnQg2dK6LuIyP7fonXPZ5gBCsA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6S09-0001mD-Vn for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2024 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74090 X-GNU-PR-Package: emacs Original-Received: via spool by 74090-submit@debbugs.gnu.org id=B74090.17303688736799 (code B ref 74090); Thu, 31 Oct 2024 10:02:01 +0000 Original-Received: (at 74090) by debbugs.gnu.org; 31 Oct 2024 10:01:13 +0000 Original-Received: from localhost ([127.0.0.1]:41317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6RzN-0001lb-6i for submit@debbugs.gnu.org; Thu, 31 Oct 2024 06:01:13 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:57735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6RzL-0001lT-3k for 74090@debbugs.gnu.org; Thu, 31 Oct 2024 06:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1730368865; x=1730973665; i=stephen.berman@gmx.net; bh=2Wucvvi1cPCrgXeA5N71/xwuB8FgP0YyA8IOI47uXDw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DmTsVev9crdKIX7euONa6Etn0gx1LCCyRvkUoCcvm6E+AWMlHdmDPQt2cnIGJwji ac837PT6qYx2LqgqCZqxsrVX15mQfr7LFsLR9zLMwinAh4DTkNIcScjhIDIjWPrDP BOfx/saejsiez4a1LO9biNuIpOY3oI39nI/SBGlbN3/gPppqof7c/Lg22IWMBkqpH fgLwbs/TztgJR6aU6LPgKLv6asrzUpbfAvBgUIMQwZ65k8vFwxzr00h6eYrN+mOqi x8COJQ/SI0fXit3KDkJ5kKTO67ZuzlNicTBrT7Zhe1dm5ROb+UHEMnRszroZoIW7s drA/YjV/mekDjD85mg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.95.122]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfJd-1tznQs0Ut5-00w4PL; Thu, 31 Oct 2024 11:01:05 +0100 In-Reply-To: <86y1262ghq.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 30 Oct 2024 09:32:17 +0200") X-Provags-ID: V03:K1:AjMp3Lcbk0oh/4rGlbRiCKVcWtE8dkBJYDaTjFz8MVQt6MJTiQW jQ58jBqxTD8/dzk0wprsf6Bj1AXvt5pG4xvPm8YAQ0UuKgULwgzHa1m1zwuDptR2qTUsSSl 5d5O+P4WqxK2DPxYhpNjfvkvcV9+v9xvkIdDr9pWrqdsz5rp+uicS3+iUKkaiNIqG5n3DoG /pSY3ZA8piTOWWoqOZqOg== UI-OutboundReport: notjunk:1;M01:P0:IsS/mVXOCt0=;h73jzobkfEnJlVds1EmudPOSAoY LIsJCNVIuy6iJWxKJPQSHy0f3BRqsSziZrpivGNQhLA/bUuHYfceaVoRKcL8uj3dy4FxB0gfc 7afk50GLBU5ki39MVY5I5FC3UcR9XMiqUI9KHLUAXLZ+3Bgj4/8SJR99gpVW7YvDB1cDWVOQz YWmmysRCPZADi99tlByCrFHiB47E5SWJ4ZcNlx9SgBP28e7BnaK+KYjpIWPKmX+z68JrxA8Bl t66QwLoTaTI4XJRBkut2SEFzDLyHQtQm3XpijqfTb7HG6HJJPW1dlPu7ssA0AA7JFxZ0uDpzt TCPQPOCjIJZw+rJccOHhJcYWHvH9IUsDTasdY60CsBiSJBy0HQCJk4m0DPJbRv2L9euwn/ATL eSidKhReCVlBZ9zpM9EjhB12lBYz5GApjIzRfY10ORT/PfNblWoH5MjY9lWN/XvmPAu7uHRI2 TtLM3FfI+9BzO/GjO+UO+jHhnuWgCdIqb0mgDGPh7ztdXiRei10fWErVAXbM7LC9L+ycPuCHn lsDCmtdpgGKqDUdeq18HZageIsLPDaRw4Vh5Gvw6+SN9E6FEzFS7hYLrSLxJ4JMbEJEHp+o7l +MU8hUHJLv1Z1wMhXtWT4Ecj6tMyT0cIVLK9Au3v2nqV7HwieV6hF/dCxeVdgiVeBdc5cNyhB YQLRiAnxjZO1awPS1Sh27MA2ihy+624/gfja5bRpXJF795uQ+eHQI3uMKNiUnTs4CgURVluxb +/vYpYUFXcXHIUHm64MAkRQwASUduRmPDonmthpQnu6WWOsZnnV79m/JfzEt4BiE2RyZf0uM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294602 Archived-At: On Wed, 30 Oct 2024 09:32:17 +0200 Juri Linkov wrote: >>>> The attached patch fixes these problems, according to my tests. >>> >>> Maybe your patch also fixes bug#36516 >>> where we failed to find a solution. >>> Or maybe these are separate cases. >> >> I was unaware of that bug, thanks for the pointer. But unfortunately, >> my patch does not fix it. My changes only affect cases where the buffer >> in which dabbrev-expand is called is different from the buffer where it >> finds the expected expansion (at least I only tried to fix such cases >> and not alter the behavior of the same buffer cases). I'll try taking a >> closer look at this case, but judging by the discussion in that bug >> thread, it doesn't look related, or easy to fix. But as was noted in >> that thread, at least you can get the expected expected by repeatedly >> typing `M-/', while in the cases I tried (hopefully successfully) to >> fix, without my patch either you cannot get the expected expansion or >> you get an error, so bug#36516 seems less serious. > > Indeed, bug#36516 reports just a logical inconsistency, > whereas your patch fixes a plain bug. I've looked at your patch, > and everything looks right, and the comprehensive test coverage > will ensure no breakages, thanks. Thanks for the review! Steve Berman