From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karthik Chikmagalur Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Proposal to add consult-dir to ELPA Date: Fri, 15 Nov 2024 11:06:36 -0800 Message-ID: <878qtke2pv.fsf@gmail.com> References: <87ldxmmmlo.fsf@gmail.com> <87sertdspv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 15 20:07:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tC1fB-0007hf-VW for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Nov 2024 20:07:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tC1eV-0008IJ-TX; Fri, 15 Nov 2024 14:06:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tC1eV-0008I9-BQ for emacs-devel@gnu.org; Fri, 15 Nov 2024 14:06:43 -0500 Original-Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tC1eS-0007ca-HL for emacs-devel@gnu.org; Fri, 15 Nov 2024 14:06:41 -0500 Original-Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-211c1c144f5so17359975ad.1 for ; Fri, 15 Nov 2024 11:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731697598; x=1732302398; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=H4/DA75Xobc0FJ8uyKpT0Bo5VvP/Kwun+BiFxRtakSU=; b=izQResJ99kseYRR5PFbAimrubr+QIyPeUtJt5J56Bwqt00aBcg3tIBLj/GxI4Y205/ GeXqDrC27pWOf1IJqMZgqtuh5O5ybllibAn1LSzrfrI0ytJ3l3gxOG6l6OLEg1FvkC8c UG+Shr/6QSPd47fYsnoMt+asnVlBLU+F4IxJGSl5Hxt/TsG3Fm98bCgEq+0AQd7QZezB LOT9Hf9SPqPAmfrD62795k1zcUP0kWYMQ0KScjEkVVux87/cK7/7wlob0s2V5C4ewd/+ 1R8CafwU2RDsbxj94KE+vgMjsfmpH08GNem9p2Jmc9Ay2tg4CeFNMHMi9SJKfShY0xdM zaXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731697598; x=1732302398; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4/DA75Xobc0FJ8uyKpT0Bo5VvP/Kwun+BiFxRtakSU=; b=IbOObCKkmBjwlSwFeliUFLsyZxrVx9wXBSdrIsBbeI6LnxIsID5AL7x5ijf3/W+yOD YfVhGn/8kIND8pWyXbIsECAmy5rs5EgKIyhJ0nUIh0AQg8cDvrjGzpC1GLw0yjbMX6jd nBdFJQYGckh5wL05tnwuVik+blOtUslWnCSoVfy7wBt5NE7UBB9v4cAovxDuF4MsBxTN Uo30S74BBpOUK1Tvu99d52Q8roPnkw7WJept8QOdgO/uPUg2cR8Mb1b2CpxEWYSlIOdM T/IT/rWSCUDjHTTG/db1snW25q8MTErTzookog3rY/5A4qqWJfSGdYOBw0QZVB9rzTB8 ND0g== X-Gm-Message-State: AOJu0YxcxEtUqRVl5mcN74reKy+uvTemeeFou3WF2putiQtL8vn+tGdc o74LFCKfS64utCpaBndZLKcKq8OKCOcyDFHtd/kiGusSc10Ymg6AVkDsGQ== X-Google-Smtp-Source: AGHT+IG5zicxx3UcGJKgYZ3cgSCxmDUawM0t0fGLxMUROt+M6zxIaiQ68SqyCDib2zPVMFJcVe6ESw== X-Received: by 2002:a05:6a20:430c:b0:1db:d6e4:d1d9 with SMTP id adf61e73a8af0-1dc8fd8383cmr6583216637.1.1731697598432; Fri, 15 Nov 2024 11:06:38 -0800 (PST) Original-Received: from localhost ([2600:8802:5726:2500:d4db:80d7:a7f3:76e0]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8c1c1942asm1651238a12.5.2024.11.15.11.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 11:06:37 -0800 (PST) In-Reply-To: <87sertdspv.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325466 Archived-At: Thanks for the review, I'll apply your suggestions and get back to you when I can. >> I have found it to be a surprisingly versatile tool, and many users have >> told me over the years that it solves a problem they didn't realize they >> had. > > What is not clear to me is why this is not a part of Consult, if it is > as useful as you say. Have you discussed this with Daniel? In any > case, it would be useful to explain that somewhere. This discussion was had in https://github.com/minad/consult/issues/373#issuecomment-889841426. The conclusion was that it would be better to have this be a separate package. Here is the relevant part of the exchange: > DANIEL: ...I am not sure. And since Omar still has his bookmark > directory jumper, there is probably a need for such a feature. Maybe > one should also reconsider adding some new commands to Consult itself > which fill the gap. Generally I am hesitant to stuff much more > functionality into Consult itself, but a directory selection command > does not sound unreasonable. > > ME: If you're interested in adding this to Consult, I can submit a > PR. I'm okay with it living in a separate package though. > > DANIEL: Currently not, since I don't have a clear picture of what I > want. But if it turns out that we find something small and generic I > would be happy to add it. But adding multiple new sources, many commands > etc, does not seem to me like a good idea at this point. I'd rather > modularize the ecosystem more. Right now Consult is already pretty much > a kitchen sink, but my general guideline is to maintain mostly reusable > components here. For example consult-org-heading is a generic Org > jumper, and you can glue it together with other commands or with Embark > in order to get richer actions on the headings. Another example is the > recently added consult-line-multi, which allows you to specify a query > argument to restrict the set of buffers. This way I avoid having to add > more special consult-line-all-buffers-of-this-and-that-type style > commands. >> I have signed the copyright papers, and there are no contributions to >> the project from users over 3-4 lines in length. Consult-dir's only >> external dependency (Consult) is in ELPA. > > 1+ (though I have suggested to depend on project so as to lower the > dependency on Emacs). Why is adding another dependency a good idea? Isn't Emacs guaranteed to ship a supported version of `package.el'? Karthik