all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Turn org-mouse features into minor-modes
Date: Fri, 27 Dec 2024 14:05:52 +0530	[thread overview]
Message-ID: <878qs1cyl3.fsf@gmail.com> (raw)
In-Reply-To: <874j2p7crt.fsf@localhost> (Ihor Radchenko's message of "Fri, 27 Dec 2024 08:25:58 +0000")

[வெள்ளி டிசம்பர் 27, 2024] Ihor Radchenko wrote:

> Visuwesh <visuweshm@gmail.com> writes:
>
>> [ Resending it as it seems like it never reached the mailing list.  ]
>>
>> To make loading org-mouse less annoying for all, I was thinking of
>> introducing minor-modes like in the attached patch.  If this approach is
>> acceptable, I will get to calling out the change in NEWS and updating
>> the manual if required.  We could also add a `add-hook' call to turn on
>> the minor-mode automatically to preserve the old behaviour if required.
>> WDYT?
>
> Thanks!
> Adding minor modes is indeed a good  idea.
> Although they should probably be globalized to keep things closer to the
> existing behavior.

That would make it hard to toggle the feature on/off on a per-buffer
basis, which was my intention behind using a minor mode.  I don't have
strong opinions here so if you think otherwise, I will use a global
minor mode instead.  If we go the global route, shall I make it so that
activating it would enable mouse support for both org-mode and
org-agenda-mode?

> We do not need to preserve the old behavior - side effects are to be
> eradicated even if the cost is introducing a breaking change.

Thanks, this will save some headache.

> NEWS announcement is good enough.

Noted.


  reply	other threads:[~2024-12-27  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 13:14 [PATCH] Turn org-mouse features into minor-modes Visuwesh
2024-12-27  8:25 ` Ihor Radchenko
2024-12-27  8:35   ` Visuwesh [this message]
2024-12-27  8:40     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qs1cyl3.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.