From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75359: [scratch/elisp-benchmarks] test dependencies Date: Sat, 04 Jan 2025 16:37:26 +0000 Message-ID: <878qrqfse2.fsf@protonmail.com> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2018"; mail-complaints-to="usenet@ciao.gmane.io" To: 75359@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 17:38:17 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU7AG-0000Ne-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 17:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU7A6-0007QR-Kc; Sat, 04 Jan 2025 11:38:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU7A3-0007Oh-Mr for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:38:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU7A3-00076i-F2 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:Subject; bh=Wn+/jxqZzE68eJuX1j/Evzjn9ThC70XMy0ZTVBon/u4=; b=MWJkNkzqJlaai6ViDC0RK4ah1HmX5DxV34KCnN/qvwE1egk9I1dHu2j8p/JBpU54EvbA61Vp1q7iE+bL8ZzMnStoDGBOIVIwz/TJrSZjzpBffwR+FUXrQMiA2/oQaOneRgSidLsRHpDidztr90ueUipCgCDaBPQ0EItEmpwcCCFZS9+ZPyxatM/+juDcOWOf5KLiVkESHS1ChzqwTjC7lhb4vTEKKliSzq6BsNYVfc6Lu1Wjihjawwb45uDZPvUzwqSLmAC40jqbtFx63n0jqkEYw6TAhsS1q0Hb1s1f1aM9Q2smdD3NwuJwohAMUQAv1A7p+f2Vd/YdyFUsOlDegw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU7A3-00015o-8K for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:38:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 16:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75359 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17360086594146 (code B ref -1); Sat, 04 Jan 2025 16:38:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jan 2025 16:37:39 +0000 Original-Received: from localhost ([127.0.0.1]:56888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU79e-00014n-Op for submit@debbugs.gnu.org; Sat, 04 Jan 2025 11:37:39 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:44324) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU79d-00014V-Ep for submit@debbugs.gnu.org; Sat, 04 Jan 2025 11:37:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU79Y-0007IF-5k for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:37:32 -0500 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU79W-0006rA-Hx for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 11:37:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1736008649; x=1736267849; bh=Wn+/jxqZzE68eJuX1j/Evzjn9ThC70XMy0ZTVBon/u4=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=KjOqgleK4fGmkB4SKgIURo4kTmQhpetVNKtDoi+LSZHC2V2szw4FNnVQyx5Ds6K60 XXkJ0OXMa338cWJMEoB1bPCL+gPhblOeg+/aVUGfmhmW59mhdabhfEBeeIM/fvszir whu1Lk+Cv4N3zZPahmWgSooecizudVqniu8WXgzR2WlSfi430PKKWXMAmCHBI/6fuR qNoDT37tlKUNRqH9dPRGtwFTdwzn71V2octhltmhmfaXSY/Eu1HjlPspp3HwucSJ1i V2R9oSbPkiZKQbwQb9PuNMwEMMycjJ8EWcVMxoTDFVucCr+aq6pQyK8F4fJjAgd8rh Kyb5MutuIZd5g== Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 14416cd2b586cb2665e70432c41a079bb2ed8c13 Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298430 Archived-At: There are dependencies between emacs-lisp-benchmarks tests, meaning we can't always modify one test without affecting others. The ones I'm aware of are: - elb-bytecomp.el uses elb-smie.el as compilation input (in this context, elb-smie.el is a "resource", not source code). If we modify elb-smie.el, elb-bytecomp.el results will change and become uncomparable. - elb-scroll.el uses elb-smie.el as a prerequisite. If we modify elb-smie.el, elb-scroll.el results will change and become uncomparable. Furthermore, elb-scroll.el relies on elb-smie.el being compiled in the appropriate fashion by some external mechanism. (I think the best solution here is to merge elb-smie.el and elb-scroll.el into a single file declaring several tests, using the established ERT test framework) - bubble.el and bubble-no-cons.el both "provide" the same feature. I'm not sure whether this causes any acute problems, but it demonstrates that the inconsistent use of (provide) in the benchmarks is problematic. If we ever load tests using Frequire, we will load the wrong files. If we don't, provide shouldn't be necessary. - xmenu.c is used as a resource; this is fine. But we must make sure we never copy the "current" xmenu.c to the benchmarks directory without clearly indicating that the benchmark results will become uncomparable.