From: Ihor Radchenko <yantar92@posteo.net>
To: Buoso Donati <poverobuosodonati@gmail.com>
Cc: Leo Butler <Leo.Butler@umanitoba.ca>,
emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Language support for C# in org-babel
Date: Tue, 07 Jan 2025 18:04:09 +0000 [thread overview]
Message-ID: <878qrm33hi.fsf@localhost> (raw)
In-Reply-To: <7d0db99b-f926-42b1-a867-2b05e0224323@gmail.com>
Buoso Donati <poverobuosodonati@gmail.com> writes:
> Are there any objections against me trying to upstream this addition?
C# is a popular language. I have no objections to adding it to the core.
> ... I would go ahead and try to open a pull request following the
> guidelines from this documentation
> (https://orgmode.org/worg/org-contribute.html) if there are none. Or
> is there a better way/no need for it in the first place?
If you can, please do follow what is written in our contribution guide.
But feel free to ask us anything if you encounter difficulties.
You do not have to go through all the requirements alone.
> In fact, I was most inspired by the existing ob-C.el and ob-java.el!
> From what I understand C# (in conjunction with csproj-files) is
> "different enough" from C/C++ and Java (I don't feel particularly
> comfortable judging the D language) that it somewhat makes sense to
> create an individual file integrating it (as opposed to increase the
> complexity with existing integrations).
> I will however consider this and re-evaluate my initial concept with
> your feedback.
Generally, it only makes sense to extend an existing library if there is
very significant code sharing. Otherwise, no need to complicate things.
Also, before you proceed, note that there is ob-csharp in org-contrib
repository:
https://git.sr.ht/~bzg/org-contrib/tree/master/item/lisp/ob-csharp.el
It is very simplistic though. Just letting you know so that you are
aware.
You do not need to reuse that file or anything like that - we *cannot*
use that file because its author did not sign copyright papers. (BTW,
you do need to do it - let me know if you need any assistance)
After your future patch is accepted, we will likely remove ob-csharp
from org-contrib. Which means that you should name the new library
ob-csharp as well - it will serve as the replacement.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2025-01-07 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 17:44 Language support for C# in org-babel poverobuosodonati
2025-01-06 18:19 ` Leo Butler
2025-01-06 21:09 ` Buoso Donati
2025-01-07 18:04 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qrm33hi.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Leo.Butler@umanitoba.ca \
--cc=emacs-orgmode@gnu.org \
--cc=poverobuosodonati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.