bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]


When trying to compile the Emacs Treesiter branch, I got the following
compilation error:

In file included from emacs.c:140:
./treesit.h:23:10: fatal error: 'tree_sitter/api.h' file not found
#include <tree_sitter/api.h>
         ^~~~~~~~~~~~~~~~~~~
1 error generated.

The reason is that the Makefile is not referring to the correct C
compiler flags because of a typo.  I've attached a patch to correct the
problem.

Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-typo-in-Makefile.in.patch --]
[-- Type: text/x-patch, Size: 764 bytes --]

From 6abc91130d2035f2a86a40f9bed28cc68e17a06a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <mardani29@yahoo.es>
Date: Mon, 10 Oct 2022 13:03:30 +0200
Subject: [PATCH] Fix typo in Makefile.in

* src/Makefile.in (TREE_SITTER_CFLAGS): Set the correct C flags.
---
 src/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.in b/src/Makefile.in
index eb537e2127..0d27f3e6db 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -344,7 +344,7 @@ JSON_CFLAGS =
 JSON_OBJ = @JSON_OBJ@
 
 TREE_SITTER_LIBS = @TREE_SITTER_LIBS@
-TREE_SITTER_FLAGS = @TREE_SITTER_FLAGS@
+TREE_SITTER_CFLAGS = @TREE_SITTER_CFLAGS@
 TREE_SITTER_OBJ = @TREE_SITTER_OBJ@
 
 INTERVALS_H = dispextern.h intervals.h composite.h
-- 
2.34.1

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Yuan Fu]

Applied, thanks! The previous message didn’t cc debugs for some reason, sorry for the noise.

Yuan

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Lars Ingebrigtsen]

Yuan Fu <casouri@gmail.com> writes:

> Applied, thanks! The previous message didn’t cc debugs for some
> reason, sorry for the noise.

The bug report was left open, so I'm closing it now.

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Yuan Fu]

> On Oct 10, 2022, at 5:41 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> Applied, thanks! The previous message didn’t cc debugs for some
>> reason, sorry for the noise.
> 
> The bug report was left open, so I'm closing it now.

Thanks, I tried to close it with debbugs.el but it didn’t seem to work. I hit typed “C done RET” on the bug entry. Is that wrong?

Yuan

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Lars Ingebrigtsen]

Yuan Fu <casouri@gmail.com> writes:

> Thanks, I tried to close it with debbugs.el but it didn’t seem to
> work. I hit typed “C done RET” on the bug entry. Is that wrong?

I think that's supposed to work -- I haven't tried that in a while.  I
always enter the debbugs group first and then use the `C' command there.

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I think that's supposed to work -- I haven't tried that in a while.  I
> always enter the debbugs group first and then use the `C' command there.

I tried it now, and it worked for me.

Perhaps some temporary hiccup on the debbugs side?

bug#58411: 29.0.50; [PATCH] [Treesitter] tree_sitter/api.h file not found when compiling Emacs

[Yuan Fu]

> On Oct 10, 2022, at 7:42 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> 
> Lars Ingebrigtsen <larsi@gnus.org> writes:
> 
>> I think that's supposed to work -- I haven't tried that in a while.  I
>> always enter the debbugs group first and then use the `C' command there.
> 
> I tried it now, and it worked for me.
> 
> Perhaps some temporary hiccup on the debbugs side?

Thanks, then it’s probably something I did wrong. I’ll try it again next time.

Yuan