From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 2399541: Remove font-lock toggle from font-lock-update Date: Wed, 24 Mar 2021 22:27:13 +0000 Message-ID: <8786a8e8fa96815c66e3@heytings.org> References: <20210324143048.23515.75257@vcs0.savannah.gnu.org> <20210324143050.40C6E20D10@vcs0.savannah.gnu.org> <8786a8e8fa731c1bd1ef@heytings.org> <87h7l0blrc.fsf@gnus.org> <87czvobksy.fsf@gnus.org> <87r1k4a1c0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , "Paul W. Rankin" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 23:28:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPBz0-0000fw-UK for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 23:28:10 +0100 Original-Received: from localhost ([::1]:50552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPBz0-0002Ze-04 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 18:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPByC-00029R-Oy for emacs-devel@gnu.org; Wed, 24 Mar 2021 18:27:21 -0400 Original-Received: from heytings.org ([95.142.160.155]:44058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPBy8-0005wR-Fn for emacs-devel@gnu.org; Wed, 24 Mar 2021 18:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1616624833; bh=f0CqLM3LMw40oe8zcu4+hHDmtZm6lnyw/Y2vXhmKMUM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=PlM5oH3XpElSHuQH2qtBrjivQsDCgtFU2ieAG9prFSLGu65+0MTnOEQxv79CgYyuR dVsr9dpyHzc96fAJZeLYx6LEMCw9LioAsNzIQwhdcaU0SfuWvPnuNc5MvorFk+UE3M OuVEjkRAeSO4ZDcH7a+RcE/DbVZverzTYfJdnyjca0mL8py9GX86d+Z2j0BRx5+mob MQqCepZsRMh/dTKHh+cwqhw09PIjvQeyNgnWrci1xRzA33vmwupsvQwhCCF86K70Vq 9dILz+3UJdg3uoeiuzKL1f01m+JzF6PFY7j1TM+yS+2oIjjmn6GVYsB5b2Jr9Ja3DJ CQQFU07fjJK8Q== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266991 Archived-At: > > FWIW, I'm not sure if `font-lock-update` (ether it's Paul's or the > other) is really better than the old `font-lock-fontify-block`. I think > they all suffer from being fundamentally "defined by their > implementation" making it hard to evolve when some change is made to the > font-lock machinery. > Hmmm... You said: "`font-lock-fontify-region` is an important function internally (it's the one and only function which performs font-locking, fundamentally)". Is it wrong to use it nonetheless? > > I'd much prefer a longer `font-lock-fontify-diwm` which tries to > reproduce more or less the same behavior as your favorite, but by > explicitly testing the different circumstances you care about. > Could you perhaps give an example of such a circumstance and its corresponding action?