Mode of auto-saved remote files

Mode of auto-saved remote files

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hello,

Auto-saved copies of remote files are created with default permissions
(666 minus umask). By this, sensitive files can be read by other
users.

It comes from the function `auto_save_1' of fileio.c, where the
permissions of the original files are retrieved via `stat', which
isn't possible for remote files.

The following patch avoids this. Are there any objections?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 473 bytes --]

*** fileio.c	02 Oct 2004 16:14:24 +0200	1.515
--- fileio.c	02 Oct 2004 17:01:48 +0200	
***************
*** 5718,5723 ****
--- 5718,5725 ----
        && stat (SDATA (current_buffer->filename), &st) >= 0)
      /* But make sure we can overwrite it later!  */
      auto_save_mode_bits = st.st_mode | 0600;
+   else if (! NILP (current_buffer->filename))
+     auto_save_mode_bits = Ffile_modes (current_buffer->filename) | 0600;
    else
      auto_save_mode_bits = 0666;
  

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Mode of auto-saved remote files

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> *** fileio.c	02 Oct 2004 16:14:24 +0200	1.515
> --- fileio.c	02 Oct 2004 17:01:48 +0200	
> ***************
> *** 5718,5723 ****
> --- 5718,5725 ----
>         && stat (SDATA (current_buffer->filename), &st) >= 0)
>       /* But make sure we can overwrite it later!  */
>       auto_save_mode_bits = st.st_mode | 0600;
> +   else if (! NILP (current_buffer->filename))
> +     auto_save_mode_bits = Ffile_modes (current_buffer->filename) | 0600;

That lacks an XINT.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Mode of auto-saved remote files

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

Andreas Schwab <schwab@suse.de> writes:

> That lacks an XINT.
>
> Andreas.

Indeed. Thanks, and best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 478 bytes --]

*** fileio.c	29 Sep 2004 23:41:54 -0000	1.515
--- fileio.c	2 Oct 2004 16:12:12 -0000
***************
*** 5718,5723 ****
--- 5718,5725 ----
        && stat (SDATA (current_buffer->filename), &st) >= 0)
      /* But make sure we can overwrite it later!  */
      auto_save_mode_bits = st.st_mode | 0600;
+   else if (! NILP (current_buffer->filename))
+     auto_save_mode_bits = XINT (Ffile_modes (current_buffer->filename)) | 0600;
    else
      auto_save_mode_bits = 0666;
  

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Mode of auto-saved remote files

[Richard Stallman]

    Auto-saved copies of remote files are created with default permissions
    (666 minus umask). By this, sensitive files can be read by other
    users.

Please install the corrected version of the patch.

Re: Mode of auto-saved remote files

[Michael Albinus]

Richard Stallman <rms@gnu.org> writes:

> Please install the corrected version of the patch.

done.

Best regards, Michael.