all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: font-lock in machine mode of gdba
Date: Sun, 17 Oct 2004 12:55:41 -0400	[thread overview]
Message-ID: <877jppnv5n.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20041018.002930.45492341.jet@gyve.org> (Masatake YAMATO's message of "Mon, 18 Oct 2004 00:29:30 +0900 (JST)")

> +(defconst gdb-assembler-font-lock-keywords
> +  '(("\\$?0x*[0-9a-f]+" . font-lock-constant-face)
> +    ("<\\([^+>]+\\)\\+[0-9]+>:" 
> +     1 font-lock-function-name-face)
> +    ("%\\sw+" . font-lock-variable-name-face)
> +    ("^\\(Dump of assembler code for function\\) \\(.+\\):" 
> +     (1 font-lock-comment-face)
> +     (2 font-lock-function-name-face))
> +    ("^\\(End of assembler dump\\.\\)" . font-lock-comment-face))
> +    "Font lock keywords used in `gdb-assembler-mode'.")

Seems OK.
 
> +  (unless font-lock-mode (font-lock-mode 1))

This is WRONG.  The user should be able to choose whether he wants font-lock
or not.  He does that using either asm-mode-hook or global-font-lock-mode.


        Stefan

  reply	other threads:[~2004-10-17 16:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-17 15:29 font-lock in machine mode of gdba Masatake YAMATO
2004-10-17 16:55 ` Stefan Monnier [this message]
2004-10-18  2:14   ` Nick Roberts
2004-10-18  2:25 ` Nick Roberts
2004-10-19  2:26   ` Masatake YAMATO
2004-10-19 12:45     ` Stefan Monnier
2004-10-21 10:53       ` Nick Roberts
2004-10-19 13:28     ` Nick Roberts
2004-10-19 13:54       ` Stefan Monnier
2004-10-19 14:27         ` Masatake YAMATO
2004-10-19 16:38       ` Masatake YAMATO
2004-10-23 22:09         ` Nick Roberts
2004-10-23 23:49           ` Masatake YAMATO
2004-10-23 23:59             ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877jppnv5n.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.