From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: lisp/generic.el patch. Date: Tue, 15 Mar 2005 13:53:20 -0500 Message-ID: <877jk8oi9s.fsf-monnier+emacs@gnu.org> References: <87y8co96uz.fsf@xs4all.nl> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1110913228 24992 80.91.229.2 (15 Mar 2005 19:00:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 15 Mar 2005 19:00:28 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 15 20:00:28 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DBHFv-0005xA-9w for ged-emacs-devel@m.gmane.org; Tue, 15 Mar 2005 19:59:03 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DBHVr-00029H-1E for ged-emacs-devel@m.gmane.org; Tue, 15 Mar 2005 14:15:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DBHSc-0000SA-40 for emacs-devel@gnu.org; Tue, 15 Mar 2005 14:12:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DBHSS-0000MZ-3H for emacs-devel@gnu.org; Tue, 15 Mar 2005 14:12:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DBHSR-0000L8-FD for emacs-devel@gnu.org; Tue, 15 Mar 2005 14:11:59 -0500 Original-Received: from [209.226.175.93] (helo=tomts36-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DBHAQ-0000jI-NI for emacs-devel@gnu.org; Tue, 15 Mar 2005 13:53:22 -0500 Original-Received: from alfajor ([67.71.27.21]) by tomts36-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050315185321.XZFJ1694.tomts36-srv.bellnexxia.net@alfajor>; Tue, 15 Mar 2005 13:53:21 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 0E2E6D74A3; Tue, 15 Mar 2005 13:53:21 -0500 (EST) Original-To: Lute Kamstra In-Reply-To: <87y8co96uz.fsf@xs4all.nl> (Lute Kamstra's message of "Tue, 15 Mar 2005 18:06:12 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34616 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34616 > and fixed some minor things along the way. Does anybody see any > problems with this patch? When loading a byte-compiled file that used define-generic-mode, I think you'll get an error that generic-mode-list is not defined (because generic.el doesn't get loaded: the autoload caused generic.el to be loaded during byte-compilation, but it doesn't have any such effect when loading the macro-expanded code). Of course, maybe I'm wrong, I've only superficially looked at the patch. Stefan