From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Sun, 28 May 2006 22:26:43 +0200 Organization: Epita/LRDE Message-ID: <877j45rj3w.fsf@lrde.org> References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0429780761==" X-Trace: sea.gmane.org 1148848000 13534 80.91.229.2 (28 May 2006 20:26:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 28 May 2006 20:26:40 +0000 (UTC) Cc: Agustin Martin , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 28 22:26:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FkRqG-0001HG-Ju for ged-emacs-devel@m.gmane.org; Sun, 28 May 2006 22:26:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FkRqG-0007z9-2T for ged-emacs-devel@m.gmane.org; Sun, 28 May 2006 16:26:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FkRq2-0007xp-Hu for emacs-devel@gnu.org; Sun, 28 May 2006 16:26:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FkRq0-0007ua-LQ for emacs-devel@gnu.org; Sun, 28 May 2006 16:26:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FkRq0-0007uK-G2 for emacs-devel@gnu.org; Sun, 28 May 2006 16:26:12 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FkRvP-0005EL-Uu for emacs-devel@gnu.org; Sun, 28 May 2006 16:31:48 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1FkRpv-0007lF-2S; Sun, 28 May 2006 22:26:07 +0200 Original-To: Stefan Monnier Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEVWPh+Tai+5r5YKBAEU CQQzGAtiq7gjAAACR0lEQVQ4jW2UzW7lIAyFzVW8BzTZX5DmCZLuU2H2pMXv/ypzbK7aSh2kRCRf /HNsE0q7Sg+RQ7JFKaqtrRNAl5AIIKe6D5DBqgbmUAe5hBI1wIRFAHjeM0RKtZi7XVVEpb0BSNfA IddChChT5DildSLWOWhY5IEItMnncZgFcUAc/5jjwCMsDosRNdfKPDTFEdVBW8C+RebDb4N5Orio RhM1+11IJyx0ng2+LryFHBMPDQDYHrY6IfGuU3ouiXTQNE8LIJDKOWpNxERTFrggQwRPd7USUsTW fJ0XbR3bdj5KgBYy4SACpxDeUYEUAzLmtJ1iIrD2gczPq8Qomjhsh/RjGIgKIO8p7NITjwlx7WID nsnQe5NeuTvoBpi8LX6vLLOh5icjOHqBypgnuSp7M+RE1agbQKHQr5E2z1WObhYW4gMqeGQL7joM jCf2DxSk5ApADSYHfFF4igNfJZL1z0GKP0FN02s4XiDXr7V5P94W6I9v8MfBOQDmfwAaVYt+x8Da v4DJvX8BAdin3Knm5yMZYAO4ABDkDniZLLfi4P40gP1F0TPGZOu0CGwA1lcowxwlGy6A9705mD0V jHCxwVZT/hYdRJVUGZNlx6l7ScQBTluof6Wj6bsPYlvpwoTvXFD9gHPn2TZPF3ntI2ecxVrW5MrV XiCie5EeNa7BlWu/HNSkprDUva163PHxAv5jyGV7gVzyAghSKOTnat85UIYFICXbD2NV9rRiv0BS tKQsg6OHH4A15F1WW+UHKHHa32h6aPnAm3/pUcWp+WYnTQAAAABJRU5ErkJggg== In-Reply-To: (Stefan Monnier's message of "Sun, 28 May 2006 15:48:55 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55381 Archived-At: --===============0429780761== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >>>> Error in post-command-hook: (wrong-type-argument listp (nil DEAD . 187= 64377)) >>>=20 >>> Oh yes, the live_deleted_processes variable needs to be gcpro'd. > >> I'm not familiar with Emacs C code, so I don't know how to proceed. >> Can you send a patch, or at least, the lines that have to be modified, >> and how ? > > Add something like > > staticpro (&live_deleted_processes); > > in syms_of_process Works fine! I used two tests: 1) (original test) Quick switching between two flyspellized buffers that have different dictionaries, 2)=20 (let (processes) (dotimes (i 100) (push (start-process "bug" nil "/tmp/sleep") processes)) (dotimes (i 50) (if (zerop (mod i 2)) (delete-process (pop processes)) (kill-process (pop processes)))) (message "%S" (call-process "/tmp/sleep")) (dotimes (i 50) (delete-process (pop processes))) (message "%S" (call-process "/tmp/sleep"))) None of them succeeded before, but now it's OK. (Final ?) patch attached. Agustin, can you check that you can't trigger the bug anymore? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=process.patch Content-Transfer-Encoding: quoted-printable Index: src/process.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/process.c,v retrieving revision 1.481 diff -c -r1.481 process.c *** src/process.c 8 May 2006 05:19:42 -0000 1.481 =2D-- src/process.c 28 May 2006 20:24:11 -0000 *************** *** 778,783 **** =2D-- 778,792 ---- return proc; } =20=20 +=20 + /* Fdelete_process promises to immediately forget about the process, but = in + reality, Emacs needs to remember those processes until they have been + treated by sigchld_handler; otherwise this handler would consider the + process as being synchronous and say that the synchronous process is + dead. */ + static Lisp_Object deleted_pid_list; +=20 +=20 DEFUN ("delete-process", Fdelete_process, Sdelete_process, 1, 1, 0, doc: /* Delete PROCESS: kill it and forget about it immediately. PROCESS may be a process, a buffer, the name of a process or buffer, or *************** *** 800,805 **** =2D-- 809,818 ---- else if (XINT (p->infd) >=3D 0) { Fkill_process (process, Qnil); + /* No problem storing the pid here, as it is still in Vprocess_alis= t. */ + deleted_pid_list =3D Fcons (make_fixnum_or_float (p->pid), + /* GC treated elements set to nil. */ + Fdelq (Qnil, deleted_pid_list)); /* Do this now, since remove_process will make sigchld_handler do n= othing. */ p->status =3D Fcons (Qsignal, Fcons (make_number (SIGKILL), Qnil)); *************** *** 6373,6378 **** =2D-- 6386,6400 ---- =20=20 /* Find the process that signaled us, and record its status. */ =20=20 + /* The process can have been deleted by Fdelete_process. */ + tail =3D Fmember (make_fixnum_or_float (pid), deleted_pid_list); + if (!NILP (tail)) + { + Fsetcar (tail, Qnil); + goto sigchld_end_of_loop; + } +=20 + /* Otherwise, if it is asynchronous, it is in Vprocess_alist. */ p =3D 0; for (tail =3D Vprocess_alist; GC_CONSP (tail); tail =3D XCDR (tail)) { *************** *** 6424,6431 **** EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 ! /* There was no asynchronous process found for that id. Check ! if we have a synchronous process. */ else { synch_process_alive =3D 0; =2D-- 6446,6453 ---- EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 ! /* There was no asynchronous process found for that pid: we have ! a synchronous process. */ else { synch_process_alive =3D 0; *************** *** 6442,6447 **** =2D-- 6464,6473 ---- EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0); } =20=20 +=20 + sigchld_end_of_loop: + ; +=20 /* On some systems, we must return right away. If any more processes want to signal us, we will get another signal. *************** *** 6843,6848 **** =2D-- 6869,6875 ---- FD_SET (0, &input_wait_mask); =20=20 Vprocess_alist =3D Qnil; + deleted_pid_list =3D Qnil; for (i =3D 0; i < MAXDESC; i++) { chan_process[i] =3D Qnil; *************** *** 6981,6986 **** =2D-- 7008,7014 ---- staticpro (&Qlast_nonmenu_event); =20=20 staticpro (&Vprocess_alist); + staticpro (&deleted_pid_list); =20=20 DEFVAR_BOOL ("delete-exited-processes", &delete_exited_processes, doc: /* *Non-nil means delete processes immediately when they exi= t. --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable =2D-=20 | Micha=EBl `Micha' Cadilhac | Would someone please DTRT with thi= s | | Epita/LRDE Promo 2007 | then ACK? = | | http://www.lrde.org/~cadilh_m | -- Richard Stallman = | `-- - JID: micha@amessage.be --' - -= -' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEegeEZYNf4qobZ7kRAn+FAKCfbcvs0TcCei86FvixVlnXJF5pqQCeOxXM ksalrh/9IZYn3Mz7yuD1uss= =ocgq -----END PGP SIGNATURE----- --==-=-=-- --===============0429780761== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============0429780761==--