From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.devel Subject: Re: C-x v v no longer works the way it used to Date: Sat, 20 Oct 2007 18:56:02 +0200 Message-ID: <877ilhiv31.fsf@rho.meyering.net> References: <87r6jxctcv.fsf@rho.meyering.net> <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192899380 2026 80.91.229.12 (20 Oct 2007 16:56:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2007 16:56:20 +0000 (UTC) Cc: "Eric S. Raymond" , Stefan Monnier , Emacs development discussions To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 20 18:56:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IjHcX-0005VH-2v for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 18:56:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjHcP-0007Jk-PD for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 12:56:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjHcM-0007J5-7A for emacs-devel@gnu.org; Sat, 20 Oct 2007 12:56:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjHcJ-0007I7-OG for emacs-devel@gnu.org; Sat, 20 Oct 2007 12:56:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjHcJ-0007I2-EL for emacs-devel@gnu.org; Sat, 20 Oct 2007 12:56:03 -0400 Original-Received: from smtp3-g19.free.fr ([212.27.42.29]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IjHcJ-0003ts-6t for emacs-devel@gnu.org; Sat, 20 Oct 2007 12:56:03 -0400 Original-Received: from smtp3-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp3-g19.free.fr (Postfix) with ESMTP id 6164E17B57A for ; Sat, 20 Oct 2007 18:56:02 +0200 (CEST) Original-Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp3-g19.free.fr (Postfix) with ESMTP id 4B5C417B56B for ; Sat, 20 Oct 2007 18:56:02 +0200 (CEST) Original-Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 21D4E35D5E; Sat, 20 Oct 2007 18:56:02 +0200 (CEST) In-Reply-To: <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 19 Oct 2007 16:21:31 -0700") Original-Lines: 43 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81307 Archived-At: Dan Nicolaescu wrote: > Stefan Monnier writes: > > > > Before the recent vc changes, in a version-controlled directory, > > > if I were visiting a non-version-controlled file and hit C-x v v, > > > it would effectively add that single file to the version control > > > system. i.e., cvs add, git add, etc. > > > > > Now, all it does is print "No fileset is available here." > > > > > Is this intentional? > > > > It's a bug. > > This patch fixes it. > vc-next-action still has the logic to deal with unregistered files, > but vc-deduce-fileset would not return one... > This patch is technically incorrect because it changes > vc-deduce-fileset to not do what it's docs says it has to do. > Not sure how the new VC design is supposed to work to fix it > properly... > > Index: vc.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v > retrieving revision 1.473 > diff -c -3 -p -c -r1.473 vc.el > *** vc.el 19 Oct 2007 20:59:49 -0000 1.473 > --- vc.el 19 Oct 2007 22:47:56 -0000 > *************** Otherwise, throw an error." > *** 1283,1288 **** > --- 1282,1288 ---- > (message "All version-controlled files below %s selected." > default-directory) > (list default-directory))) > + ((not (vc-registered buffer-file-name)) (list buffer-file-name)) > (t (error "No fileset is available here.")))) Thanks! Works for me, though I'd rather it not prompt with "Initial revision level for FILE_NAME: " BTW, your patch didn't apply, so I applied it manually.