From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: about remember.el Date: Thu, 01 Nov 2007 20:25:26 +0000 Message-ID: <877il11znt.fsf@bzg.ath.cx> References: <200710312115.l9VLFU8k010272@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1193945183 13863 80.91.229.12 (1 Nov 2007 19:26:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2007 19:26:23 +0000 (UTC) Cc: Leo , Carsten Dominik To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 01 20:26:25 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1InfgN-0006Nn-Rp for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2007 20:26:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1InfgD-0003y0-UT for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2007 15:26:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Inffq-0003mV-FL for emacs-devel@gnu.org; Thu, 01 Nov 2007 15:25:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Inffo-0003kc-6J for emacs-devel@gnu.org; Thu, 01 Nov 2007 15:25:49 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Inffo-0003kU-3w for emacs-devel@gnu.org; Thu, 01 Nov 2007 15:25:48 -0400 Original-Received: from nf-out-0910.google.com ([64.233.182.191]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Inffn-0007KV-SC for emacs-devel@gnu.org; Thu, 01 Nov 2007 15:25:48 -0400 Original-Received: by nf-out-0910.google.com with SMTP id f5so683982nfh for ; Thu, 01 Nov 2007 12:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=4FSx84To8fTScJlhlldeJGUFLiODbd9vNbbFH6ddvl8=; b=FFVjVRVdqzl5t2CaV4VOjh3rBN8oEbR7U0VW0AoYD0hCWim5UyTx0YyPnAD17uuC/95DAar/i8TujU28ihR9QXb4sLjFHVPD0IWGi7bhLGWMnYddOAUDOqf3L4u+YnKM9ijD1X2GCCDaDeMIQ+Rhg8NshyCFPoXCyVjNF3QXaDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=OVokH5Y+FWFlG2lIvLsTICdMoiQLZ92lhBuXF+KIEzxILhWyCnarNxSi9+/xwRrZeFmZijVIX5p24qbIRcEboHIuRmG1bp4KKOydugSdwFvJkj9fL8NYBHAlu35ROhniC/ZMhSj7WHzEL4Td+KUZ/wxdNROiUdLID0LfFs3Bq0E= Original-Received: by 10.78.137.7 with SMTP id k7mr738852hud.1193945143692; Thu, 01 Nov 2007 12:25:43 -0700 (PDT) Original-Received: from bzg.ath.cx ( [129.199.12.108]) by mx.google.com with ESMTPS id e8sm4919898muf.2007.11.01.12.25.39 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Nov 2007 12:25:40 -0700 (PDT) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id 802E91575BA; Thu, 1 Nov 2007 20:25:26 +0000 (GMT) In-Reply-To: <200710312115.l9VLFU8k010272@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 31 Oct 2007 14:15:25 -0700") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.0 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82311 Archived-At: --=-=-= Dan Nicolaescu writes: > `remember-buffer' also seems that is not needed, > C-x h M-x remeber-region RET > should do the same thing. So remember.el is now in Emacs CVS. Great! The function `remember-buffer' has been renamed to `remember-finalize'. We need to update org.el accordingly. This patch against org.el in CVS does the job: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=org.el.patch diff -u /home/guerry/install/cvs/emacs/lisp/textmodes/org.el /home/guerry/elisp/testing/emacs/org.el --- /home/guerry/install/cvs/emacs/lisp/textmodes/org.el 2007-10-26 11:33:11.000000000 +0100 +++ /home/guerry/elisp/testing/emacs/org.el 2007-11-01 20:15:55.000000000 +0000 @@ -12815,7 +12815,7 @@ (replace-match x t t)))) ;; Turn on org-mode in the remember buffer, set local variables (org-mode) - (org-set-local 'org-finish-function 'remember-buffer) + (org-set-local 'org-finish-function 'remember-finalize) (if (and file (string-match "\\S-" file) (not (file-directory-p file))) (org-set-local 'org-default-notes-file file)) (if (and headline (stringp headline) (string-match "\\S-" headline)) @@ -12859,7 +12859,7 @@ (replace-match "") (and (re-search-forward "^[^#\n]" nil t) (backward-char 1)))) (org-mode) - (org-set-local 'org-finish-function 'remember-buffer))) + (org-set-local 'org-finish-function 'remember-finalize))) ;;;###autoload (defun org-remember (&optional org-force-remember-template-char) @@ -12867,7 +12867,7 @@ If there is an active region, make sure remember uses it as initial content of the remember buffer." (interactive) - (if (eq org-finish-function 'remember-buffer) + (if (eq org-finish-function 'remember-finalize) (progn (when (< (length org-remember-templates) 2) (error "No other template available")) Diff finished. Thu Nov 1 20:16:01 2007 --=-=-= BTW, it is surely better not to autoload this function, but we also need to check the documentation and usual configuration of remember's friends like Org and Planner. -- Bastien --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--