From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar and multi-tty Date: Sat, 11 Oct 2008 15:49:26 -0400 Message-ID: <877i8edi9l.fsf@cyd.mit.edu> References: <873aj56v2p.fsf@cyd.mit.edu> <87prm8fkjn.fsf@cyd.mit.edu> <873aj48cd9.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223754465 4964 80.91.229.12 (11 Oct 2008 19:47:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 Oct 2008 19:47:45 +0000 (UTC) Cc: Eli Zaretskii , dann@ics.uci.edu, 1133@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 11 21:48:43 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KokS9-0000K9-CW for ged-emacs-devel@m.gmane.org; Sat, 11 Oct 2008 21:48:41 +0200 Original-Received: from localhost ([127.0.0.1]:35211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KokR5-0002sz-7s for ged-emacs-devel@m.gmane.org; Sat, 11 Oct 2008 15:47:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KokR1-0002su-TS for emacs-devel@gnu.org; Sat, 11 Oct 2008 15:47:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KokQz-0002si-Gk for emacs-devel@gnu.org; Sat, 11 Oct 2008 15:47:30 -0400 Original-Received: from [199.232.76.173] (port=36219 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KokQz-0002sf-C1 for emacs-devel@gnu.org; Sat, 11 Oct 2008 15:47:29 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:56098) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KokQx-0001yu-Oc; Sat, 11 Oct 2008 15:47:27 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 33D6257E0BD; Sat, 11 Oct 2008 15:49:26 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sat, 11 Oct 2008 12:28:06 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104478 Archived-At: Stefan Monnier writes: >> (image-exp `(tool-bar-find-image >> (if (display-color-p) >> ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec) >> ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)))) > >> Calling tool-bar-local-item-from-menu from the tty loads the lo-spec >> images, whereas deferring this call until X is started up loads the >> hi-spec images. But deferring the call, as I suggested, doesn't seem to >> be satisfactory either. > > Why? The `if' is left unevaluated in the image-exp. So IIUC it's only > be evaluated later when the image is actually displayed. Aha: the number of display colors is checked earlier in the function. If we put that check into the image expression instead, everything works. I've just checked in a fix into CVS. I think this should resolve the problems between multi-tty and tool bars.