bug#616: 23.0.60; Emacs.app does not support SVG file type

bug#616: 23.0.60; Emacs.app does not support SVG file type

[Peter Dyballa]

Hello!

The value of image-types ist just (png gif tiff jpeg xpm xbm pbm).  
The X client supports to view: (svg png gif tiff jpeg xpm postscript  
xbm pbm).



In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0)
  of 2008-07-26 on Latsche.local
Windowing system distributor `Apple', version 49.46.48
configured using `configure  '--with-ns' '--disable-ns-self- 
contained' '--without-sound' '--without-pop' '--with-dbus' '--enable- 
locallisppath=/Library/Application Support/Emacs/calendar23:/Library/ 
Application Support/Emacs/caml:/Library/Application Support/Emacs:/sw/ 
share/emacs21/site-lisp/elib' 'PKG_CONFIG_PATH=/sw/lib/pkgconfig:/sw/ 
share/pkgconfig:/usr/lib/pkgconfig:/usr/local/lib/pkgconfig:/usr/ 
X11R6/lib/pkgconfig' 'CFLAGS=-Wno-pointer-sign -bind_at_load -pipe - 
fPIC -mcpu=7450 -mtune=7450 -fast -mpim-altivec -ftree-vectorize - 
foptimize-register-move -freorder-blocks -freorder-blocks-and- 
partition -fthread-jumps -fpeephole -fno-crossjumping' 'CPPFLAGS=-no- 
cpp-precomp' 'LDFLAGS=-bind_at_load -dead_strip -multiply_defined  
suppress -L/sw/lib/ncurses''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   value of $XMODIFIERS: nil
   locale-coding-system: utf-8-unix
   default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
   show-paren-mode: t
   display-time-mode: t
   tooltip-mode: t
   tool-bar-mode: t
   mouse-wheel-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t
--
Mit friedvollen Grüßen

   Pete

There's no sense in being precise when you don't even know what  
you're talking about.
				– John von Neumann

bug#616: 23.0.60; Emacs.app does not support SVG file type

[Yavor Doganov]

At Sun, 27 Jul 2008 12:36:30 +0200,
Peter Dyballa wrote:
> 
> The value of image-types ist just (png gif tiff jpeg xpm xbm pbm).  

I've been using the attached patch on GNUstep for some time, with no
apparent ill effects.  The only problem is that transparent images
(like splash.svg, gnus.svg, etc.) get rendered on a black backround.

If I set the Emacs background to black, they look transparent but
that's of course an illusion.  I tried several approaches to make it
work, but did not succeed.  I hope that someone else does.


2008-11-12  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Check for librsvg2 under NS as well.

2008-11-12  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* image.c (svg_load_image): Add support for NS.

Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.572
diff -u -u -r1.572 configure.in
--- configure.in        24 Oct 2008 07:22:35 -0000      1.572
+++ configure.in        24 Oct 2008 18:12:31 -0000
@@ -1491,7 +1491,7 @@
 
 ### Use -lrsvg-2 if available, unless `--with-rsvg=no' is specified.
 HAVE_RSVG=no
-if test "${HAVE_X11}" = "yes"; then
+if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
   if test "${with_rsvg}" != "no"; then
     RSVG_REQUIRED=2.0.0
     RSVG_MODULE="librsvg-2.0 >= $RSVG_REQUIRED"

Index: src/image.c
===================================================================
RCS file: /sources/emacs/emacs/src/image.c,v
retrieving revision 1.114
diff -u -u -r1.114 image.c
--- src/image.c 3 Oct 2008 18:23:43 -0000       1.114
+++ src/image.c 24 Oct 2008 18:12:49 -0000
@@ -8127,6 +8127,11 @@
       background.red   >>= 8;
       background.green >>= 8;
       background.blue  >>= 8;
+#elif defined (HAVE_NS)
+      background.pixel = FRAME_BACKGROUND_PIXEL (f);
+      background.red   = RED_FROM_ULONG (background.pixel);
+      background.green = GREEN_FROM_ULONG (background.pixel);
+      background.blue  = BLUE_FROM_ULONG (background.pixel);
 #else /* not HAVE_X_WINDOWS*/
 #error FIXME
 #endif
@@ -8174,9 +8179,11 @@
   img->width  = width;
   img->height = height;
 
+#ifndef HAVE_NS
   /* Maybe fill in the background field while we have ximg handy.
      Casting avoids a GCC warning.  */
   IMAGE_BACKGROUND (img, f, (XImagePtr_or_DC)ximg);
+#endif
 
   /* Put the image into the pixmap, then free the X image and its
      buffer.  */

bug#616: marked as done (23.0.60; Emacs.app does not support SVG file type)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]


Your message dated Thu, 22 Jan 2009 15:17:57 +0200
with message-id <EFD08B41-FD7B-4EE5-A1F4-F158B51E02E8@gmail.com>
and subject line Re: 23.0.60; Emacs.app does not support SVG file type
has caused the Emacs bug report #616,
regarding 23.0.60; Emacs.app does not support SVG file type
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
616: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=616
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4394 bytes --]

From: Peter Dyballa <Peter_Dyballa@Freenet.DE>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Emacs.app does not support SVG file type
Date: Sun, 27 Jul 2008 12:36:30 +0200
Message-ID: <4640F8E3-3ADF-453C-BC89-B6E747AC1A7E@Freenet.DE>

Hello!

The value of image-types ist just (png gif tiff jpeg xpm xbm pbm).  
The X client supports to view: (svg png gif tiff jpeg xpm postscript  
xbm pbm).



In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0)
  of 2008-07-26 on Latsche.local
Windowing system distributor `Apple', version 49.46.48
configured using `configure  '--with-ns' '--disable-ns-self- 
contained' '--without-sound' '--without-pop' '--with-dbus' '--enable- 
locallisppath=/Library/Application Support/Emacs/calendar23:/Library/ 
Application Support/Emacs/caml:/Library/Application Support/Emacs:/sw/ 
share/emacs21/site-lisp/elib' 'PKG_CONFIG_PATH=/sw/lib/pkgconfig:/sw/ 
share/pkgconfig:/usr/lib/pkgconfig:/usr/local/lib/pkgconfig:/usr/ 
X11R6/lib/pkgconfig' 'CFLAGS=-Wno-pointer-sign -bind_at_load -pipe - 
fPIC -mcpu=7450 -mtune=7450 -fast -mpim-altivec -ftree-vectorize - 
foptimize-register-move -freorder-blocks -freorder-blocks-and- 
partition -fthread-jumps -fpeephole -fno-crossjumping' 'CPPFLAGS=-no- 
cpp-precomp' 'LDFLAGS=-bind_at_load -dead_strip -multiply_defined  
suppress -L/sw/lib/ncurses''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   value of $XMODIFIERS: nil
   locale-coding-system: utf-8-unix
   default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
   show-paren-mode: t
   display-time-mode: t
   tooltip-mode: t
   tool-bar-mode: t
   mouse-wheel-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t
--
Mit friedvollen Grüßen

   Pete

There's no sense in being precise when you don't even know what  
you're talking about.
				– John von Neumann






[-- Attachment #3: Type: message/rfc822, Size: 2916 bytes --]

From: Adrian Robert <adrian.b.robert@gmail.com>
To: 616-done@emacsbugs.donarmstrong.com
Cc: Yavor Doganov <yavor@gnu.org>
Subject: Re: 23.0.60; Emacs.app does not support SVG file type
Date: Thu, 22 Jan 2009 15:17:57 +0200
Message-ID: <EFD08B41-FD7B-4EE5-A1F4-F158B51E02E8@gmail.com>

I committed the configure.in part of the patch only, 2009/01/22.   
(And I can't regenerate configure due to having autoconf only=  
2.59.)  The code in image.c handling background appears to have  
changed.  If there is still a problem when testing this, please  
either apply an updated version of the image.c portion of the patch  
or open a new bug report.

(Closing)