bug#3158: 23.0.92; assertion failure in fontset_find_font

bug#3158: 23.0.92; assertion failure in fontset_find_font

[Chong Yidong]

>   1. Compile Emacs with "make CFLAGS='-g -DENABLE_CHECKING'"
>   2. emacs -Q
>   3. M-x list-charset-chars RET mac-roman RET
>
>   .../src/fontset.c:551: Emacs fatal error: assertion failed:
>   VECTORLIKEP((rfont_def))
>
> The value of rfont_def is nil when this failure happens.

I think the relevant code in fontset_find_font needs to check when
rfont_def is nil, and ignore those values.  Handa-san, could you verify?

bug#3158: 23.0.92; assertion failure in fontset_find_font

[YAMAMOTO Mitsuharu]

Steps to reproduce:

  1. Compile Emacs with "make CFLAGS='-g -DENABLE_CHECKING'"
  2. emacs -Q
  3. M-x list-charset-chars RET mac-roman RET

Result:

  .../src/fontset.c:551: Emacs fatal error: assertion failed: VECTORLIKEP((rfont_def))

The value of rfont_def is nil when this failure happens.

#3  0x00241da4 in fontset_find_font (fontset=17297828, c=57374, face=0x1054820, id=147, fallback=0) at .../src/fontset.c:551
551		      = FONT_DEF_REPERTORY (RFONT_DEF_FONT_DEF (rfont_def));
(gdb) list
546		   first.  */
547		for (i = 0; i < ASIZE (vec); i++)
548		  {
549		    Lisp_Object rfont_def = AREF (vec, i);
550		    Lisp_Object repertory
551		      = FONT_DEF_REPERTORY (RFONT_DEF_FONT_DEF (rfont_def));
552	
553		    if (XINT (repertory) == id)
554		      {
555			charset_matched = i;
(gdb) call debug_print (rfont_def)
nil
(gdb) call debug_print (vec)
[[nil [#<font-spec nil nil nil nil iso10646-1 nil nil nil nil nil nil nil nil> 142 nil] nil 0] nil]
(gdb) p i
$1 = 1

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

In GNU Emacs 23.0.92.1 (powerpc-apple-darwin9.6.0, X toolkit)
 of 2009-04-29 on yamamoto-mitsuharu-no-power-mac-g5.local
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--without-jpeg' '--without-gif' '--without-tiff''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

bug#3158: marked as done (23.0.92; assertion failure in fontset_find_font)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]


Your message dated Thu, 30 Apr 2009 13:52:19 +0900
with message-id <E1LzOFv-0005Cv-Id@etlken>
and subject line Re: 23.0.92; assertion failure in fontset_find_font
has caused the Emacs bug report #3158,
regarding 23.0.92; assertion failure in fontset_find_font
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3158: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3158
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4264 bytes --]

From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.92; assertion failure in fontset_find_font
Date: Wed, 29 Apr 2009 10:58:04 +0900
Message-ID: <wlmya0mdar.wl%mituharu@math.s.chiba-u.ac.jp>

Steps to reproduce:

  1. Compile Emacs with "make CFLAGS='-g -DENABLE_CHECKING'"
  2. emacs -Q
  3. M-x list-charset-chars RET mac-roman RET

Result:

  .../src/fontset.c:551: Emacs fatal error: assertion failed: VECTORLIKEP((rfont_def))

The value of rfont_def is nil when this failure happens.

#3  0x00241da4 in fontset_find_font (fontset=17297828, c=57374, face=0x1054820, id=147, fallback=0) at .../src/fontset.c:551
551		      = FONT_DEF_REPERTORY (RFONT_DEF_FONT_DEF (rfont_def));
(gdb) list
546		   first.  */
547		for (i = 0; i < ASIZE (vec); i++)
548		  {
549		    Lisp_Object rfont_def = AREF (vec, i);
550		    Lisp_Object repertory
551		      = FONT_DEF_REPERTORY (RFONT_DEF_FONT_DEF (rfont_def));
552	
553		    if (XINT (repertory) == id)
554		      {
555			charset_matched = i;
(gdb) call debug_print (rfont_def)
nil
(gdb) call debug_print (vec)
[[nil [#<font-spec nil nil nil nil iso10646-1 nil nil nil nil nil nil nil nil> 142 nil] nil 0] nil]
(gdb) p i
$1 = 1

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

In GNU Emacs 23.0.92.1 (powerpc-apple-darwin9.6.0, X toolkit)
 of 2009-04-29 on yamamoto-mitsuharu-no-power-mac-g5.local
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--without-jpeg' '--without-gif' '--without-tiff''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t



[-- Attachment #3: Type: message/rfc822, Size: 2404 bytes --]

From: Kenichi Handa <handa@m17n.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: mituharu@math.s.chiba-u.ac.jp, 3158-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.92; assertion failure in fontset_find_font
Date: Thu, 30 Apr 2009 13:52:19 +0900
Message-ID: <E1LzOFv-0005Cv-Id@etlken>

In article <877i12hm3e.fsf@cyd.mit.edu>, Chong Yidong <cyd@stupidchicken.com> writes:

> >   1. Compile Emacs with "make CFLAGS='-g -DENABLE_CHECKING'"
> >   2. emacs -Q
> >   3. M-x list-charset-chars RET mac-roman RET
> >
> >   .../src/fontset.c:551: Emacs fatal error: assertion failed:
> >   VECTORLIKEP((rfont_def))
> >
> > The value of rfont_def is nil when this failure happens.

> I think the relevant code in fontset_find_font needs to check when
> rfont_def is nil, and ignore those values.  Handa-san, could you verify?

I fixed it by breaking the loop instead of ignoring that
element because rfont_def nil means "don't try the remaining
fonts and the fallback fonts".

---
Kenichi Handa
handa@m17n.org

bug#3158: 23.0.92; assertion failure in fontset_find_font

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 30 Apr 2009 13:52:19 +0900, Kenichi Handa <handa@m17n.org> said:

>> >   1. Compile Emacs with "make CFLAGS='-g -DENABLE_CHECKING'"
>> >   2. emacs -Q
>> >   3. M-x list-charset-chars RET mac-roman RET
>> >
>> >   .../src/fontset.c:551: Emacs fatal error: assertion failed:
>> >   VECTORLIKEP((rfont_def))
>> >
>> > The value of rfont_def is nil when this failure happens.

>> I think the relevant code in fontset_find_font needs to check when
>> rfont_def is nil, and ignore those values.  Handa-san, could you verify?

> I fixed it by breaking the loop instead of ignoring that
> element because rfont_def nil means "don't try the remaining
> fonts and the fallback fonts".

I still have an assertion violation with the above procedure at a
different line:

...src/fontset.c:634: Emacs fatal error: assertion failed: VECTORLIKEP((rfont_def))

#3  0x0024256c in fontset_find_font (fontset=17306132, c=57374, face=0x10877e0, id=147, fallback=0) at /Users/mituharu/src/cvs/emacs-23/emacs/src/fontset.c:634
634		  if (! EQ (RFONT_DEF_FONT_DEF (rfont_def), font_def))
(gdb) list
629		 and supporting C. */
630	      font_def = RFONT_DEF_FONT_DEF (rfont_def);
631	      for (i++; i < ASIZE (vec); i++)
632		{
633		  rfont_def = AREF (vec, i);
634		  if (! EQ (RFONT_DEF_FONT_DEF (rfont_def), font_def))
635		    break;
636		  font_object = RFONT_DEF_OBJECT (AREF (vec, i));
637		  if (! NILP (font_object) && font_has_char (f, font_object, c))
638		    return rfont_def;
(gdb) call debug_print (rfont_def)
nil
(gdb) call debug_print (vec)
[[nil [#<font-spec nil nil nil nil iso10646-1 nil nil nil nil nil nil nil nil> 142 nil] #<font-object "-bitstream-Bitstream Vera Sans Mono-normal-normal-normal-*-12-*-*-*-m-0-iso10646-1"> 0] nil]
(gdb) p i
$1 = 1

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#3158: 23.0.92; assertion failure in fontset_find_font

[Kenichi Handa]

In article <wlljpiu1nm.wl%mituharu@math.s.chiba-u.ac.jp>, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

> I still have an assertion violation with the above procedure at a
> different line:

> ...src/fontset.c:634: Emacs fatal error: assertion failed: VECTORLIKEP((rfont_def))

Oops, I've just fixed it.

---
Kenichi Handa
handa@m17n.org

bug#3158: 23.0.92; assertion failure in fontset_find_font

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 30 Apr 2009 16:06:43 +0900, Kenichi Handa <handa@m17n.org> said:

>> I still have an assertion violation with the above procedure at a
>> different line:

>> ...src/fontset.c:634: Emacs fatal error: assertion failed:
>> VECTORLIKEP((rfont_def))

> Oops, I've just fixed it.

Thanks.  The assertion failures are fixed.

But I noticed that M-x list-charset-chars RET mac-roman RET that
caused the failures doesn't display the Apple logo (mac-roman 0xF0)
because Apple maps it to U+F8FF and glibc localedata to U+E01E.  I'm
not sure if this can be classified as a bug.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp