all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bastien <bastienguerry@googlemail.com>
To: emacs-devel@gnu.org
Subject: Improve the docstring of case-fold-search
Date: Wed, 22 Jul 2009 04:17:10 +0200	[thread overview]
Message-ID: <877hy1ea1l.fsf@bzg.ath.cx> (raw)

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

I suggest to complete the docstring of `case-fold-search' like the
attached patch does.

In the current docstring, the expression "ignore case" is not really
appropriate because the search will not ignore uppercase characters in
the search string.  A very short way to tell this would be "*Non-nil if
searches and matches should ignore lowercase."  But while accurate, this
is confusing IMO.  Hence the long sentence in this patch, inspired by
the "Search case" section of Emacs manual.

Should I apply it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: buffer.c.patch --]
[-- Type: text/x-diff, Size: 571 bytes --]

--- buffer.c.~1.583.~	2009-07-17 21:12:21.000000000 +0200
+++ buffer.c	2009-07-22 03:55:26.000000000 +0200
@@ -5727,7 +5727,9 @@
 
   DEFVAR_PER_BUFFER ("case-fold-search", &current_buffer->case_fold_search,
 		     Qnil,
-		     doc: /* *Non-nil if searches and matches should ignore case.  */);
+		     doc: /* *Non-nil if searches and matches should ignore case.
+If there is an uppercase character in the search string
+then the search becomes case sensitive.  */);
 
   DEFVAR_PER_BUFFER ("fill-column", &current_buffer->fill_column,
 		     make_number (Lisp_Int),

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

             reply	other threads:[~2009-07-22  2:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  2:17 Bastien [this message]
2009-07-22  3:11 ` Improve the docstring of case-fold-search Eli Zaretskii
2009-07-22  3:38 ` Stefan Monnier
2009-07-22  8:11   ` Bastien
2009-07-27  2:42   ` Bastien
2009-07-27 17:27     ` Stefan Monnier
2009-07-27 21:01       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hy1ea1l.fsf@bzg.ath.cx \
    --to=bastienguerry@googlemail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.