From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#6222: Shouldn't f1 in isearch-mode be help? Date: Thu, 20 May 2010 03:38:57 +0300 Organization: JURTA Message-ID: <877hmz5rn6.fsf@mail.jurta.org> References: <87sk5n77bf.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1274317121 7921 80.91.229.12 (20 May 2010 00:58:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 20 May 2010 00:58:41 +0000 (UTC) Cc: 6222@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 20 02:58:40 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OEu5u-0001Ye-1c for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 May 2010 02:58:38 +0200 Original-Received: from localhost ([127.0.0.1]:51214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEu5t-0001Sk-IL for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 May 2010 20:58:37 -0400 Original-Received: from [140.186.70.92] (port=60249 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEu4U-0000YF-8p for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:57:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEu4Q-00049k-7T for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:57:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53950) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEu4P-00049a-T8 for bug-gnu-emacs@gnu.org; Wed, 19 May 2010 20:57:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OEtth-0007r7-JJ; Wed, 19 May 2010 20:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2010 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6222 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6222-submit@debbugs.gnu.org id=B6222.127431633530186 (code B ref 6222); Thu, 20 May 2010 00:46:01 +0000 Original-Received: (at 6222) by debbugs.gnu.org; 20 May 2010 00:45:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEttG-0007qp-SN for submit@debbugs.gnu.org; Wed, 19 May 2010 20:45:35 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEttE-0007qj-5s for 6222@debbugs.gnu.org; Wed, 19 May 2010 20:45:33 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.95.74.cable.starman.ee [82.131.95.74]) by mx2.starman.ee (Postfix) with ESMTP id F3DA83F4146; Thu, 20 May 2010 03:45:24 +0300 (EEST) In-Reply-To: (Lennart Borgman's message of "Thu, 20 May 2010 02:31:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 19 May 2010 20:46:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37073 Archived-At: >> (define-key global-map (char-to-string help-char) 'help-command) >> (define-key global-map [help] 'help-command) >> (define-key global-map [f1] 'help-command) > > Thanks, I see. But shouldn't isearch do the same then? I agree that it should: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2010-04-16 01:30:37 +0000 +++ lisp/isearch.el 2010-05-20 00:38:21 +0000 @@ -461,6 +461,9 @@ (defvar isearch-mode-map (define-key map "\C-y" 'isearch-yank-line) (define-key map "\C-h" isearch-help-map) + (define-key map (char-to-string help-char) isearch-help-map) + (define-key map [help] isearch-help-map) + (define-key map [f1] isearch-help-map) (define-key map "\M-n" 'isearch-ring-advance) (define-key map "\M-p" 'isearch-ring-retreat) > What about having a function in help.el for defining a binding for all > three possibilities? Something like > > (defun help-define-help-keys (map command) > (define-key map (char-to-string help-char) command) > (define-key map [help] command) > (define-key map [f1] command)) I'd rather remap all them to one key. -- Juri Linkov http://www.jurta.org/emacs/