bug#6222: Shouldn't f1 in isearch-mode be help?

[Juri Linkov <juri@jurta.org>]

>>    (define-key global-map (char-to-string help-char) 'help-command)
>>    (define-key global-map [help] 'help-command)
>>    (define-key global-map [f1] 'help-command)
>
> Thanks, I see. But shouldn't isearch do the same then?

I agree that it should:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:38:21 +0000
@@ -461,6 +461,9 @@ (defvar isearch-mode-map
     (define-key map    "\C-y" 'isearch-yank-line)
 
     (define-key map "\C-h" isearch-help-map)
+    (define-key map (char-to-string help-char) isearch-help-map)
+    (define-key map [help] isearch-help-map)
+    (define-key map [f1] isearch-help-map)
 
     (define-key map "\M-n" 'isearch-ring-advance)
     (define-key map "\M-p" 'isearch-ring-retreat)

> What about having a function in help.el for defining a binding for all
> three possibilities? Something like
>
>   (defun help-define-help-keys (map command)
>     (define-key map (char-to-string help-char) command)
>     (define-key map [help] command)
>     (define-key map [f1] command))

I'd rather remap all them to one key.

-- 
Juri Linkov
http://www.jurta.org/emacs/