From: Karl Fogel <kfogel@red-bean.com>
To: emacs-devel@gnu.org
Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer).
Date: Wed, 14 Jul 2010 12:55:52 -0400 [thread overview]
Message-ID: <877hky9f53.fsf@kslab.red-bean.com> (raw)
In-Reply-To: <87d3uqaw0l.fsf@kslab.red-bean.com> (Karl Fogel's message of "Wed, 14 Jul 2010 12:06:02 -0400")
Karl Fogel <kfogel@red-bean.com> writes:
>I have committed the changes, including the changes to Gnus (see Bzr
>revs below). Please post the C-w patch and I will apply that too.
Just so people know: this happened. All relevant bzr revisions below.
Thanks, Thierry, for making this feature work.
-Karl
------------------------------------------------------------
revno: 100821
revision-id: kfogel@red-bean.com-20100714164140-v2fdq4b6r45zpxev
parent: kfogel@red-bean.com-20100714160253-bbfda9e1g7myj1o8
author: Thierry Volpiatto <thierry.volpiatto@gmail.com>
committer: Karl Fogel <kfogel@red-bean.com>
branch nick: trunk
timestamp: Wed 2010-07-14 12:41:40 -0400
message:
Allow C-w when setting a bookmark in a Gnus Article buffer (Bug#5975).
* lisp/bookmark.el (bookmark-set): Don't set `bookmark-yank-point' and
`bookmark-current-buffer' if they have been already set in another
buffer (e.g gnus-art).
* lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Set
`bookmark-yank-point' and `bookmark-current-buffer' to allow C-w.
------------------------------------------------------------
revno: 100820
revision-id: kfogel@red-bean.com-20100714160253-bbfda9e1g7myj1o8
parent: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv
committer: Karl Fogel <kfogel@red-bean.com>
branch nick: trunk
timestamp: Wed 2010-07-14 12:02:53 -0400
message:
Allow bookmarks to be set from Gnus Article buffers (Bug #5975).
Patch applied (with minor tweaks) by Karl Fogel. Note this leaves
C-w still not working correctly from Article buffers; Thierry's
patch to fix that will be applied after this.
* lisp/gnus/gnus-art.el (bookmark-make-record-function): New local variable.
* lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Allow setting
from article buffer.
(gnus-summary-bookmark-jump): Maybe jump to article buffer.
------------------------------------------------------------
revno: 100819
revision-id: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv
parent: kfogel@red-bean.com-20100714155426-vnlagemntoe30nu6
committer: Karl Fogel <kfogel@red-bean.com>
branch nick: trunk
timestamp: Wed 2010-07-14 11:57:54 -0400
message:
Preparation for setting bookmarks in Gnus article buffers (Bug#5975).
* lisp/bookmark.el (bookmark-make-record-default): Allow unneeded
information to be omitted from the record.
Adjust declarations and calls:
* lisp/info.el (bookmark-make-record-default): Adjust declaration.
(Info-bookmark-make-record): Adjust call.
* lisp/woman.el (bookmark-make-record-default): Adjust declaration.
(woman-bookmark-make-record): Adjust call.
* lisp/man.el (bookmark-make-record-default): Adjust declaration.
(Man-bookmark-make-record): Adjust call.
* lisp/image-mode.el (bookmark-make-record-default): Adjust declaration.
* lisp/doc-view.el (bookmark-make-record-default): Adjust declaration.
* lisp/gnus/gnus-sum.el (bookmark-make-record-default): Adjust declaration.
------------------------------------------------------------
next prev parent reply other threads:[~2010-07-14 16:55 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 12:43 No answer on bugs Thierry Volpiatto
2010-06-29 13:12 ` Lennart Borgman
2010-06-29 13:54 ` Karl Fogel
2010-06-29 14:14 ` Thierry Volpiatto
2010-06-29 19:26 ` Tassilo Horn
2010-06-29 19:57 ` Thierry Volpiatto
2010-06-29 20:10 ` Tassilo Horn
2010-06-29 20:16 ` Thierry Volpiatto
2010-07-13 21:31 ` bug#5975: Base patch for bug #5975 (bookmarking from Gnus Article buffer) Karl Fogel
2010-07-13 21:31 ` Karl Fogel
2010-04-19 17:07 ` bug#5975: 24.0.50; [PATCH]Feature request: bookmarking from gnus article buffer Thierry Volpiatto
2010-05-17 14:14 ` Thierry Volpiatto
2010-07-13 21:46 ` bug#5975: Bazaar branch where this is being fixed Karl Fogel
2010-07-13 23:30 ` bug#5975: Base patch for bug #5975 (bookmarking from Gnus Article buffer) Glenn Morris
2010-07-14 19:48 ` bug#5975: [PATCH] Allow using C-w (bookmark-yank-word) when bookmarking from a gnus article buffer Thierry Volpiatto
2010-07-13 21:41 ` Base patch for bug #5975 (bookmarking from Gnus Article buffer) Karl Fogel
2010-07-14 8:29 ` Thierry Volpiatto
2010-07-14 8:37 ` Eli Zaretskii
2010-07-14 9:06 ` Thierry Volpiatto
2010-07-14 9:42 ` Eli Zaretskii
2010-07-14 10:07 ` Thierry Volpiatto
2010-07-14 10:18 ` Eli Zaretskii
2010-07-14 10:57 ` Thierry Volpiatto
2010-07-14 15:32 ` Karl Fogel
2010-07-13 21:41 ` bug#5975: " Karl Fogel
2010-07-13 23:30 ` Glenn Morris
2010-07-14 0:33 ` bug#5975: " Karl Fogel
2010-07-14 0:33 ` Karl Fogel
2010-07-14 8:55 ` Andreas Schwab
2010-07-14 15:29 ` Karl Fogel
2010-07-14 15:29 ` bug#5975: " Karl Fogel
2010-07-14 8:55 ` Andreas Schwab
2010-07-14 5:03 ` Thierry Volpiatto
2010-07-14 16:06 ` Karl Fogel
2010-07-14 16:55 ` Karl Fogel [this message]
2010-06-30 18:16 ` No answer on bugs Ted Zlatanov
2010-06-30 18:36 ` Thierry Volpiatto
2010-06-30 19:23 ` more on anything.el inclusion (was: No answer on bugs) Ted Zlatanov
2010-06-30 20:10 ` more on anything.el inclusion Thierry Volpiatto
2010-06-30 22:59 ` Dan Nicolaescu
2010-07-01 5:53 ` Thierry Volpiatto
2010-07-01 6:48 ` Dan Nicolaescu
2010-07-01 7:50 ` Thierry Volpiatto
2010-07-01 8:36 ` Dan Nicolaescu
2010-07-01 8:53 ` Thierry Volpiatto
2010-07-01 16:02 ` Dan Nicolaescu
2010-07-01 16:33 ` Harald Hanche-Olsen
2010-07-01 16:43 ` Ted Zlatanov
2010-07-01 17:18 ` Thierry Volpiatto
2010-07-01 17:43 ` Dan Nicolaescu
2010-07-01 18:14 ` Thierry Volpiatto
2010-07-01 18:48 ` Ted Zlatanov
2010-07-01 18:57 ` Wojciech Meyer
2010-07-01 17:36 ` Harald Hanche-Olsen
2010-07-01 15:20 ` Anything Use Case (was: more on anything.el inclusion) Memnon Anon
2010-07-01 13:18 ` more on anything.el inclusion Ted Zlatanov
2010-07-01 14:15 ` Thierry Volpiatto
2010-07-01 14:48 ` Lennart Borgman
2010-07-01 15:55 ` Ted Zlatanov
2010-07-01 16:43 ` Lennart Borgman
2010-07-01 18:55 ` Ted Zlatanov
2010-07-01 22:08 ` Lennart Borgman
2010-07-09 14:46 ` Thierry Volpiatto
2010-07-17 13:37 ` rubikitch
2010-07-17 15:16 ` Thierry Volpiatto
2010-07-04 22:02 ` Stefan Monnier
2010-07-07 16:47 ` Ted Zlatanov
2010-07-23 15:35 ` Stefan Monnier
2010-07-23 21:49 ` rubikitch
2010-08-12 23:02 ` Ted Zlatanov
2010-08-24 19:24 ` rubikitch
2010-08-25 13:51 ` Juri Linkov
2010-09-11 12:02 ` Thierry Volpiatto
2010-09-11 11:59 ` Thierry Volpiatto
[not found] <87630icytd.fsf@tux.homenetwork>
2010-07-14 16:44 ` bug#5975: [PATCH] Allow using C-w (bookmark-yank-word) when bookmarking from a gnus article buffer Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hky9f53.fsf@kslab.red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.