From: Chong Yidong <cyd@stupidchicken.com>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs core TLS support
Date: Fri, 13 Aug 2010 20:15:30 -0400 [thread overview]
Message-ID: <877hju123h.fsf@stupidchicken.com> (raw)
In-Reply-To: <878w4actmg.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 13 Aug 2010 12:25:27 -0500")
Ted Zlatanov <tzz@lifelogs.com> writes:
> Simon's code included a gnutls.el library, attached here. It shows how
> to use it.
OK, that makes sense. Though I feel queasy about this:
(defconst gnutls-cipher-null 1)
(defconst gnutls-cipher-arcfour 2)
...
being intended to map to
typedef enum gnutls_cipher_algorithm
{
GNUTLS_CIPHER_UNKNOWN = 0,
GNUTLS_CIPHER_NULL = 1,
GNUTLS_CIPHER_ARCFOUR_128,
...
from gnutls.h. The more Emacs-Lisp-y approach is to let the gnutls-*
built-in functions accept symbols rather than integers, i.e. instead of
(gnutls-protocol-set-priority proc gnutls-tls1 gnutls-ssl3)
it should be called as
(gnutls-protocol-set-priority proc 'gnutls-tls1 'gnutls-ssl3),
and `gnutls-protocol-set-priority' should internally convert those
symbol arguments to GNUTLS_SSL3 and GNUTLS_TLS1, and pass them to the
GnuTLS function gnutls_protocol_set_priority.
I think this can be done by taking Fsymbol_name of each argument, and
using the accessor functionss provided by the GnuTLS library, e.g.
`gnutls_protocol_get_id'. (We thus avoid defining many dozens of Lisp
symbols beforehand, like Qssl3, Qtls1, etc.). We can also be fancy, by
not requiring the `gnutls' part of the symbol argument and appending it
in the C code:
(gnutls-protocol-set-priority proc 'tls1 'ssl3)
I realize this is a rather invasive change to the patch. I suggest
separating the GnuTLS code into a separate file, gnutls.c, adding it to
the Emacs repository, and work from there. Then you don't have to keep
sending the patch to the mailing list.
next prev parent reply other threads:[~2010-08-14 0:15 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 21:53 Emacs core TLS support Ted Zlatanov
2010-01-13 23:46 ` Chong Yidong
2010-01-14 14:09 ` Ted Zlatanov
2010-01-14 15:44 ` Stefan Monnier
2010-01-14 16:38 ` Ted Zlatanov
2010-01-29 19:59 ` Ted Zlatanov
2010-08-12 23:00 ` Ted Zlatanov
2010-08-13 11:04 ` James Cloos
2010-08-13 15:07 ` Ted Zlatanov
2010-08-13 15:51 ` Julien Danjou
2010-08-13 16:11 ` Eli Zaretskii
2010-08-13 15:53 ` David Kastrup
2010-08-13 16:11 ` Julien Danjou
2010-08-13 15:57 ` Chong Yidong
2010-08-13 17:25 ` Ted Zlatanov
2010-08-14 0:15 ` Chong Yidong [this message]
2010-09-05 4:57 ` Ted Zlatanov
2010-09-05 8:06 ` Andreas Schwab
2010-09-05 22:47 ` Stefan Monnier
2010-09-06 7:47 ` Andreas Schwab
2010-09-06 14:31 ` Ted Zlatanov
2010-09-06 15:53 ` Andreas Schwab
2010-09-06 17:18 ` Andreas Schwab
2010-09-09 15:12 ` Ted Zlatanov
2010-09-09 22:00 ` Lars Magne Ingebrigtsen
2010-09-10 8:33 ` Andreas Schwab
2010-09-10 10:59 ` Lars Magne Ingebrigtsen
2010-09-10 14:06 ` Ted Zlatanov
2010-09-11 12:45 ` Stefan Monnier
2010-09-14 15:34 ` Ted Zlatanov
2010-09-06 21:00 ` Stefan Monnier
2010-09-06 23:13 ` Ted Zlatanov
2010-09-11 14:59 ` Ted Zlatanov
2010-09-11 15:00 ` Ted Zlatanov
2010-09-12 10:58 ` Stefan Monnier
2010-09-14 15:45 ` Ted Zlatanov
2010-09-13 7:49 ` Nikos Mavrogiannopoulos
2010-09-14 18:30 ` Ted Zlatanov
2010-09-14 18:55 ` Nikos Mavrogiannopoulos
2010-09-14 19:10 ` Lars Magne Ingebrigtsen
2010-09-15 11:20 ` Ted Zlatanov
2010-09-15 1:25 ` Ted Zlatanov
2010-09-15 11:01 ` Ted Zlatanov
2010-09-15 12:13 ` Nikos Mavrogiannopoulos
2010-09-15 15:40 ` Ted Zlatanov
2010-09-26 6:09 ` Ted Zlatanov
2010-09-26 15:32 ` Lars Magne Ingebrigtsen
2010-09-26 21:50 ` James Cloos
2010-09-27 13:37 ` Lars Magne Ingebrigtsen
2010-09-27 13:56 ` Lars Magne Ingebrigtsen
2010-09-27 14:03 ` Lars Magne Ingebrigtsen
2010-09-27 14:11 ` Lars Magne Ingebrigtsen
2010-09-27 14:21 ` Lars Magne Ingebrigtsen
2010-09-27 14:40 ` Lars Magne Ingebrigtsen
2010-09-27 14:56 ` Ted Zlatanov
2010-09-27 15:13 ` Lars Magne Ingebrigtsen
2010-09-27 15:02 ` Bruce Stephens
2010-09-27 15:07 ` Lars Magne Ingebrigtsen
2010-09-27 15:18 ` Lars Magne Ingebrigtsen
2010-09-27 15:11 ` Ted Zlatanov
2010-09-27 15:14 ` Lars Magne Ingebrigtsen
2010-09-27 14:42 ` Ted Zlatanov
2010-09-29 12:53 ` Lars Magne Ingebrigtsen
2010-09-29 13:25 ` Lars Magne Ingebrigtsen
2010-09-29 18:36 ` Jason Earl
2010-09-29 20:05 ` Ted Zlatanov
2010-09-29 20:32 ` Jason Earl
2010-09-29 20:35 ` Lars Magne Ingebrigtsen
2010-09-29 21:33 ` Jason Earl
2010-09-29 17:06 ` Ted Zlatanov
2010-09-29 17:44 ` Ted Zlatanov
2010-09-29 18:43 ` Lars Magne Ingebrigtsen
2010-09-29 18:43 ` Lars Magne Ingebrigtsen
2010-10-03 14:21 ` Ted Zlatanov
2010-10-03 14:48 ` Ted Zlatanov
2010-10-03 22:37 ` Lars Magne Ingebrigtsen
2010-10-04 1:23 ` final GnuTLS API! (was: Emacs core TLS support) Ted Zlatanov
2010-10-04 10:49 ` final GnuTLS API! Lars Magne Ingebrigtsen
2010-10-04 14:44 ` Ted Zlatanov
2010-09-27 14:36 ` Emacs core TLS support Ted Zlatanov
2010-09-27 18:25 ` James Cloos
2010-09-27 18:45 ` Ted Zlatanov
2010-09-27 19:07 ` Lars Magne Ingebrigtsen
2010-09-27 19:38 ` Lars Magne Ingebrigtsen
2010-09-21 11:37 ` Simon Josefsson
2010-09-26 6:12 ` Ted Zlatanov
2010-09-30 10:10 ` Simon Josefsson
2010-10-04 3:42 ` Ted Zlatanov
2010-10-04 6:24 ` Nikos Mavrogiannopoulos
2010-08-13 13:54 ` Leo
2010-08-13 14:50 ` Ted Zlatanov
2010-08-14 19:20 ` Leo
-- strict thread matches above, loose matches on Subject: below --
2010-01-14 1:37 MON KEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hju123h.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.