From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#7190: Crash in menus on w32 Date: Thu, 21 Oct 2010 23:27:10 +0800 Message-ID: <877hhb4ldd.fsf@home.jasonrumney.net> References: <4CC01FDD.5060707@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1287675848 12396 80.91.229.12 (21 Oct 2010 15:44:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 21 Oct 2010 15:44:08 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: grischka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 21 17:44:06 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P8xJG-0007Kl-5l for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Oct 2010 17:44:06 +0200 Original-Received: from localhost ([127.0.0.1]:33196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8xJF-0004TI-EQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Oct 2010 11:44:05 -0400 Original-Received: from [140.186.70.92] (port=39389 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8xHz-0003jv-UY for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:42:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8xHy-00026q-JQ for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:42:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8xHy-00026m-H8 for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:42:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P8wzq-0007O5-AN; Thu, 21 Oct 2010 11:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jason Rumney Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2010 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7190 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.128767461328390 (code B ref -1); Thu, 21 Oct 2010 15:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Oct 2010 15:23:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8wzM-0007Nr-Jl for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:23:32 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8wzK-0007Nj-Ev for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:23:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8x32-0005Zu-M2 for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:27:21 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:38087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8x32-0005Zo-Jd for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:27:20 -0400 Original-Received: from [140.186.70.92] (port=51443 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8x31-0006nK-Fl for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8x30-0005Z7-3k for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:19 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:55560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8x2z-0005Yf-Ss for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:18 -0400 Original-Received: by iwn1 with SMTP id 1so5892550iwn.0 for ; Thu, 21 Oct 2010 08:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=KBpUH+hukazPJHYSJbKybUpAc6z3EyQJSnu/+9xRR5s=; b=qr9GEZJZOmT8+3qUY6azSKIZhytnS5BhWu6J1puX1VbkELl6H9NSjzn/hXWHtlCZdv TQ+8Nzud65CtuVQhx2ZZqGEhTSQLRst2MX4PA2+mn0036GikuKppVjWUgmBX0DlCKJaz rs9XQiIl5i7SLVK/k73B29iEJY/iTfBJ8QDy4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Fmz90zgiHygxAmh10899aJ+UvBgARQqq+UkAeg1GWOD1nnXw3HBFcIVIXh+Kirz6tM 1j748TJg4eFB7qvUI9CD9294ZAWf/bcPoVOmZYubBEZVbAEyDZDd4ScA/JDyZKqwAn6t vU1D+r/qjoq7oDyydtUOllIcZJLLVTPXo8elY= Original-Received: by 10.231.38.13 with SMTP id z13mr1045073ibd.169.1287674836209; Thu, 21 Oct 2010 08:27:16 -0700 (PDT) Original-Received: from home.jasonrumney.net ([202.87.221.130]) by mx.google.com with ESMTPS id in12sm1881870ibb.3.2010.10.21.08.27.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 21 Oct 2010 08:27:15 -0700 (PDT) Original-Received: by home.jasonrumney.net (Postfix, from userid 1000) id 8BACB7AC; Thu, 21 Oct 2010 23:27:10 +0800 (MYT) In-Reply-To: <4CC01FDD.5060707@gmx.de> (grischka's message of "Thu, 21 Oct 2010 13:11:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 21 Oct 2010 11:24:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41036 Archived-At: grischka writes: > case WM_EXITMENULOOP: > f = x_window_to_frame (dpyinfo, hwnd); > > - /* If a menu is still active, check again after a short delay, > - since Windows often (always?) sends the WM_EXITMENULOOP > - before the corresponding WM_COMMAND message. > - Don't do this if a popup menu is active, since it is only > - menubar menus that require cleaning up in this way. > - */ > if (f && menubar_in_use && current_popup_menu == NULL) > - menu_free_timer = SetTimer (hwnd, MENU_FREE_ID, MENU_FREE_DELAY, NULL); > + { > + f->output_data.w32->menubar_active = 0; > + menubar_in_use = 0; > + } I don't see anything in your change to handle freeing of the menubar structures in the case where the user clicks on the menubar then clicks away without selecting anything. The above code was to fix a memory and resource leak in that case. Jason