From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el(shr-tag-color-check):Convert colors to hexadecimal withshr-color->hexadecimal. Date: Wed, 24 Nov 2010 22:33:34 +0100 Message-ID: <877hg22yq9.fsf@keller.adm.naquadah.org> References: <961v6bom3j.fsf@fencepost.gnu.org> <87eiabdc04.fsf@stupidchicken.com> <87ipznhhe3.fsf@keller.adm.naquadah.org> <87mxoz7mml.fsf@stupidchicken.com> <874ob71y6v.fsf@stupidchicken.com> <4A76DA00C61D4637AC671E53FB7A4FCB@us.oracle.com> <87d3pvf5s2.fsf@keller.adm.naquadah.org> <87d3pu617f.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1290634432 2981 80.91.229.12 (24 Nov 2010 21:33:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 24 Nov 2010 21:33:52 +0000 (UTC) Cc: 'Ted Zlatanov' , emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 24 22:33:47 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PLMyJ-0000xa-J6 for ged-emacs-devel@m.gmane.org; Wed, 24 Nov 2010 22:33:47 +0100 Original-Received: from localhost ([127.0.0.1]:54752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLMyI-0001OJ-W7 for ged-emacs-devel@m.gmane.org; Wed, 24 Nov 2010 16:33:47 -0500 Original-Received: from [140.186.70.92] (port=39900 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLMyC-0001NM-4e for emacs-devel@gnu.org; Wed, 24 Nov 2010 16:33:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLMyA-00088C-Ug for emacs-devel@gnu.org; Wed, 24 Nov 2010 16:33:40 -0500 Original-Received: from prometheus.naquadah.org ([212.85.154.174]:40565 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLMyA-000888-LN for emacs-devel@gnu.org; Wed, 24 Nov 2010 16:33:38 -0500 Original-Received: by mx1.naquadah.org (Postfix, from userid 8) id 68F855C1C8; Wed, 24 Nov 2010 22:33:37 +0100 (CET) Original-Received: from keller.adm.naquadah.org (unknown [IPv6:2a01:e35:2e39:e900:222:faff:fe9d:ce44]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 692BF5C1BB; Wed, 24 Nov 2010 22:33:35 +0100 (CET) Original-Received: from jd by keller.adm.naquadah.org with local (Exim 4.72) (envelope-from ) id 1PLMy6-0002vz-ST; Wed, 24 Nov 2010 22:33:34 +0100 Mail-Followup-To: "Drew Adams" , "'Ted Zlatanov'" , In-Reply-To: (Drew Adams's message of "Wed, 24 Nov 2010 13:00:14 -0800") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133126 Archived-At: <#secure method=pgpmime mode=sign> On Wed, Nov 24 2010, Drew Adams wrote: > 1. Change any calls of those two functions to use the corresponding hexrg= b.el > functions instead. Then test the color-lab use (the two versions might n= ot be > exactly equivalent, even if they do essentially the same thing). These 2 functions are not used by any code in color-lab (or Gnus). They have been merged in because, well, I wrote them so it seemed like a good idea to no throw them in the trash right. > 2. Since there is apparently no other overlap, put all of the code from t= he two > libraries into a single file. > > 3. Choose a new file name and fix the name prefixes accordingly. "hexrgb"= is > probably not general enough (it is not even general enough for all that i= t does > now, since the name reflects only RGB, not HSV). I don't think "color-la= b" is a > good name for this general library either; this is not just about CIELAB. > > How about just "color.el"? Since it will end in Emacs, fine with me. I did not choose color.el on start on Lars advice, since, that name was too generic. But a generic name for a generic color library in Emacs sounds good. :) > Yidong might want to do #4, since it involves some deciding and he is fam= iliar > with the Emacs `read-color' code and recent changes. I agree. > Why not merge only the parts of color-lab.el that involve color manipulat= ions > with hexrgb.el, and keep the rest (e.g. heuristics about readability and > color-blindness, color-vision profiles, HTML use etc.) in a separate Emacs > library? It's already in a separate library called shr-color.el. > IOW, _if_ color-lab.el has both (a) general color-manipulation/conversion > functions and (b) application-specific functions that use those general > functions, then wouldn't it make sense to keep the latter separate? (No,= I > don't care - it's just a question.) It has only (a). What I can do on my side is: 1. Rename color-lab.el to color.el 2. Merge things other people sends inside, as long as it's basic color manipulation related stuff (conversion, etc). Sounds good? --=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info