From: Julien Danjou <julien@danjou.info>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'Ted Zlatanov' <tzz@lifelogs.com>, emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el(shr-tag-color-check):Convert colors to hexadecimal withshr-color->hexadecimal.
Date: Wed, 24 Nov 2010 22:33:34 +0100 [thread overview]
Message-ID: <877hg22yq9.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: <CFFB5B1A9AD444ADA276547C7166817D@us.oracle.com> (Drew Adams's message of "Wed, 24 Nov 2010 13:00:14 -0800")
<#secure method=pgpmime mode=sign>
On Wed, Nov 24 2010, Drew Adams wrote:
> 1. Change any calls of those two functions to use the corresponding hexrgb.el
> functions instead. Then test the color-lab use (the two versions might not be
> exactly equivalent, even if they do essentially the same thing).
These 2 functions are not used by any code in color-lab (or Gnus). They
have been merged in because, well, I wrote them so it seemed like a good
idea to no throw them in the trash right.
> 2. Since there is apparently no other overlap, put all of the code from the two
> libraries into a single file.
>
> 3. Choose a new file name and fix the name prefixes accordingly. "hexrgb" is
> probably not general enough (it is not even general enough for all that it does
> now, since the name reflects only RGB, not HSV). I don't think "color-lab" is a
> good name for this general library either; this is not just about CIELAB.
>
> How about just "color.el"?
Since it will end in Emacs, fine with me. I did not choose color.el on
start on Lars advice, since, that name was too generic. But a generic
name for a generic color library in Emacs sounds good. :)
> Yidong might want to do #4, since it involves some deciding and he is familiar
> with the Emacs `read-color' code and recent changes.
I agree.
> Why not merge only the parts of color-lab.el that involve color manipulations
> with hexrgb.el, and keep the rest (e.g. heuristics about readability and
> color-blindness, color-vision profiles, HTML use etc.) in a separate Emacs
> library?
It's already in a separate library called shr-color.el.
> IOW, _if_ color-lab.el has both (a) general color-manipulation/conversion
> functions and (b) application-specific functions that use those general
> functions, then wouldn't it make sense to keep the latter separate? (No, I
> don't care - it's just a question.)
It has only (a).
What I can do on my side is:
1. Rename color-lab.el to color.el
2. Merge things other people sends inside, as long as it's basic color
manipulation related stuff (conversion, etc).
Sounds good?
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
next prev parent reply other threads:[~2010-11-24 21:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1PKgZg-0005td-8L@internal.in.savannah.gnu.org>
2010-11-23 19:50 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert colors to hexadecimal with shr-color->hexadecimal Glenn Morris
2010-11-23 20:24 ` Chong Yidong
2010-11-23 21:14 ` Julien Danjou
2010-11-23 21:31 ` Chong Yidong
2010-11-23 21:38 ` Lars Magne Ingebrigtsen
2010-11-23 22:18 ` Chong Yidong
2010-11-23 22:34 ` Lars Magne Ingebrigtsen
2010-11-24 0:12 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert " Drew Adams
2010-11-24 9:08 ` Julien Danjou
2010-11-24 11:35 ` Eli Zaretskii
2010-11-24 14:46 ` Stefan Monnier
2010-11-24 15:30 ` Lennart Borgman
2010-11-24 18:15 ` Ted Zlatanov
2010-11-24 21:37 ` Lennart Borgman
2010-11-24 22:19 ` Lars Magne Ingebrigtsen
2010-11-24 22:41 ` Use color-tweaking code to improve face defaults? [was: /srv/bzr/emacs/trunk r1...] Drew Adams
2010-11-25 4:53 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal Stefan Monnier
2010-12-10 19:19 ` Ted Zlatanov
2010-11-24 16:15 ` Drew Adams
2010-11-24 18:11 ` Ted Zlatanov
2010-11-24 21:00 ` /srv/bzr/emacs/trunk r102478: shr.el(shr-tag-color-check):Convert colors to hexadecimal withshr-color->hexadecimal Drew Adams
2010-11-24 21:33 ` Julien Danjou [this message]
2010-11-24 21:51 ` Drew Adams
2010-11-24 16:29 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal Chong Yidong
2010-11-24 0:05 ` Drew Adams
2010-11-24 8:36 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert " Richard Stallman
2010-11-24 14:42 ` Stefan Monnier
2010-11-23 21:16 ` Lars Magne Ingebrigtsen
2010-11-23 22:19 ` Ted Zlatanov
2010-11-23 21:14 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hg22yq9.fsf@keller.adm.naquadah.org \
--to=julien@danjou.info \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.