From: Miles Bader <miles@gnu.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'Chong Yidong' <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: color.el
Date: Sun, 20 Feb 2011 13:07:12 +0900 [thread overview]
Message-ID: <877hcvtklr.fsf@catnip.gol.com> (raw)
In-Reply-To: <3028FDD10C5A4C1A8BF109BAA0CA773B@us.oracle.com> (Drew Adams's message of "Sat, 19 Feb 2011 19:19:57 -0800")
"Drew Adams" <drew.adams@oracle.com> writes:
>> Radians seem cleaner; an argument range of 0-360 only seems
>> useful if an interface is primarily user-level (e.g. a spec
>> in a web page or something).
>
> Cleaner than what? than [0,360]? than [0,1]? than both?
> And why? In particular, why would [0,2*pi] be cleaner than [0,1]?
Actually I was just comparing to 0-360; I agree that 0-1 is probably the
best of them all.
[A possible exception might be if you're trying very hard to avoid
consing; then maybe any use of floats is undesirable. It doesn't seem
that's considered an issue with this API tho...]
> I agree (if you are saying this) that the input and return values of these
> functions should not assume only or even primarily user-level use cases (e.g.
> web-page color spec). They should be general functions. This is essentially a
> utility library of building-block functions.
Agree.
> IMO, the values should be of the same type (a) for all components (r,g,b,h,s,v),
> and (b) for both input and return values. We should not be sometimes passing in
> [0,1] for RGB and other times passing in [0,255] for RGB. Similarly for return
> values. And we should not use [0,360] for H but [0,1] for S and V.
I agree.
I'd rather not ever use 0-255 in the interface though. _If_ it's
sometimes desirable to use integers instead of floats for color
components, 0-65535 gives higher resolution, is already in use by Emacs
color functions (`color-values'), and can be efficiently (without
division) converted to 0-255 internally when that range is desirable
(for backends or whatever).
-Miles
--
Dinanzi a me non fuor cose create
se non etterne, e io etterno duro.
Lasciate ogne speranza, voi ch'intrate.
next prev parent reply other threads:[~2011-02-20 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 0:23 color.el Drew Adams
2011-02-19 18:33 ` color.el Chong Yidong
2011-02-20 0:17 ` color.el Drew Adams
2011-02-20 1:10 ` color.el Miles Bader
2011-02-20 3:19 ` color.el Drew Adams
2011-02-20 4:07 ` Miles Bader [this message]
2011-02-20 15:44 ` color.el Drew Adams
2011-02-21 17:30 ` color.el Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hcvtklr.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.