all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ralph Schleicher <rs@ralph-schleicher.de>
To: 8259@debbugs.gnu.org
Subject: bug#8259: browse-url-of-dired-file fails to browse . and ..
Date: Tue, 15 Mar 2011 20:55:43 +0100	[thread overview]
Message-ID: <877hc0jgzk.fsf@bravo.mueller-schleicher.i> (raw)

Hi,

browse-url-of-dired-file signals an error if the user attempts to
browse one of the special file names '.' or '..'.  I see no reason
why it should not be possible to browse these file names like any
other directory file name.  Below is a patch together with a change
log entry.


2011-03-11  Ralph Schleicher  <rs@ralph-schleicher.de>

	* net/browse-url.el (browse-url-of-dired-file): Enable browsing
	of special file names `.' and `..'.


--- emacs-23.3/lisp/net/browse-url.el.orig	2011-01-08 12:45:14 +0100
+++ emacs-23.3/lisp/net/browse-url.el	2011-03-11 11:42:23 +0100
@@ -756,7 +756,10 @@
 (defun browse-url-of-dired-file ()
   "In Dired, ask a WWW browser to display the file named on this line."
   (interactive)
-  (browse-url-of-file (dired-get-filename)))
+  (let ((tem (dired-get-filename t t)))
+    (if (null tem)
+	(error "No file on this line")
+      (browse-url-of-file (expand-file-name tem default-directory)))))
 
 ;;;###autoload
 (defun browse-url-of-region (min max)


-- 
Ralph





             reply	other threads:[~2011-03-15 19:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 19:55 Ralph Schleicher [this message]
2011-05-08 18:35 ` bug#8259: browse-url-of-dired-file fails to browse . and Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hc0jgzk.fsf@bravo.mueller-schleicher.i \
    --to=rs@ralph-schleicher.de \
    --cc=8259@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.