Error because org-refile calls org-back-to-heading

Error because org-refile calls org-back-to-heading

[Matt Lundin]

I use the following function to jump quickly to first level headings
in my org mode files:

--8<---------------cut here---------------start------------->8---
(defun my-org-global-goto ()
  (interactive)
  (let ((org-completion-use-ido t)
	(org-outline-path-complete-in-steps nil)
	(org-refile-use-outline-path nil)
	(org-refile-targets '((my-org-refile-targets :maxlevel . 1))))
    (org-refile t)
    (org-reveal '(64))))
--8<---------------cut here---------------end--------------->8---

Since the commit c25165c25dc9fdb5b57b3c66b2e0ec0efdbeb7ad on August 18,
I can only call this function when I am beneath the first level heading
of an org-mode file. Otherwise I receive the following error:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (error "Before first headline at position 1 in buffer *Annotate org.el (rev master)*")
  signal(error ("Before first headline at position 1 in buffer *Annotate org.el (rev master)*"))
  error("Before first headline at position %d in buffer %s" 1 #<buffer *Annotate org.el (rev master)*>)
  byte-code("\300\301`p#\207" [error "Before first headline at position %d in buffer %s"] 4)
  org-back-to-heading(t)
  org-refile(t)
  my-org-global-goto()
  call-interactively(my-org-global-goto nil nil)
--8<---------------cut here---------------end--------------->8---

This seems a unnecessary restriction/error when calling org-refile with
the GOTO argument, since there is no need to be on a current headline
when jumping to another headline.

Thanks,
Matt

Re: Error because org-refile calls org-back-to-heading

[Matt Lundin]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Matt Lundin <mdl@imapmail.org> writes:

> Since the commit c25165c25dc9fdb5b57b3c66b2e0ec0efdbeb7ad on August 18,
> I can only call this function when I am beneath the first level heading
> of an org-mode file. Otherwise I receive the following error:

Here's a patch that allows one to call (org-refile t) in a non org-mode
buffer without resulting in an error.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-No-need-to-call-org-back-to-heading-with-goto-argume.patch --]
[-- Type: text/x-patch, Size: 929 bytes --]

From 785f08ec86017df72bf3b30fdbd522c8ff0f4cb5 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Mon, 22 Aug 2011 09:26:57 -0500
Subject: [PATCH] No need to call org-back-to-heading with goto argument.

* lisp/org.el: (org-refile) Don't call org-back-to-heading with goto
  argument.

This fixes an error that results when calling org-refile with the
GOTO argument in a non-org buffer.
---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index de8c72b..0c66828 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10495,7 +10495,7 @@ prefix argument (`C-u C-u C-u C-c C-w')."
 		      (setq goto nil)))
 	       (setq it (or rfloc
 			    (save-excursion
-			      (org-back-to-heading t)
+			      (unless goto (org-back-to-heading t))
 			      (org-refile-get-location
 			       (cond (goto "Goto")
 				     (regionp "Refile region to")
-- 
1.7.6

Re: Error because org-refile calls org-back-to-heading

[Bastien]

Matt Lundin <mdl@imapmail.org> writes:

> Matt Lundin <mdl@imapmail.org> writes:
>
>> Since the commit c25165c25dc9fdb5b57b3c66b2e0ec0efdbeb7ad on August 18,
>> I can only call this function when I am beneath the first level heading
>> of an org-mode file. Otherwise I receive the following error:
>
> Here's a patch that allows one to call (org-refile t) in a non org-mode
> buffer without resulting in an error.

Applied, thanks!

-- 
 Bastien