From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] minibuffer issue with eshell-command Date: Thu, 06 Oct 2011 18:22:01 +0200 Message-ID: <877h4irsye.fsf@gmail.com> References: <87lisy7g00.fsf@gmail.com> <87hb3me15c.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1317918156 27830 80.91.229.12 (6 Oct 2011 16:22:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2011 16:22:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 06 18:22:32 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RBqiN-0005mL-0k for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 18:22:31 +0200 Original-Received: from localhost ([::1]:60673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBqiG-0007kT-Oc for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 12:22:24 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBqi0-0006s4-Si for emacs-devel@gnu.org; Thu, 06 Oct 2011 12:22:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBqhz-0005UI-Nz for emacs-devel@gnu.org; Thu, 06 Oct 2011 12:22:08 -0400 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:46858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBqhz-0005UD-LQ for emacs-devel@gnu.org; Thu, 06 Oct 2011 12:22:07 -0400 Original-Received: by ggdk5 with SMTP id k5so2240600ggd.0 for ; Thu, 06 Oct 2011 09:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=fTdWDSGSp5oKIOJrCTCR780xon+qF8JxQ112POWvH60=; b=Aj1gxmwH1QBDJWJKx154ich5ZN7NHUs7Xh4VvjuqL4zlQBCe5NQ2SbPhdIS6WRsuzi rXp7TMkLwlEQls/34Cdr80orpkFJyUL3wvcB3scSRluvBNLoEHNeCQIcUI9N3OobWfoC BnorYGz6tuYdBkA9EKr/2TVLRGsZ6YzR2BSFs= Original-Received: by 10.236.176.130 with SMTP id b2mr4438774yhm.57.1317918126482; Thu, 06 Oct 2011 09:22:06 -0700 (PDT) Original-Received: from thierry-MM061 (214.77.197.77.rev.sfr.net. [77.197.77.214]) by mx.google.com with ESMTPS id r30sm8246013yhj.20.2011.10.06.09.22.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 09:22:05 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 06 Oct 2011 11:36:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:144620 Archived-At: Stefan Monnier writes: >>> When eshell-command start, it set eshell-mode in all minibuffers: >>> ;(add-hook 'minibuffer-setup-hook 'eshell-mode) >>> So when running another minibuffer, while eshell-command is started, >>> it enable eshell-mode in this one, which is wrong. >>> This patch fix this: > >> Any objections to push this on trunk? > > That looks OK, except that I think the add-hooks should be moved to the > setup-hook function where they can be made to only apply locally (and > I guess at that point you can get rid of the remove-hooks). Right. I have already commited this, i will modify tomorrow. --=20 =F0=9D=95=8B=F0=9D=95=99=F0=9D=95=9A=F0=9D=95=96=F0=9D=95=A3=F0=9D=95=A3= =F0=9D=95=AA Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997=20