From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode Date: Thu, 01 Dec 2011 01:37:39 +0800 Message-ID: <877h2h1pgc.fsf@gnu.org> References: <4ED58F60.4000604@code-affinity.com> <83bort60k0.fsf@gnu.org> <8762i13766.fsf@gnu.org> <838vmx5z28.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1322674696 28733 80.91.229.12 (30 Nov 2011 17:38:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2011 17:38:16 +0000 (UTC) To: 10164@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 18:38:12 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVo6h-00071Q-LG for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 18:38:07 +0100 Original-Received: from localhost ([::1]:40403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVo6h-00033Y-9B for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 12:38:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:59365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVo6e-00033D-Ce for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 12:38:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVo6X-0007Zf-S2 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 12:38:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVo6X-0007ZN-Mc for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 12:37:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVo6b-0005KZ-K8 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 12:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2011 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10164-submit@debbugs.gnu.org id=B10164.132267467820483 (code B ref 10164); Wed, 30 Nov 2011 17:38:01 +0000 Original-Received: (at 10164) by debbugs.gnu.org; 30 Nov 2011 17:37:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVo6X-0005KJ-On for submit@debbugs.gnu.org; Wed, 30 Nov 2011 12:37:58 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVo6W-0005KC-2j for 10164@debbugs.gnu.org; Wed, 30 Nov 2011 12:37:56 -0500 Original-Received: from bb121-6-69-237.singnet.com.sg ([121.6.69.237]:48684 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RVo6Q-0003Ux-8u; Wed, 30 Nov 2011 12:37:51 -0500 In-Reply-To: <838vmx5z28.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Nov 2011 18:56:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Nov 2011 12:38:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54496 Archived-At: Eli Zaretskii writes: > Thanks. The bug is fixed in revision 106561. > > It was simply wrong to try to verify rows' hash values at that spot, > because the code immediately before that reallocates the glyph arrays, > so the contents of a glyph row could be complete garbage. Therefore, > I removed the assertion. > > I'm amazed that this assertion didn't trigger until now. I guess too > few people compile with asserts. Or maybe most calls to > adjust_glyph_matrix don't really reallocate, since display margins are > a relatively rarely used feature. > > Sorry about this, it was a shameful thinko on my part to introduce > that assertion in the first place. No worries, and thanks for looking into the problem on such short notice. I'll make the pretest shortly.