BUG: org-todo-yesterday logs wrong date

BUG: org-todo-yesterday logs wrong date

[Viktor Rosenfeld]

Hi,

org-todo-yesterday and org-agenda-todo-yesterday log a note using the
current timestamp and not a timestamp of 23:59 of yesterday's date.

I'm using Org-Mode 7.7 pulled today from the git repository.

Cheers,
Viktor

Re: BUG: org-todo-yesterday logs wrong date

[Geert Kloosterman]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

On Wed, Oct 19, 2011 at 1:17 AM, Viktor Rosenfeld <listuser36@googlemail.com
> wrote:

>
> org-todo-yesterday and org-agenda-todo-yesterday log a note using the
> current timestamp and not a timestamp of 23:59 of yesterday's date.
>
> I'm using Org-Mode 7.7 pulled today from the git repository.
>
>
I'm experiencing the same problem with the org-mode version I pulled from
git today.

Switching back to the 7.7 tarball fixes the problem.

Best regards,
Geert Kloosterman

[-- Attachment #2: Type: text/html, Size: 782 bytes --]

Re: BUG: org-todo-yesterday logs wrong date

[Bernt Hansen]

Geert Kloosterman <g.j.kloosterman@gmail.com> writes:

> Hi all,
>
> On Wed, Oct 19, 2011 at 1:17 AM, Viktor Rosenfeld <
> listuser36@googlemail.com> wrote:
>
>    
>     org-todo-yesterday and org-agenda-todo-yesterday log a note using
>     the
>     current timestamp and not a timestamp of 23:59 of yesterday's
>     date.
>    
>     I'm using Org-Mode 7.7 pulled today from the git repository.
>    
>
>
> I'm experiencing the same problem with the org-mode version I pulled
> from git today. 
>
> Switching back to the 7.7 tarball fixes the problem.
>
> Best regards,
> Geert Kloosterman
>  

Git bisect identifies the following commit as the source of this
problem.

7d2d8f884b2e22e3056553ea68858fe4fc674427 is the first bad commit
commit 7d2d8f884b2e22e3056553ea68858fe4fc674427
Author: John Wiegley <johnw@newartisans.com>
Date:   Sat Aug 13 03:21:49 2011 -0500

    Add customization variable `org-use-effective-time'
    
    If non-nil, consider `org-extend-today-until' when creating timestamps.
    For example, if `org-extend-today-until' is 8, and it's 4am, then the
    "effective time" of any timestamps between midnight and 8am will be
    23:59 of the previous day.

:040000 040000 a33f65040163763ed06996b9ffc18bcfc5884457 0782571b08e0a128fa3b072b8b8edf177c001ca3 M	lisp

Regards,
Bernt

Re: BUG: org-todo-yesterday logs wrong date

[Viktor Rosenfeld]

Hi Bernt,

Bernt Hansen wrote:

> Geert Kloosterman <g.j.kloosterman@gmail.com> writes:
> 
> > Hi all,
> >
> > On Wed, Oct 19, 2011 at 1:17 AM, Viktor Rosenfeld <
> > listuser36@googlemail.com> wrote:
> >
> >    
> >     org-todo-yesterday and org-agenda-todo-yesterday log a note using
> >     the
> >     current timestamp and not a timestamp of 23:59 of yesterday's
> >     date.
> >    
> >     I'm using Org-Mode 7.7 pulled today from the git repository.
> >    
> >
> >
> > I'm experiencing the same problem with the org-mode version I pulled
> > from git today. 
> >
> > Switching back to the 7.7 tarball fixes the problem.
> >
> > Best regards,
> > Geert Kloosterman
> >  
> 
> Git bisect identifies the following commit as the source of this
> problem.
> 
> 7d2d8f884b2e22e3056553ea68858fe4fc674427 is the first bad commit
> commit 7d2d8f884b2e22e3056553ea68858fe4fc674427
> Author: John Wiegley <johnw@newartisans.com>
> Date:   Sat Aug 13 03:21:49 2011 -0500
> 
>     Add customization variable `org-use-effective-time'
>     
>     If non-nil, consider `org-extend-today-until' when creating timestamps.
>     For example, if `org-extend-today-until' is 8, and it's 4am, then the
>     "effective time" of any timestamps between midnight and 8am will be
>     23:59 of the previous day.
> 
> :040000 040000 a33f65040163763ed06996b9ffc18bcfc5884457 0782571b08e0a128fa3b072b8b8edf177c001ca3 M	lisp
> 
> Regards,
> Bernt

Thanks for the info. Setting org-use-effective-time to 1 fixes the
problem, even if org-extend-today-until is zero. I'm curious though why
its type is integer and not boolean.

Thanks again,
Viktor
 

Re: BUG: org-todo-yesterday logs wrong date

[Bastien]

Viktor Rosenfeld <listuser36@googlemail.com> writes:

> I'm curious though why its type is integer and not boolean.

This was a mistake, fixed now.

Thanks!

-- 
 Bastien