bug#11352: 24.1.50; revno 108047 broke assoc.el

bug#11352: 24.1.50; revno 108047 broke assoc.el

[Sam Steingold]

In GNU Emacs 24.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-04-26 on t520sds
Bzr revision: 108047 monnier@iro.umontreal.ca-20120426124328-gp2hlhjj57zsox58
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
Configured using:
 `configure '--with-wide-int''


revno: 108047
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Thu 2012-04-26 08:43:28 -0400
message:
  Replace lexical-let by lexical-binding (except Gnus, CEDET, ERT).
  * lisp/term/ns-win.el (ns-define-service):
  * lisp/progmodes/pascal.el (pascal-goto-defun):
  * lisp/progmodes/js.el (js--read-tab):
  * lisp/progmodes/etags.el (tags-lazy-completion-table):
  * lisp/emacs-lisp/syntax.el (syntax-propertize-via-font-lock):
  * lisp/emacs-lisp/ewoc.el (ewoc--wrap):
  * lisp/emacs-lisp/assoc.el (aput, adelete, amake):
  * lisp/doc-view.el (doc-view-convert-current-doc):
  * lisp/url/url.el (url-retrieve-synchronously):
  * lisp/vc/diff.el (diff-no-select): Replace lexical-let by lexical-binding.


this results in "unbound symbol copy" errors all over the place because
aget assumes dynamic binding for copy:

  (let ((copy (copy-alist alist)))
    (cond ((null alist) nil)
------>>> ((progn (asort 'copy key)  <<<--------------
		  (anot-head-p copy key)) nil)
	  ((cdr (car copy)))
	  (keynil-p nil)
	  ((car (car copy)))
	  (t nil)))



-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 11.10 (oneiric) X 11.0.11004000
http://www.childpsy.net/ http://openvotingconsortium.org http://camera.org
http://thereligionofpeace.com http://palestinefacts.org
Lisp is a language for doing what you've been told is impossible. - Kent Pitman

bug#11352: 24.1.50; revno 108047 broke assoc.el

[Stefan Monnier]

> this results in "unbound symbol copy" errors all over the place because
> aget assumes dynamic binding for copy:

Thanks, should be fixed now.
BTW, what do you use assoc.el for?


        Stefan

bug#11352: 24.1.50; revno 108047 broke assoc.el

[Sam Steingold]

> * Stefan Monnier <zbaavre@VEB.HZbagerny.PN> [2012-04-26 14:21:40 -0400]:
>
>> this results in "unbound symbol copy" errors all over the place because
>> aget assumes dynamic binding for copy:
>
> Thanks, should be fixed now.

thanks!

> BTW, what do you use assoc.el for?

gnus uses it for netrc parsing.


-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 11.10 (oneiric) X 11.0.11004000
http://www.childpsy.net/ http://camera.org http://palestinefacts.org
http://www.memritv.org http://iris.org.il http://openvotingconsortium.org
Murphy's Law was probably named after the wrong guy.