From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: toggle-read-only should not give compilation warnings Date: Wed, 11 Jul 2012 12:11:57 +0800 Message-ID: <877gubszqq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341979935 29344 80.91.229.3 (11 Jul 2012 04:12:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Jul 2012 04:12:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 11 06:12:13 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SooHZ-0003zp-VE for ged-emacs-devel@m.gmane.org; Wed, 11 Jul 2012 06:12:10 +0200 Original-Received: from localhost ([::1]:56956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SooHY-00027s-PN for ged-emacs-devel@m.gmane.org; Wed, 11 Jul 2012 00:12:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SooHW-00027l-50 for emacs-devel@gnu.org; Wed, 11 Jul 2012 00:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SooHU-00005n-Eh for emacs-devel@gnu.org; Wed, 11 Jul 2012 00:12:05 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:60764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SooHU-00005j-BJ for emacs-devel@gnu.org; Wed, 11 Jul 2012 00:12:04 -0400 Original-Received: from [155.69.18.117] (port=52347 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SooHT-0004oe-5g for emacs-devel@gnu.org; Wed, 11 Jul 2012 00:12:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151523 Archived-At: There are lots of toggle-read-only warnings in the Emacs Lisp source tree. As far as I can tell, the overwhelming majority of these are all legitimate use cases. The typical intention is "do whatever the `toggle-read-only' command does, then do some other stuff on top of that," so the caveat about toggle-read-only not being used in Lisp code is bogus. Instead of sprinking with-no-warnings all over, I propose removing toggle-read-only from byte-compile-interactive-only-functions. Any objections?