all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'David Reitter' <david.reitter@gmail.com>,
	3210@debbugs.gnu.org, 3408-done@debbugs.gnu.org
Subject: bug#3210: bug#3408: bug#3210: face customization fails after set-face-attribute
Date: Sun, 25 Nov 2012 13:04:32 +0800	[thread overview]
Message-ID: <877gpas273.fsf@gnu.org> (raw)
In-Reply-To: <B1B4880C4EBF41378113293BE8492047@us.oracle.com> (Drew Adams's message of "Sat, 24 Nov 2012 20:52:07 -0800")

"Drew Adams" <drew.adams@oracle.com> writes:

> Bug #3408 is a _regression_, and it has not been fixed.
> A regression is certainly NOT `notabug'.

I disagree that this is a bug.  I have now taken another look at the
code, and my earlier conclusion stands.  Modifications to internal Lisp
faces (via set-face-attribute) take precedence over the effect of face
specs, so the behavior is working as intended and as documented
(including in the docstring of set-face-attribute).

The trunk now contains a change to face-spec-set which allows it to be
more easily called from Lisp code to override defface specs.  If you
want to modify faces from Lisp, use that rather than set-face-attribute.

Don't re-open this bug based on uninformed opinion.  Thanks.





      reply	other threads:[~2012-11-25  5:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 20:04 bug#3210: face customization fails after set-face-attribute David Reitter
2012-06-09  5:39 ` Chong Yidong
2012-06-09 15:12   ` bug#3408: " Drew Adams
2012-11-25  4:52     ` bug#3210: " Drew Adams
2012-11-25  5:04       ` Chong Yidong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gpas273.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=3210@debbugs.gnu.org \
    --cc=3408-done@debbugs.gnu.org \
    --cc=david.reitter@gmail.com \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.