From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#13563: tabulated-list-print-col nicer help-echo Date: Sun, 27 Jan 2013 04:58:30 +0100 Message-ID: <877gmzwa3d.fsf@bernoul.li> References: <877gmzve82.fsf@bernoul.li> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359259133 14664 80.91.229.3 (27 Jan 2013 03:58:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jan 2013 03:58:53 +0000 (UTC) Cc: 13563@debbugs.gnu.org To: "Glenn Morris" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 27 04:59:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TzJOg-0000w4-Fy for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2013 04:59:10 +0100 Original-Received: from localhost ([::1]:45134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzJOO-000081-Gn for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 22:58:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzJOL-00007w-Hp for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 22:58:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzJOI-000897-Cg for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 22:58:49 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzJOI-000893-9c for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 22:58:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TzJOY-0005o8-Qs for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 22:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 03:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13563 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13563-submit@debbugs.gnu.org id=B13563.135925913622311 (code B ref 13563); Sun, 27 Jan 2013 03:59:02 +0000 Original-Received: (at 13563) by debbugs.gnu.org; 27 Jan 2013 03:58:56 +0000 Original-Received: from localhost ([127.0.0.1]:50931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzJOR-0005nn-G4 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 22:58:56 -0500 Original-Received: from mail-ee0-f50.google.com ([74.125.83.50]:53075) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzJOM-0005nb-UH for 13563@debbugs.gnu.org; Sat, 26 Jan 2013 22:58:52 -0500 Original-Received: by mail-ee0-f50.google.com with SMTP id e51so804852eek.37 for <13563@debbugs.gnu.org>; Sat, 26 Jan 2013 19:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:user-agent :in-reply-to:date:message-id:mime-version:content-type; bh=2NFzSixVjgxMyyK+qjGgtDvE2nA7v3kgfhC/oipqRPE=; b=URh2OjhbTlBv5JfXt9V8XEJrcwLjz4mBNSYFIx4dHyeNl0Z64v6DhqiSD+Duv+cxaC OTCVny/6fAsfjfmygHVO7UKsuumfTUkTebPIzWr6j6Xt+xT184EKytL1NBnF1NBoBUcT hfH65Mzhw/9M7TNqFy1zRsYaON1cLA6ovL2ypOWVQCJOBEDKg8xQ/iTEfUKdnmd9pJFf McxOMCGm0kXSspTkAO2lEGTN8s04WL7z+clDo1De/6fU9bo6ybn5bYOaPATs9IcRUa2J tLE0YfXwel3j294lbJhb2rsj/vhxs2mxb9RVbkAmUqEJ+6tYsKYINlprUVccOYnktHwD rjhw== X-Received: by 10.14.223.137 with SMTP id v9mr36847966eep.22.1359259112602; Sat, 26 Jan 2013 19:58:32 -0800 (PST) Original-Received: from lem (178-83-148-119.dynamic.hispeed.ch. [178.83.148.119]) by mx.google.com with ESMTPS id q5sm9389340eeo.17.2013.01.26.19.58.31 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Jan 2013 19:58:31 -0800 (PST) User-agent: mu4e 0.9.9.5-dev6; emacs 24.3.50.1 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70363 Archived-At: Glenn Morris writes: > Jonas Bernoulli wrote: > >> `tabulated-list-set-col' adds a help-echo property to the "labels" that >> it inserts. With this patch this is done a bit differently: >> >> * If the label already has a help-echo property then use that help-echo >> instead of overriding it with a generic one. This allows displaying >> additional information when it makes sense. > > Seems good. > >> * Otherwise propertize as before but don't prefix the help-echo with the >> column name. That information is not really useful. > > Not sure I agree. Eg in Buffer-menu mode, the prefix is useful IMO. I don't find it very useful since the same information is also displayed in the header-line. But if the other change is merged then I can easily work around this by explicitly setting the help-echo in my Tabulated-List mode derived modes. One other thing I forgot to include in this pull request: I think it would make sense to set `x-stretch-cursor' to nil in `tabulated-list-mode'. One shouldn't set that to t globally (I did for a while, silly me) but it also does not hurt to actively override such a setting in cases where it is known not to make any sense. I don't care much about this (after all I have not enabled this globally anymore:). Let me know what you think and I will create a new patch with the second change above removed and this one included if desired.