* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.
[not found] <E1U1XMJ-0001f2-Lv@vcs.savannah.gnu.org>
@ 2013-02-02 15:29 ` Stefan Monnier
2013-02-02 15:50 ` Christopher Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2013-02-02 15:29 UTC (permalink / raw)
To: Christopher Schmidt; +Cc: emacs-devel
> - "List of hook functions run by `compilation-start' on the compilation process.
> -\(See `run-hook-with-args').
> -If you use \"omake -P\" and do not want \\[save-buffers-kill-terminal] to ask whether you want
> -the compilation to be killed, you can use this hook:
> - (add-hook 'compilation-start-hook
> - (lambda (process) (set-process-query-on-exit-flag process nil)) nil t)"
> + "Hook run after starting a new compilation process. The hook
> +is run with one argument, the new process."
I like part of this simplification, but the first line of a docstring
should "stand on its own" (i.e. it shouldn't end in the middle of
a sentence). In this case, the best is to cut the line between
"process." and "The hook".
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.
2013-02-02 15:29 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring Stefan Monnier
@ 2013-02-02 15:50 ` Christopher Schmidt
2013-02-03 13:48 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Schmidt @ 2013-02-02 15:50 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I like part of this simplification, but the first line of a docstring
> should "stand on its own" (i.e. it shouldn't end in the middle of
> a sentence). In this case, the best is to cut the line between
> "process." and "The hook".
Didn't I fix this in 111662?
I am sorry for the inconvenience. :(
Christopher
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.
2013-02-02 15:50 ` Christopher Schmidt
@ 2013-02-03 13:48 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2013-02-03 13:48 UTC (permalink / raw)
To: emacs-devel
>> I like part of this simplification, but the first line of a docstring
>> should "stand on its own" (i.e. it shouldn't end in the middle of
>> a sentence). In this case, the best is to cut the line between
>> "process." and "The hook".
> Didn't I fix this in 111662?
You did, I just replied before I got to see that had fixed it already.
> I am sorry for the inconvenience. :(
There's nothing to be sorry for.
And thanks for your contributions,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-03 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1U1XMJ-0001f2-Lv@vcs.savannah.gnu.org>
2013-02-02 15:29 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring Stefan Monnier
2013-02-02 15:50 ` Christopher Schmidt
2013-02-03 13:48 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.