Small org-contacts patch

Small org-contacts patch

[Simon Thum]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Hi all,

the attached patch solves the problem of having hexified strings in hte 
vCard export. It happens when you are entering tel: links and phone 
numbers that start with `+`. The plus sign causes the link insert helper 
to hexify the url.

In tel: links the plus makes sense for international numbers. The C-c 
C-l helper makes that

[[tel:%-encoded glibberish][tel:+49 xxx]]

with the %-encoded part ending up in vCards. Which my phone accepts but 
does not dial properly. So far I cleaned them manually but this seems a 
better solution.

Cheers,

Simon

[-- Attachment #2: 0001-un-hexify-TEL-links-in-vCard-export.patch --]
[-- Type: text/x-patch, Size: 1111 bytes --]

From 8a1fdc7f87425fc6f7d6909fc9dc10cc0ca1745d Mon Sep 17 00:00:00 2001
From: Simon Thum <simon.thum@gmx.de>
Date: Sun, 22 Sep 2013 13:43:06 +0200
Subject: [PATCH] un-hexify TEL links in vCard export

This is required as a plus sign (e.g. +49 for germany) will cause
hexification in the link helper.

contrib/lisp/org-contacts.el: unhexify tel link

TINYCHANGE
---
 contrib/lisp/org-contacts.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 97171d0..dbbc057 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -946,7 +946,7 @@ to do our best."
 			(setq phones-list (org-contacts-remove-ignored-property-values ignore-list (org-contacts-split-property tel)))
 			(setq result "")
 			(while phones-list
-			  (setq result (concat result  "TEL:" (org-contacts-strip-link (car phones-list)) "\n"))
+			  (setq result (concat result  "TEL:" (org-link-unescape (org-contacts-strip-link (car phones-list))) "\n"))
 			  (setq phones-list (cdr phones-list)))
 			result))
 	    (when bday
-- 
1.8.1.5

Re: Small org-contacts patch

[Bastien]

Hi Simon,

Simon Thum <simon.thum@gmx.de> writes:

> the attached patch solves the problem of having hexified strings in
> hte vCard export. It happens when you are entering tel: links and
> phone numbers that start with `+`. The plus sign causes the link
> insert helper to hexify the url.
>
> In tel: links the plus makes sense for international numbers. The C-c 
> C-l helper makes that
>
> [[tel:%-encoded glibberish][tel:+49 xxx]]
>
> with the %-encoded part ending up in vCards. Which my phone accepts
> but does not dial properly. So far I cleaned them manually but this
> seems a better solution.

applied in master, thanks.

-- 
 Bastien